New issue
Advanced search Search tips

Issue 732655 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 462133



Sign in to add a comment

MacViews(a11y): Views textfields should expose the "show menu" action

Project Member Reported by tapted@chromium.org, Jun 13 2017

Issue description

Chrome Version       : 60.0.3112.7
OS Version: OS X 10.12.5

1. Open OSX Accessibility Inspector
2. Open bookmark bubble, hover over the textfield

The "Show menu" action should be present. ("Performing" that action should show a context menu).
 
Screen Shot 2017-06-13 at 12.33.32 pm.png
10.9 KB View Download

Comment 1 by tapted@chromium.org, Jun 20 2017

Owner: tapted@chromium.org
Status: Started (was: Available)
https://codereview.chromium.org/2944083004
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/926329391ace2c7470f55b275988a09f4f1fd06b

commit 926329391ace2c7470f55b275988a09f4f1fd06b
Author: tapted <tapted@chromium.org>
Date: Mon Jul 03 04:16:16 2017

MacViews a11y: Support the "Show menu" action in Textfield and Combobox.

Currently Combobox and Textfield show no actions available to
accessibility.

For Mac, fix by mapping the default action (a click) to
NSAccessibilityPressAction and map AX_ACTION_SHOW_CONTEXT_MENU to
NSAccessibilityShowMenuAction. For comboboxes, both
NSAccessibilityPressAction and NSAccessibilityShowMenuAction show a
menu. For textfields, just the latter.

On Mac, automatically add and handle NSAccessibilityShowMenuAction for
controls that show a menu on press and don't have a separate context
menu.

For Textfields (and other controls using context menus), automatically
add ui::AX_ACTION_SHOW_CONTEXT_MENU for views that have a context menu
controller.

Comboboxes are trickier since the View that usually handles clicks is a
"TransparentButton". So handle these actions explicitly.

For menus triggered by a11y actions, there may be no mouse event. Cocoa
needs one to position the menu, so generate a dummy event for this.

BUG= 679247 ,  663536 ,  732655 

Review-Url: https://codereview.chromium.org/2944083004
Cr-Commit-Position: refs/heads/master@{#483939}

[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/accessibility/platform/ax_platform_node_mac.h
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/combobox/combobox.h
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/combobox/combobox_unittest.cc
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/menu/menu_runner_impl_cocoa.mm
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/widget/native_widget_mac_accessibility_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment