Rename MemoryAllocatorDumpGUID since it is not really a generic GUID |
||
Issue descriptionBackground context: go/memory-infra A GUID refers to a 64 bit globally unique ID. But, in case of the allocator dumps, the "guid" is misued for a unique ID across all processes in the current memory dump. So, the MemoryAllocatorDumpGUID should be renamed to something more meaningful to refer to an unique ID across processes for a particular memory dump. Comments about the name welcome. Suggestions: MemoryAllocatorDumpTraceUID MemoryAllocatorGlobalDumpUID MemoryAllocatorDumpCrossProcessUID
,
Jun 13 2017
Yeah we had this discussion on slack. Unfortunately right now the term GUID is used pretty much everywhere in telemetry, traceviewer and our codebase. Not sure how much is worth the effort. Definitely not right now as we have many too many functional refactorings going on for the service/UMA stuff. Maybe towards end of Q3 when things should have settled more?
,
Mar 29 2018
FYI: this mojom file has been renamed at some point and recently moved to //mojo/public/mojom/base: https://chromium-review.googlesource.com/c/chromium/src/+/978783 So looks like this bug can be closed.
,
Mar 29 2018
That is cool. Thanks! I think this should still be open since the actual struct is still named MemoryAllocatorDumpGUID.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
||
►
Sign in to add a comment |
||
Comment 1 by ssid@chromium.org
, Jun 13 2017