Get Cronet interversion tests running in M60 |
|||||
Issue descriptionIn order to get Cronet inter-version tests running in M60 a few changes need to be merged back: r475560 - [Cronet] add missing certificate file for tests r475941 - [Cronet] Make new API tests conditional on the new APIs being present. r475743 - [Cronet] Add null-check to avoid crashing case where no tests are run r475988 - [Cronet] Fix test issue on Marshmallow, need to call parent setUp() All changes are exclusively in src/components/cronet so they will in no way impact the Chrome releases as Chrome is not dependent on Cronet. All changes were made a couple weeks ago so they have had time to go into various canary and dev releases.
,
Jun 13 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2017
Why were we unable to get these fixed prior to branch? I'll approve for M60 branch 3112 this time, but let's try to do better in the future next time.
,
Jun 14 2017
> Why were we unable to get these fixed prior to branch? Sorry, things got very busy. I'll try harder to get them in before next branch point.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e274f92135ae7167ad45260e2752641dfcc87e56 commit e274f92135ae7167ad45260e2752641dfcc87e56 Author: Paul Jensen <pauljensen@google.com> Date: Wed Jun 14 02:14:20 2017 [m60 merge] [Cronet] add missing certificate file for tests Was added for new netty/tcnative in r467848, and needs to be included in Cronet test assets so Cronet tests can run. TBR=kapishnikov CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG= 732625 Review-Url: https://codereview.chromium.org/2911223002 Cr-Original-Commit-Position: refs/heads/master@{#475560} Review-Url: https://codereview.chromium.org/2935213002 . Cr-Commit-Position: refs/branch-heads/3112@{#338} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/e274f92135ae7167ad45260e2752641dfcc87e56/components/cronet/android/BUILD.gn
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/800597e6030929371f9171793c0d18fead8ad9b2 commit 800597e6030929371f9171793c0d18fead8ad9b2 Author: Paul Jensen <pauljensen@google.com> Date: Wed Jun 14 02:24:04 2017 [m60 merge] [Cronet] Add null-check to avoid crashing case where no tests are run This can happen in testAndroidTestCaseSetupProperly(), see https://d.android.com/reference/android/test/AndroidTestCase.html#testAndroidTestCaseSetupProperly() which is an empty test case. Chromium avoids this but other test systems don't. Also, remove a redundant loadLibrary call. TBR=xunjieli CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG= 732625 Review-Url: https://codereview.chromium.org/2909223004 Cr-Original-Commit-Position: refs/heads/master@{#475743} Review-Url: https://codereview.chromium.org/2940773002 . Cr-Commit-Position: refs/branch-heads/3112@{#339} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/800597e6030929371f9171793c0d18fead8ad9b2/components/cronet/android/test/javatests/src/org/chromium/net/BrotliTest.java
,
Jun 14 2017
,
Jun 14 2017
Not sure why bugdroid didn't comment, but the last two merges happened in 7be18cb317b99f275eb9ee9c4f43a9e1ad9be388.
,
Jun 16 2017
For reference: all fixes are in 60.0.3112.33 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pauljensen@chromium.org
, Jun 13 2017