New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732616 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit 27 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 696126



Sign in to add a comment

ARM graphics_WebGLAquarium failure starting with 9636.0.0..9637.0.0

Project Member Reported by ihf@chromium.org, Jun 13 2017

Issue description

Cc: tutankhamen@chromium.org ihf@chromium.org
 Issue 732613  has been merged into this issue.

Comment 2 by ihf@chromium.org, Jun 13 2017

Cc: r...@chromium.org steve...@chromium.org

Comment 3 by ihf@chromium.org, Jun 13 2017

Status: Started (was: Untriaged)
Robert is bisecting Chrome right now.
commit	10b29d38bbd2eb90d7d93fb07214d468f7af7dde by Kai Ninomiya <kainino@chromium.org> breaks webgl on arm devices:

"Workaround for Qualcomm renderbuffer resize bug
Also re-enables the explicit resolve path on the Qualcomm devices which
have EXT_multisampled_render_to_texture disabled."

Will try to extract this commit from the top of the tree.
Labels: -Pri-3 Pri-1
Not sure why this is P3, this is P1 since we can't ship with that.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2205e65faf366cf1748e6a72c4a41188b07e05b

commit a2205e65faf366cf1748e6a72c4a41188b07e05b
Author: marcheu <marcheu@google.com>
Date: Wed Jun 14 05:03:30 2017

Revert "Workaround for Qualcomm renderbuffer resize bug"

This reverts commit 10b29d38bbd2eb90d7d93fb07214d468f7af7dde.

This breaks WebGL on ARM Chromebooks.

BUG= chromium:732616 
TEST=webgl works again on Chrome OS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2936973003
Cr-Commit-Position: refs/heads/master@{#479289}

[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/command_buffer/service/renderbuffer_manager.cc
[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/command_buffer/service/renderbuffer_manager.h
[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/config/gpu_driver_bug_list.json
[modify] https://crrev.com/a2205e65faf366cf1748e6a72c4a41188b07e05b/gpu/config/gpu_driver_bug_workaround_type.h

Comment 8 by kbr@chromium.org, Jun 16 2017

Blocking: 696126

Comment 9 by kbr@chromium.org, Jun 16 2017

It's unfortunate that this was reverted. Could someone from the Chrome OS team work with me to debug why that driver bug workaround broke things on ARM Chromebooks? Certainly the workaround itself was not supposed to take effect on ARM GPUs.

Comment 10 by kbr@chromium.org, Jun 19 2017

Status: Fixed (was: Started)
We debugged this together and the breaking commit has been reverted and the adjustment to the original code is understood.

Sign in to add a comment