New issue
Advanced search Search tips

Issue 732611 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 732609



Sign in to add a comment

[SPv2] painting and invalidation on scrolling contents layer

Project Member Reported by wangxianzhu@chromium.org, Jun 13 2017

Issue description

Ensure BoxPaintInvalidator::InvalidateScrollingContentsBackgroundIfNeeded() fully works for SPv2.
 
Blocking: 732609
Labels: -OS-Fuchsia
Summary: [SPv175/SPv2] Raster invalidation for background on scrolling contents layer (was: [SPv2] Raster invalidation for background on scrolling contents layer )
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ac572d1274efe519d7a6151c102549e228b1a77

commit 7ac572d1274efe519d7a6151c102549e228b1a77
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Nov 01 19:39:20 2017

[SPv175] Support incremental invalidation on scrolling contents layer

When the scrolling contents layer is resized and it paints the
background, we should invalidate the expanded/shrunk part of the
background. For SPv1 this is done by calling IncrementallyInvalidatePaint.
For SPv175 we need to pass kIncremental reason to PaintController.

Bug:  732611 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d
Reviewed-on: https://chromium-review.googlesource.com/749283
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513221}
[add] https://crrev.com/7ac572d1274efe519d7a6151c102549e228b1a77/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/paint/invalidation/compositing/background-attachment-local-composited-expected.txt
[add] https://crrev.com/7ac572d1274efe519d7a6151c102549e228b1a77/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/paint/invalidation/compositing/background-attachment-local-equivalent-expected.txt
[modify] https://crrev.com/7ac572d1274efe519d7a6151c102549e228b1a77/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e5cbdeda87a8a6d9c6a65a6224689c1d8bc61b5

commit 4e5cbdeda87a8a6d9c6a65a6224689c1d8bc61b5
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Wed Nov 01 21:33:09 2017

Revert "[SPv175] Support incremental invalidation on scrolling contents layer"

This reverts commit 7ac572d1274efe519d7a6151c102549e228b1a77.

Reason for revert: Reverting on suspicion of breaking webkit_layout_tests on many Mac bots. See, e.g.:

https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6891
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/25624

-- Chromium sheriff

Original change's description:
> [SPv175] Support incremental invalidation on scrolling contents layer
> 
> When the scrolling contents layer is resized and it paints the
> background, we should invalidate the expanded/shrunk part of the
> background. For SPv1 this is done by calling IncrementallyInvalidatePaint.
> For SPv175 we need to pass kIncremental reason to PaintController.
> 
> Bug:  732611 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d
> Reviewed-on: https://chromium-review.googlesource.com/749283
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513221}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: I534c53fc28e9d657bbc7759aa80ac84cee065beb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  732611 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/750001
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513278}
[delete] https://crrev.com/7fa8f03f813112bb0237fcc2dbd5f8212eee6e3b/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/paint/invalidation/compositing/background-attachment-local-composited-expected.txt
[delete] https://crrev.com/7fa8f03f813112bb0237fcc2dbd5f8212eee6e3b/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/paint/invalidation/compositing/background-attachment-local-equivalent-expected.txt
[modify] https://crrev.com/4e5cbdeda87a8a6d9c6a65a6224689c1d8bc61b5/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e2064683f5407fef65a7e8b59370e199424cb41

commit 0e2064683f5407fef65a7e8b59370e199424cb41
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Nov 01 21:44:19 2017

Reland "[SPv175] Support incremental invalidation on scrolling contents layer"

This reverts commit 4e5cbdeda87a8a6d9c6a65a6224689c1d8bc61b5.

Reason for reland: It is not the reason of the break.

Original change's description:
> Revert "[SPv175] Support incremental invalidation on scrolling contents layer"
> 
> This reverts commit 7ac572d1274efe519d7a6151c102549e228b1a77.
> 
> Reason for revert: Reverting on suspicion of breaking webkit_layout_tests on many Mac bots. See, e.g.:
> 
> https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6891
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/25624
> 
> -- Chromium sheriff
> 
> Original change's description:
> > [SPv175] Support incremental invalidation on scrolling contents layer
> > 
> > When the scrolling contents layer is resized and it paints the
> > background, we should invalidate the expanded/shrunk part of the
> > background. For SPv1 this is done by calling IncrementallyInvalidatePaint.
> > For SPv175 we need to pass kIncremental reason to PaintController.
> > 
> > Bug:  732611 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d
> > Reviewed-on: https://chromium-review.googlesource.com/749283
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#513221}
> 
> TBR=wangxianzhu@chromium.org,pdr@chromium.org
> 
> Change-Id: I534c53fc28e9d657bbc7759aa80ac84cee065beb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  732611 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/750001
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513278}

TBR=wangxianzhu@chromium.org,pdr@chromium.org,jdonnelly@chromium.org

Change-Id: I2d882d39f99449496b053be9b29f6e4d64deec85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  732611 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/749922
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513284}
[add] https://crrev.com/0e2064683f5407fef65a7e8b59370e199424cb41/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/paint/invalidation/compositing/background-attachment-local-composited-expected.txt
[add] https://crrev.com/0e2064683f5407fef65a7e8b59370e199424cb41/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/paint/invalidation/compositing/background-attachment-local-equivalent-expected.txt
[modify] https://crrev.com/0e2064683f5407fef65a7e8b59370e199424cb41/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Summary: [SPv2] Raster invalidation for background on scrolling contents layer (was: [SPv175/SPv2] Raster invalidation for background on scrolling contents layer )
The remaining issue is for SPv2 only.
Summary: [SPv2] painting and invalidation on LayoutView's scrolling contents layer (was: [SPv2] Raster invalidation for background on scrolling contents layer )
The root cause seems about painting which caused the invalidation issue.
Status: Started (was: Assigned)
Summary: [SPv2] painting and invalidation on scrolling contents layer (was: [SPv2] painting and invalidation on LayoutView's scrolling contents layer)
We need a special DisplayItemClient for the background painted on the scrolling contents layer.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4970db683f2db95e6d638af2c6cc3f489a19d217

commit 4970db683f2db95e6d638af2c6cc3f489a19d217
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Oct 24 03:32:33 2018

[CI/PE] Cleanup background paint invalidation

- Replace LayoutObject::SetBackgroundChangedSinceLastPaintInvaldiation()
  with LayoutObject::SetBackgroundNeedsFullPaintInvalidation().

  - Previously we used SetShouldDoFullPaintInvalidation(
    PaintInvalidationReason::kBackground) in some cases, but it may miss
    invalidation of background painted on the scrolling contents layer.
    Now use the new method in all cases that the background needs full
    paint invalidation.

- Move all view background paint invalidation into BoxPaintInvalidator.
  This simplifies the call sites which now just call
  SetShouldCheckForPaintInvalidation(), and make it possible to do just
  incremental invalidation instead of full invalidation when the browser
  control hides and background at the bottom appears on Android.

- Other cleanups

- New tests

This is a preparation for SPv2 scrolling background invalidation.

Bug:  732611 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0d51d0788e614021c177de478e8cf70e5507aa7f
Reviewed-on: https://chromium-review.googlesource.com/c/1289994
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602244}
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/compositing/squashing/invalidations-with-large-negative-margin-inline-content-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/compositing/squashing/repaint-child-of-squashed-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/compositing/squashing/squash-paint-invalidation-fixed-position-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/compositing/squashing/squash-transform-repainting-child-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/compositing/squashing/squashed-repaints-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/squash-transform-repainting-child-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/box/hover-pseudo-borders-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/repaint-via-layout-offset-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/should-not-clip-composited-viewport-scrolling-layer-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/negative-text-indent-with-overflow-hidden-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/positioned-document-element-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/fixed-child-of-transformed-move-after-scroll-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/invalidate-after-composited-scroll-of-window-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/composited-table-background-composited-row-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/composited-table-background-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/composited-table-background-section-composited-row-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/composited-table-background-section-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/invalidate-cell-in-row-with-offset-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-generated-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-resize-height-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-shorthand-with-gradient-and-height-changes-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-size-auto-with-gradient-and-height-changes-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/backgroundSizeRepaint-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/hover-pseudo-borders-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/button-spurious-layout-hint-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/clip-unclip-and-change-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/compositing/float-under-composited-inline-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/compositing/invalidations-on-composited-layers-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-composite-1-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-composite-2-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-composite-3-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-composite-4-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-composite-5-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-composite-6-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-displacement-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-gaussianblur-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-gaussianblur-xonly-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-gaussianblur-yonly-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-merge-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-morphology-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-morphology-xonly-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-morphology-yonly-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/effect-reference-repaint-offset-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/iframe-rounding-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/image/do-not-paint-below-image-baseline-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/layer-full-repaint-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/layer-visibility-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/multicol/multicol-with-overflowing-block-rl-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-not-affected-by-descendant-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/negative-text-indent-with-overflow-hidden-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/rel-positioned-inline-with-overflow-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/invalidate-paint-for-fixed-pos-inside-iframe-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/raster-under-invalidation-checking-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/repaint-in-iframe-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/repaint-on-style-change-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/change-background-color-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/cached-69296-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/composited-table-background-composited-row-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/composited-table-background-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/composited-table-background-section-composited-row-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/composited-table-background-section-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/invalidate-cell-in-row-with-offset-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/invisible-tbody-visible-td-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/invisible-tr-visible-td-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/table-row-bg-change-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/table-row-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/table-with-padding-row-invalidation-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/background-generated-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/background-image-paint-invalidation-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/background-resize-height-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/background-shorthand-with-gradient-and-height-changes-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/background-size-auto-with-gradient-and-height-changes-expected.txt
[add] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/composited-background-on-both-layers-expected.html
[add] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/composited-background-on-both-layers-expected.txt
[add] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/composited-background-on-both-layers.html
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/full-viewport-repaint-for-background-attachment-fixed-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/box/hover-pseudo-borders-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/button-spurious-layout-hint-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-unclip-and-change-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/column-span-under-composited-column-child-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/composited-float-under-composited-inline-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/composited-float-under-composited-inline-individual-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/float-under-composited-inline-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/invalidate-paint-in-iframe-in-composited-layer-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/invalidation-for-subpixel-offset-of-squashed-layer-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/invalidations-on-composited-layers-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/repaint-overflow-scrolled-squashed-content-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/repaint-squashed-layer-in-rect-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/repaint-via-layout-offset-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-viewport-scrolling-layer-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/squash-partial-repaint-inside-squashed-layer-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/squashing-inside-preserve-3d-element-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/stacked-float-under-composited-inline-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/compositing/updating-scrolling-content-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-1-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-2-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-3-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-4-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-5-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-6-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-displacement-expected.txt
[modify] https://crrev.com/4970db683f2db95e6d638af2c6cc3f489a19d217/third_party/WebKit/LayoutTests/paint/invalidation/filter
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af460e9a5c4ac34692ffa109e87f744ce082b5c0

commit af460e9a5c4ac34692ffa109e87f744ce082b5c0
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Oct 24 04:38:15 2018

[CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject

For fixing SlimmingPaintV2 scrolling background painting and
invalidation, we need a single place to get the accurate value
of the background paint location.

Bug:  732611 

Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f
Reviewed-on: https://chromium-review.googlesource.com/c/1297586
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602250}
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/layout/layout_box_model_object.cc
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/layout/layout_box_model_object.h
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/paint/paint_layer.h
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/af460e9a5c4ac34692ffa109e87f744ce082b5c0/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c3cbcc16d0bca1952b75fb5b6cada8285108f37

commit 0c3cbcc16d0bca1952b75fb5b6cada8285108f37
Author: Marc Treib <treib@chromium.org>
Date: Wed Oct 24 10:28:03 2018

Revert "[CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject"

This reverts commit af460e9a5c4ac34692ffa109e87f744ce082b5c0.

Reason for revert:
Seems to have broken paint/invalidation/table/cached-69296.html from webkit_layout_tests on Mac 10.11 - currently failed 7/7 times after this landed:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests
First failing build:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/30030

Original change's description:
> [CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject
> 
> For fixing SlimmingPaintV2 scrolling background painting and
> invalidation, we need a single place to get the accurate value
> of the background paint location.
> 
> Bug:  732611 
> 
> Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f
> Reviewed-on: https://chromium-review.googlesource.com/c/1297586
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602250}

TBR=flackr@chromium.org,wangxianzhu@chromium.org

Change-Id: I279520fc9deafd9891dd3a5457e42d6fa0b201aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  732611 
Reviewed-on: https://chromium-review.googlesource.com/c/1297362
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602289}
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/layout/layout_box_model_object.cc
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/layout/layout_box_model_object.h
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/paint/paint_layer.h
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/0c3cbcc16d0bca1952b75fb5b6cada8285108f37/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd

commit 4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd
Author: Marc Treib <treib@chromium.org>
Date: Wed Oct 24 12:53:54 2018

Reland "[CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject"

This reverts commit 0c3cbcc16d0bca1952b75fb5b6cada8285108f37.

Reason for revert: Looks like this was a false positive; the test has failed again after the revert.

Original change's description:
> Revert "[CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject"
> 
> This reverts commit af460e9a5c4ac34692ffa109e87f744ce082b5c0.
> 
> Reason for revert:
> Seems to have broken paint/invalidation/table/cached-69296.html from webkit_layout_tests on Mac 10.11 - currently failed 7/7 times after this landed:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests
> First failing build:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/30030
> 
> Original change's description:
> > [CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject
> > 
> > For fixing SlimmingPaintV2 scrolling background painting and
> > invalidation, we need a single place to get the accurate value
> > of the background paint location.
> > 
> > Bug:  732611 
> > 
> > Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1297586
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Robert Flack <flackr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602250}
> 
> TBR=flackr@chromium.org,wangxianzhu@chromium.org
> 
> Change-Id: I279520fc9deafd9891dd3a5457e42d6fa0b201aa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  732611 
> Reviewed-on: https://chromium-review.googlesource.com/c/1297362
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602289}

TBR=flackr@chromium.org,wangxianzhu@chromium.org,treib@chromium.org

Change-Id: Ic728b318732d88d37686c938f32ed3a27ee95588
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  732611 
Reviewed-on: https://chromium-review.googlesource.com/c/1297142
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602314}
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/layout/layout_box_model_object.cc
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/layout/layout_box_model_object.h
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/paint/paint_layer.h
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/4cffdfb48a70ae7de9aa9174b6cc013f37aa65dd/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ceb353a7cea46198a109af7737f6a6c1b4fee73

commit 0ceb353a7cea46198a109af7737f6a6c1b4fee73
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Oct 24 21:32:31 2018

Use a special display item client for scrolling background

Scrolling background is the background painted on the scrolling contents
layer. Previously we used the scrolling contents graphics layer as the
display item client to give the background proper visual rect, but that
didn't work for SPv2 which doesn't have the graphics layer.

Now use a special display item client for scrolling background.

This is a prerequisite of fixing SPv2 scrolling background.

Bug:  732611 
Change-Id: I3518e69b5985b7c6124ec3e8f9ec9a66005d5eb6
Reviewed-on: https://chromium-review.googlesource.com/c/1297131
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602462}
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/positioned-document-element-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/background/background-image-paint-invalidation-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/background/composited-background-on-both-layers-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/background/full-viewport-repaint-for-background-attachment-fixed-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/compositing/background-attachment-local-composited-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/compositing/background-attachment-local-equivalent-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/overflow/composited-overflow-with-borderbox-background-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/overflow/composited-overflow-with-local-background-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/requestAnimation-translation-leave-traces-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-background-image-fixed-centered-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-background-image-fixed-generated-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-background-image-fixed-scrolling-contents-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-frameset-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-media-query-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-percent-html-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/position/positioned-document-element-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/position/positioned-document-element-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/overflow-scroll-local-background-text-color-change-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/mac/paint/pagination/pagination-change-clip-crash-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/position/positioned-document-element-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/overflow-scroll-local-background-text-color-change-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/WebKit/LayoutTests/platform/win/paint/pagination/pagination-change-clip-crash-expected.txt
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/block_painter_test.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/box_paint_invalidator.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/box_painter.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter_test.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.h
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/paint_controller_paint_test.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/paint_controller_paint_test.h
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/paint_layer_painter_test.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/table_painter_test.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/view_painter.cc
[modify] https://crrev.com/0ceb353a7cea46198a109af7737f6a6c1b4fee73/third_party/blink/renderer/core/paint/view_painter_test.cc

Cc: pdr@chromium.org
 Issue 792577  has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d9f2911878bfc19e5b1c5d258c9266a21e5009

commit c1d9f2911878bfc19e5b1c5d258c9266a21e5009
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Nov 01 15:48:18 2018

[SPv2] Fix paint and invalidation of scrolling background

In SPv1, background painting on the main graphics layer and on
the scrolling contents layer are initiated by CompositedLayerMapping
separately, so BlockPainter::Paint() just check the context to paint
the background once on either the main graphics layer or the scrolling
contents layer.

In SPv2, for background painting BlockPainter::Paint() is called only
once for each object in the background paint, so it needs to deal with
the background on the main graphics layer and on the scrolling contents
layer at the same time.

Bug:  732611 
Change-Id: I22300b82a585c3b96624524c37ed4bf6abafd9c8
Reviewed-on: https://chromium-review.googlesource.com/c/1303358
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604593}
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/background-color/view-blending-base-background-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/clip-child-by-non-stacking-ancestor-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/contents-opaque/background-clip-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/contents-opaque/layer-transform-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/contents-opaque/visibility-hidden-expected.txt
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/fixed-body-background-positioned-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/force-compositing-mode/force-composite-empty-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/geometry/ancestor-overflow-change-expected.txt
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/geometry/fixed-in-composited-expected.png
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/iframes/invisible-nested-iframe-hide-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/iframes/visibility-hidden-transformed-content-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/fixed-position-nonscrollable-body-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/fixed-position-nonscrollable-body-overlap-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/impl-thread-scrolling-non-composited-fixed-no-scroll-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/remove-clipping-layer-with-no-children-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/translatez-added-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/translatez-overlap-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-creation/translatez-removed-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/layer-tree-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/overflow-auto-with-touch-no-overflow-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/overflow-hidden-with-touch-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/overflow-overlay-with-touch-no-overflow-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/overflow-scroll-with-touch-no-overflow-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/rtl/rtl-absolute-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/rtl/rtl-fixed-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/rtl/rtl-relative-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/squashing/dont-squash-into-iframes-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/squashing/iframes-are-never-squashed-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/will-change/composited-layers-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/will-change/will-change-contents-suppresses-compositing-expected.txt
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/backgrounds/background-svg-scaling-zoom-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/backgrounds/transformed-body-background-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/backgrounds/transformed-body-html-background-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/backgrounds/transformed-html-body-background-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/body-propagation/overflow/001-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/body-propagation/overflow/001-xhtml-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/body-propagation/overflow/005-declarative-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/body-propagation/overflow/005-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/body-propagation/overflow/005-xhtml-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-inner-bleed-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/frames/frame-set-scaling-rotate-expected.png
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/frames/frame-set-scaling-skew-expected.png
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/multicol/composited-layer-expected.txt
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/overflow/overflow_hidden-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/replaced/border-radius-clip-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/table/backgr_border-table-quirks-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-1-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-10-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-2-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-3-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-4-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-5-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-6-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-7-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-8-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-add-summary-9-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-remove-summary-1-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-remove-summary-2-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-remove-summary-3-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-remove-summary-4-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-remove-summary-5-and-click-expected.png
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/html/details_summary/details-remove-summary-6-and-click-expected.png
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/4776765-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-currentColor-repaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-generated-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-misaligned-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-resize-height-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-shorthand-with-gradient-and-height-changes-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/background-size-auto-with-gradient-and-height-changes-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/backgroundSizeRepaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/change-text-content-and-background-color-expected.txt
[add] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/composited-background-on-both-layers-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/multiple-backgrounds-style-change-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/viewport-gradient-background-html-resize-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/block-layout-inline-children-replaced-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/block-no-inflow-children-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/block-shift-repaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-current-color-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-image-outset-add-repaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-image-outset-change-repaint-expected.txt
[delete] https://crrev.com/b130e0856063d3b647481be55f9f22a81031a045/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-radius-repaint-2-expected.png
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-radius-repaint-2-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-radius-repaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-radius-without-border-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/border-repaint-glitch-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-inline-resize-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-shadow-add-repaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-shadow-change-repaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-shadow-dynamic-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-shadow-inset-repaint-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-sizing-border-keeping-size-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-sizing-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/box-sizing-padding-keeping-size-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/hover-pseudo-borders-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/hover-pseudo-borders-whitespace-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/invalidate-box-shadow-currentColor-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/margin-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/negative-shadow-box-expand-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/negative-shadow-box-shrink-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/padding-border-keeping-border-box-and-content-box-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/padding-keeping-content-size-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/padding-keeping-visual-size-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/resize-with-border-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/shadow-box-resize-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/shadow-box-resize-writing-mode-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/bugzilla-3509-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/bugzilla-5699-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/bugzilla-6278-expected.txt
[modify] https://crrev.com/c1d9f2911878bfc19e5b1c5d258c9266a21e5009/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/bugzilla-6473-expected.txt
[modify] https://crrev.com/c
Status: Fixed (was: Started)

Sign in to add a comment