Chrome Home crash from using bookmarks too early |
||||
Issue description
On old devices like the galaxy s4, it is possible to get the following crash from tapping on the bottom toolbar and immediately hitting the bookmarks tab:
java.lang.IllegalStateException: Browser hasn't finished initialization yet!
at org.chromium.chrome.browser.profiles.Profile.getLastUsedProfile(Profile.java:7)
at org.chromium.chrome.browser.bookmarks.BookmarkModel.<init>(BookmarkModel.java:1)
at org.chromium.chrome.browser.bookmarks.BookmarkManager.<init>(BookmarkManager.java:9)
at org.chromium.chrome.browser.bookmarks.BookmarkSheetContent.<init>(BookmarkSheetContent.java:2)
at org.chromium.chrome.browser.widget.bottomsheet.BottomSheetContentController.showBottomSheetContent(BottomSheetContentController.java:48)
at org.chromium.chrome.browser.widget.bottomsheet.BottomSheetContentController.onNavigationItemSelected(BottomSheetContentController.java:28)
at android.support.design.widget.m.w(BottomNavigationView.java:6)
at android.support.v7.view.menu.u.o(MenuBuilder.java:218)
...
,
Jun 13 2017
* s/UI/browser
,
Jun 13 2017
I think that's reasonable. We would just 'black hole' all touch events to the toolbar while the browser isn't initialized. We already have this functionality, we just need a signal to enable it.
,
Jun 15 2017
We can hook into the same methods that Profile uses to throw the IllegalStateException: BrowserStartupController#isStartupSuccessfullyCompleted and BrowserStartupController#addStartupCompletedObserver().
,
Jun 20 2017
,
Jun 23 2017
I'm going to roll this into issue 736017 since I have a patch in-flight linked to that bug number. |
||||
►
Sign in to add a comment |
||||
Comment 1 by twelling...@chromium.org
, Jun 13 2017