Consider using in-declaration initialization for BrowserView member variables |
||
Issue descriptionThe initialization of BrowserView member variables is done in its constructor per the current implementation. We should consider using the in-declaration initialization for BrowserView where possible to make the code cleaner.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7ca2fe2926386d3a996a1e84d1a52e79c22996a commit a7ca2fe2926386d3a996a1e84d1a52e79c22996a Author: chengx <chengx@chromium.org> Date: Tue Jun 13 01:56:45 2017 In-declaration initialization for BrowserView member variables This CL converts all member variable of the BrowserView class to use the in-declaration initialization where possible. The initialization was done in the BrowserView constructor. BUG= 732596 Review-Url: https://codereview.chromium.org/2939583002 Cr-Commit-Position: refs/heads/master@{#478862} [modify] https://crrev.com/a7ca2fe2926386d3a996a1e84d1a52e79c22996a/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/a7ca2fe2926386d3a996a1e84d1a52e79c22996a/chrome/browser/ui/views/frame/browser_view.h
,
Jun 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chengx@chromium.org
, Jun 13 2017