ChildProcessServiceImpl lock refactor |
||
Issue descriptionChildProcessServiceImpl.java uses one lock to synchronize various unrelated variables and synchronize when not needed in some cases. It should be cleaned-up.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8874ee752dc6a9e8250640952bfb3a8055c2764 commit a8874ee752dc6a9e8250640952bfb3a8055c2764 Author: Jay Civelli <jcivelli@google.com> Date: Tue Jun 13 19:45:27 2017 ChildProcessServiceImpl: using a specific lock for library init var. Using a specific lock for the library initialized member variable in ChildProcessServiceImpl instead of using the main thread member. Bug: 732591 Change-Id: I2973f250aaa1d03eebea75810a06ef4f6925537a Reviewed-on: https://chromium-review.googlesource.com/532313 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#479104} [modify] https://crrev.com/a8874ee752dc6a9e8250640952bfb3a8055c2764/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79acd3169c325a4fb28f848c2a0cdd94eae62947 commit 79acd3169c325a4fb28f848c2a0cdd94eae62947 Author: Jay Civelli <jcivelli@google.com> Date: Tue Jun 13 21:10:00 2017 ChildProcessServiceImpl: removing unnecessary synchronizations. The Android framework only calls onBind() once for a bound service. As a result we can remove synchronizations for member variables that are set in the bind() method and then accessed for the returned binder (since we are guaranteed these variables cannot be used before they are set). Bug: 732591 Change-Id: Ib04955e3f45721c3a01e82332d99f1950c14b5ae Reviewed-on: https://chromium-review.googlesource.com/532234 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#479150} [modify] https://crrev.com/79acd3169c325a4fb28f848c2a0cdd94eae62947/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bb515d00576c78a0b74b6154f665f1ed509fee5 commit 0bb515d00576c78a0b74b6154f665f1ed509fee5 Author: Jay Civelli <jcivelli@google.com> Date: Tue Jun 13 23:43:23 2017 ChildProcessServiceImpl: minor clean-up. Renaming getServiceInfo to processConnectionBundle and using a local var to simplify code. Bug: 732591 Change-Id: I89f2e767832f1f0c34327c45abe20de550216310 Reviewed-on: https://chromium-review.googlesource.com/532255 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#479207} [modify] https://crrev.com/0bb515d00576c78a0b74b6154f665f1ed509fee5/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
,
Jul 7 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2017