New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732581 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672303



Sign in to add a comment

Optimize the InProcessCommandBuffer used by the viz display compositor

Project Member Reported by fsam...@chromium.org, Jun 12 2017

Issue description

We currently encode and decode a series of GL ops in the viz display compositor. It will likely be more efficient if the InProcessCommandBuffer had a "DrawCompositorFrame" op that took a pointer to a CompositorFrame and drew the CompositorFrame directly.
 
Blocking: 732572

Comment 2 by danakj@chromium.org, Jun 12 2017

Cc: ccameron@chromium.org
This allows the DisplayCompositor in the GPU to still end up inside the command buffer's implementation so it can do things like sync tokens and mailboxes. But the implementation of GLRenderer would need to be inside the command buffer and do those things directly instead of thru command buffer APIs.

If we want to share code still, then DirectRenderer would need to exist for software, so instead of DrawCompositorFrame, maybe DrawRenderPass would be more appropriate. Possibly DrawDrawQuad.. but hopefully not as that's more commands! 

Note, overlays would be implemented entirely inside the command buffer too. As would platform-specific mac wonders.

Comment 3 by danakj@chromium.org, Jun 12 2017

Cc: jbau...@chromium.org

Comment 4 by piman@chromium.org, Jun 12 2017

Is that really blocking?
It may very well be worth doing, but not exactly trivial to do.
Not sure yet, I'm leaving it as blocking shipping for now, but we won't know until we collect more data.

Comment 6 by danakj@chromium.org, Jun 12 2017

Blocking: -732572 732568
This should go under performance-specific stuff. I'll move.

Comment 7 by danakj@chromium.org, Jun 12 2017

Blocking: -732568 672303
Components: -Internals>MUS
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 14 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: kylec...@chromium.org
Status: Assigned (was: Untriaged)
kylechar@ is actively discussing issues with the InProcessCommandBuffer. Please update.

Comment 11 by kylec...@chromium.org, Jan 17 (6 days ago)

Status: WontFix (was: Assigned)
I think the plan of record is getting SkiaRenderer working and no longer using InProcessCommandBuffer.

Sign in to add a comment