Deprecate Chrome LKGM Builder |
|||||||||
Issue descriptionProposal doc with discussion is here: https://docs.google.com/document/d/1alpPykXmttMnbhhbbzPwQeDmN5BwDhMvR5XA1F73Pus/edit TL;DR - The Chrome LKGM Builder has been difficult to maintain and the script it runs, chromite/scripts/cros_best_revision.py, is fairly complicated and unmaintained. This is a tracking issue for changes towards replacing the Chrome LKKGM Builder with a simpler mechanism for updating the cros version used by Simple Chrome.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d52a634de105f298f11c2e696672c2d7b14e5eb5 commit d52a634de105f298f11c2e696672c2d7b14e5eb5 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Jun 13 22:12:40 2017 cros_chrome_sdk: Elim support for GS LATEST- files cros_chrome_sdk.py only calls GetDefaultVersion() when --sdk-path and --version are empty. The canary and PFQ builders use an explicit --sdk-path when running Simple Chrome so should not be affected by this. The simple chrome builders (chrome-tot-chromeos-amd64-generic and 'ChromiumOS amd64-generic Compile') build from a chrome checkout so should get the version from CHROMEOS_LKGM. The LATEST- file support is for a use case that is no longer supported. BUG= chromium:732579 TEST=./cli/cros/cros_chrome_sdk_unittest Change-Id: I323b33585e9a45801876786acf95281dd70feb3e Reviewed-on: https://chromium-review.googlesource.com/531858 Commit-Ready: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ryan Cui <rcui@google.com> [modify] https://crrev.com/d52a634de105f298f11c2e696672c2d7b14e5eb5/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/d52a634de105f298f11c2e696672c2d7b14e5eb5/cli/cros/cros_chrome_sdk_unittest.py
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/01e89de419d82048d896a92ac863a15ea31cc276 commit 01e89de419d82048d896a92ac863a15ea31cc276 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Jun 14 21:38:11 2017 Revert "cros_chrome_sdk: Elim support for GS LATEST- files" This reverts commit d52a634de105f298f11c2e696672c2d7b14e5eb5. Reason for revert: This will break developer simple chrome because we rely on the contests of gs://chromeos-image-archive/{board}/LATEST-xxxx.0.0 to get the 'full' version which looks like R61-xxxx.0.0. NOTE: The Chrome LKGM builder is copying LATEST-* files with every run, even when it is failing to commit to CHROMEOS_LKGM. This means that boards may be using a different version than the "SDK" version which is... confusing to say the least. Original change's description: > cros_chrome_sdk: Elim support for GS LATEST- files > > cros_chrome_sdk.py only calls GetDefaultVersion() when > --sdk-path and --version are empty. > > The canary and PFQ builders use an explicit --sdk-path when > running Simple Chrome so should not be affected by this. > > The simple chrome builders (chrome-tot-chromeos-amd64-generic > and 'ChromiumOS amd64-generic Compile') build from a chrome > checkout so should get the version from CHROMEOS_LKGM. > > The LATEST- file support is for a use case that is no longer > supported. > > BUG= chromium:732579 > TEST=./cli/cros/cros_chrome_sdk_unittest > > Change-Id: I323b33585e9a45801876786acf95281dd70feb3e > Reviewed-on: https://chromium-review.googlesource.com/531858 > Commit-Ready: Steven Bennetts <stevenjb@chromium.org> > Tested-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Aviv Keshet <akeshet@chromium.org> > Reviewed-by: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Ryan Cui <rcui@google.com> Bug: chromium:732579 Change-Id: I6a1eb0d2a8627b68d18d716f7818daf96a50a865 Reviewed-on: https://chromium-review.googlesource.com/535034 Commit-Ready: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/01e89de419d82048d896a92ac863a15ea31cc276/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/01e89de419d82048d896a92ac863a15ea31cc276/cli/cros/cros_chrome_sdk_unittest.py
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/347fd27c0f50fa226040c4ad03d6aff0e49f2eb8 commit 347fd27c0f50fa226040c4ad03d6aff0e49f2eb8 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Jul 12 20:19:55 2017 cros_chrome_sdk: Look for recent LATEST- file Instead of relying on having the Chrome LKGM builder copy LATEST-files for every CHROMEOS_LKGM uprev, have cros_chrome_sdk look for a recent LATEST-file to use and inform the developer if a LATEST-file matching the version in CHROMEOS_LKGM does not exist. Proposal document: https://docs.google.com/document/d/1alpPykXmttMnbhhbbzPwQeDmN5BwDhMvR5XA1F73Pus BUG= chromium:732579 TEST=./cli/cros/cros_chrome_sdk_unittest Also, 'cros chrome-sdk --version' with a version greater than the latest should find the latest version Change-Id: Ieb2db9e2ea7a3018b26a071e1afb621b9b1212c1 Reviewed-on: https://chromium-review.googlesource.com/535847 Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/347fd27c0f50fa226040c4ad03d6aff0e49f2eb8/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/347fd27c0f50fa226040c4ad03d6aff0e49f2eb8/cli/cros/cros_chrome_sdk_unittest.py
,
Jul 28 2017
Issue 749907 has been merged into this issue.
,
Jul 31 2017
In order to ensure that updating CHROMEOS_LKGM does not break the chromium waterfall, we are going to need to ensure that the Simple Chrome stage runs and succeeds on amd64-generic and daisy-generic.
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ddf9bcd2969fbcc61f671659e71700264618cf55 commit ddf9bcd2969fbcc61f671659e71700264618cf55 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Aug 24 23:43:11 2017 PublishUprevChangesStage: update CHROMEOS_LKGM BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated during PublishUprevChangesStage Change-Id: Id4408ebb068e9bd979fbec9c201fcb80b1ec4639 Reviewed-on: https://chromium-review.googlesource.com/535914 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> [add] https://crrev.com/ddf9bcd2969fbcc61f671659e71700264618cf55/bin/chrome_chromeos_lkgm [add] https://crrev.com/ddf9bcd2969fbcc61f671659e71700264618cf55/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/ddf9bcd2969fbcc61f671659e71700264618cf55/cbuildbot/stages/completion_stages.py [add] https://crrev.com/ddf9bcd2969fbcc61f671659e71700264618cf55/scripts/chrome_chromeos_lkgm_unittest [modify] https://crrev.com/ddf9bcd2969fbcc61f671659e71700264618cf55/cbuildbot/builders/simple_builders.py [add] https://crrev.com/ddf9bcd2969fbcc61f671659e71700264618cf55/scripts/chrome_chromeos_lkgm_unittest.py
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/79b02ccb464acccf94e9ff75c2681d6a8d195207 commit 79b02ccb464acccf94e9ff75c2681d6a8d195207 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Aug 25 17:13:12 2017 UpdateChromeosLKGMStage: Pass correct flag BUG= chromium:732579 TEST=UpdateChromeosLKGM stage in master-chromium-pfq succeeds For minor fix to previous CL: TBR=dgarret@chromium.org Change-Id: Ibb0cb97166c14bef1fa3087f15191979f91f2eb9 Reviewed-on: https://chromium-review.googlesource.com/636030 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/79b02ccb464acccf94e9ff75c2681d6a8d195207/cbuildbot/stages/completion_stages.py
,
Aug 28 2017
Once this is completed we need to remember to turn down cros-beefy429-c2.
,
Aug 28 2017
Issue 618430 has been merged into this issue.
,
Aug 28 2017
Issue 239219 has been merged into this issue.
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4bc322a80737e8f7a2c5e51472c952e799d39459 commit 4bc322a80737e8f7a2c5e51472c952e799d39459 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Aug 28 22:37:41 2017 cros_chromeos_lkgm: Strip chrome branch BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated to a .0.0 varsion in the UpdateChromeosLKGM stage Change-Id: Ia225300967a50c062507c098ef47b2ee0141569d Reviewed-on: https://chromium-review.googlesource.com/638557 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/4bc322a80737e8f7a2c5e51472c952e799d39459/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/4bc322a80737e8f7a2c5e51472c952e799d39459/scripts/chrome_chromeos_lkgm_unittest.py
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6d44f5f350c0b6fec02c74a1bfa1be2e4ecdc10a commit 6d44f5f350c0b6fec02c74a1bfa1be2e4ecdc10a Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Aug 29 19:02:16 2017 UpdateChromeosLKGMStage: Remove --dryrun BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq Change-Id: Ieeda4846c4ccbae25fdfa0455ba9fbec4759a91d Reviewed-on: https://chromium-review.googlesource.com/641572 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/6d44f5f350c0b6fec02c74a1bfa1be2e4ecdc10a/cbuildbot/stages/completion_stages.py
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3f5e7fc082093e45fa66ac4514aa334d50ae8bce commit 3f5e7fc082093e45fa66ac4514aa334d50ae8bce Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 30 16:08:05 2017 chrome_chromeos_lkgm: elim unsupported -m from commit BUG= chromium:732579 TEST=chrome_chromeos_lkgm_unittest, chrome pfq master succeeds Change-Id: Ibcfdfa597473c34875442a9624530d5aa79e0116 Reviewed-on: https://chromium-review.googlesource.com/643769 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/3f5e7fc082093e45fa66ac4514aa334d50ae8bce/scripts/chrome_chromeos_lkgm.py
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6614b77bc5cdbd05dc87cc28d23eaec2ffd23752 commit 6614b77bc5cdbd05dc87cc28d23eaec2ffd23752 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Aug 31 00:02:49 2017 Revert "UpdateChromeosLKGMStage: Remove --dryrun" This reverts commit 6d44f5f350c0b6fec02c74a1bfa1be2e4ecdc10a. Reason for revert: Need to fix git upload logic first Original change's description: > UpdateChromeosLKGMStage: Remove --dryrun > > BUG= chromium:732579 > TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq > > Change-Id: Ieeda4846c4ccbae25fdfa0455ba9fbec4759a91d > Reviewed-on: https://chromium-review.googlesource.com/641572 > Tested-by: Steven Bennetts <stevenjb@chromium.org> > Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Bug: chromium:732579 Change-Id: If2fb4e6286a05976bf41d4a82660bc327141f812 Reviewed-on: https://chromium-review.googlesource.com/644155 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/6614b77bc5cdbd05dc87cc28d23eaec2ffd23752/cbuildbot/stages/completion_stages.py
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f542336f1ad33cbf13fe2fdecd90a7908d9e46e1 commit f542336f1ad33cbf13fe2fdecd90a7908d9e46e1 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Aug 31 19:23:19 2017 cros_chromeos_lkgm: Add UploadNewLKGM stage BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq Change-Id: Id443c391b98dd34ccb410c3501c39bc28edf0f56 Reviewed-on: https://chromium-review.googlesource.com/644413 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/f542336f1ad33cbf13fe2fdecd90a7908d9e46e1/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/f542336f1ad33cbf13fe2fdecd90a7908d9e46e1/cbuildbot/stages/completion_stages.py
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c5fd94e8fad280dfc0aaac5d7bcbccf7bf5a9703 commit c5fd94e8fad280dfc0aaac5d7bcbccf7bf5a9703 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Sep 01 15:02:05 2017 Revert "cros_chromeos_lkgm: Add UploadNewLKGM stage" This reverts commit f542336f1ad33cbf13fe2fdecd90a7908d9e46e1. Reason for revert: Unhandled exception in UpdateChromeosLKGM Original change's description: > cros_chromeos_lkgm: Add UploadNewLKGM stage > > BUG= chromium:732579 > TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq > > Change-Id: Id443c391b98dd34ccb410c3501c39bc28edf0f56 > Reviewed-on: https://chromium-review.googlesource.com/644413 > Tested-by: Steven Bennetts <stevenjb@chromium.org> > Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Bug: chromium:732579 Change-Id: I31094662040712708c5e95f6a6f9cab6b192aa86 Reviewed-on: https://chromium-review.googlesource.com/647793 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/c5fd94e8fad280dfc0aaac5d7bcbccf7bf5a9703/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/c5fd94e8fad280dfc0aaac5d7bcbccf7bf5a9703/cbuildbot/stages/completion_stages.py
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/345ff6cd252466c4f72f3c72f2b4b8c3060ad939 commit 345ff6cd252466c4f72f3c72f2b4b8c3060ad939 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Sep 01 18:49:18 2017 cros_chromeos_lkgm: Add UploadNewLKGM stage (with -v) This is expected to fail again, hopefully with more info. BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq Change-Id: I6cab516ded3a85903e0aebccb52b00c8440a14ba Reviewed-on: https://chromium-review.googlesource.com/647798 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/345ff6cd252466c4f72f3c72f2b4b8c3060ad939/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/345ff6cd252466c4f72f3c72f2b4b8c3060ad939/cbuildbot/stages/completion_stages.py
,
Sep 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/81334814cbf6141c9c47b675042d085b643dd659 commit 81334814cbf6141c9c47b675042d085b643dd659 Author: Steven Bennetts <stevenjb@chromium.org> Date: Sat Sep 02 15:55:05 2017 Revert "cros_chromeos_lkgm: Add UploadNewLKGM stage (with -v)" This reverts commit 345ff6cd252466c4f72f3c72f2b4b8c3060ad939. Reason for revert: Revert until committer email address is worked out. Original change's description: > cros_chromeos_lkgm: Add UploadNewLKGM stage (with -v) > > This is expected to fail again, hopefully with more info. > > BUG= chromium:732579 > TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq > > Change-Id: I6cab516ded3a85903e0aebccb52b00c8440a14ba > Reviewed-on: https://chromium-review.googlesource.com/647798 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Tested-by: Steven Bennetts <stevenjb@chromium.org> > Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Bug: chromium:732579 Change-Id: I1db354da175942c54cb950eb720511fd19e36393 Reviewed-on: https://chromium-review.googlesource.com/648572 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/81334814cbf6141c9c47b675042d085b643dd659/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/81334814cbf6141c9c47b675042d085b643dd659/cbuildbot/stages/completion_stages.py
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a03df19ec00b366b4aee6d86ca1a51926707fc41 commit a03df19ec00b366b4aee6d86ca1a51926707fc41 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Sep 05 23:39:41 2017 cros_chromeos_lkgm: Add UploadNewLKGM stage (take 3) This adds '-c chromeos-commit-bot@chromium.org' to git when running 'commit'. BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq Change-Id: I1c7269b613345ac3bf91992ed54615f72a228b24 Reviewed-on: https://chromium-review.googlesource.com/651765 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/a03df19ec00b366b4aee6d86ca1a51926707fc41/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/a03df19ec00b366b4aee6d86ca1a51926707fc41/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/a03df19ec00b366b4aee6d86ca1a51926707fc41/scripts/chrome_chromeos_lkgm_unittest.py
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f80752a0e3e287bd1bf122974c2629284f9a5664 commit f80752a0e3e287bd1bf122974c2629284f9a5664 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Sep 06 13:53:12 2017 Revert "cros_chromeos_lkgm: Add UploadNewLKGM stage (take 3)" This reverts commit a03df19ec00b366b4aee6d86ca1a51926707fc41. Reason for revert: Commit failure on master-chromium-pfq Original change's description: > cros_chromeos_lkgm: Add UploadNewLKGM stage (take 3) > > This adds '-c chromeos-commit-bot@chromium.org' to git when > running 'commit'. > > BUG= chromium:732579 > TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq > > Change-Id: I1c7269b613345ac3bf91992ed54615f72a228b24 > Reviewed-on: https://chromium-review.googlesource.com/651765 > Tested-by: Steven Bennetts <stevenjb@chromium.org> > Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Bug: chromium:732579 Change-Id: Ifdf9cea1f76a7d462c87efe9d08b31d00a8f6efb Reviewed-on: https://chromium-review.googlesource.com/652671 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/f80752a0e3e287bd1bf122974c2629284f9a5664/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/f80752a0e3e287bd1bf122974c2629284f9a5664/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/f80752a0e3e287bd1bf122974c2629284f9a5664/scripts/chrome_chromeos_lkgm_unittest.py
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/415d062fee9326eaa023900b661dd3387a5bbf8a commit 415d062fee9326eaa023900b661dd3387a5bbf8a Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Sep 06 17:36:04 2017 cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) This adds '-c chromeos-commit-bot@chromium.org' to git when running 'commit' and creates a fresh (shallow) chrome checkout each run. BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq Change-Id: Id71be19e4a372184017c766c2bfa4bcafdd0f72d Reviewed-on: https://chromium-review.googlesource.com/652846 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/415d062fee9326eaa023900b661dd3387a5bbf8a/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/415d062fee9326eaa023900b661dd3387a5bbf8a/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/415d062fee9326eaa023900b661dd3387a5bbf8a/scripts/chrome_chromeos_lkgm_unittest.py
,
Sep 6 2017
,
Sep 6 2017
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6a6d692b20cba6f3d4bc280ab677992b56ba3797 commit 6a6d692b20cba6f3d4bc280ab677992b56ba3797 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Sep 08 14:34:53 2017 Revert "cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4)" This reverts commit 415d062fee9326eaa023900b661dd3387a5bbf8a. Reason for revert: Sigh. Still not working. Original change's description: > cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) > > This adds '-c chromeos-commit-bot@chromium.org' to git when > running 'commit' and creates a fresh (shallow) chrome > checkout each run. > > BUG= chromium:732579 > TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq > > Change-Id: Id71be19e4a372184017c766c2bfa4bcafdd0f72d > Reviewed-on: https://chromium-review.googlesource.com/652846 > Tested-by: Steven Bennetts <stevenjb@chromium.org> > Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Bug: chromium:732579 Change-Id: Ia703b4d674f205207d37b178a4f09fceaa178b33 Reviewed-on: https://chromium-review.googlesource.com/657877 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/6a6d692b20cba6f3d4bc280ab677992b56ba3797/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/6a6d692b20cba6f3d4bc280ab677992b56ba3797/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/6a6d692b20cba6f3d4bc280ab677992b56ba3797/scripts/chrome_chromeos_lkgm_unittest.py
,
Sep 8 2017
Sigh. Still failing: https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/4837/steps/UpdateChromeosLKGM/logs/stdio Snippet: 05:22:38: INFO: Committing LKGM version: 9921.0.0 (was 9916.0.0), 05:22:39: INFO: Uploading LKGM commit. 05:22:39: INFO: RunCommand: git cl upload -v -m 'Automated Commit: Committing new LKGM version 9921.0.0 for chromeos.' --bypass-hooks -f --send-mail '--tbrs=chrome-os-gardeners@google.com' in /b/c/cbuild/repository/chrome_src Using 50% similarity for rename/copy detection. Override with --similarity. chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Adding self-LGTM (Code-Review +1) because of TBRs remote: remote: Processing changes: refs: 1 remote: Processing changes: refs: 1, done remote: remote: ERROR: In commit 8526354a226f8c36f271e3000e8403426067e505 remote: ERROR: committer email address chrome-bot@chromium.org remote: ERROR: does not match your user account and you have no 'forge committer' permission. remote: ERROR: remote: ERROR: The following addresses are currently registered: remote: ERROR: chromeos-commit-bot@chromium.org remote: ERROR: remote: ERROR: To register an email address, please visit: remote: ERROR: https://chromium-review.googlesource.com/#/settings/contact remote: remote: To https://chromium.googlesource.com/a/chromium/src.git ! [remote rejected] 8526354a226f8c36f271e3000e8403426067e505 -> refs/for/refs/heads/master%l=Code-Review+1,m=Initial_upload,notify=NONE (invalid committer) error: failed to push some refs to 'https://chromium.googlesource.com/a/chromium/src.git' Error after CL description prompt -- saving description to /home/chrome-bot/.git_cl_description_backup 05:22:55: INFO: RunCommand: git log '--pretty=full' in /b/c/cbuild/repository/chrome_src commit b698316f7a7239f5884b20e8da35fdad56df334e Author: chromeos-commit-bot@chromium.org <chromeos-commit-bot@chromium.org> Commit: chromeos-commit-bot@chromium.org <chromeos-commit-bot@chromium.org> Automated Commit: Committing new LKGM version 9921.0.0 for chromeos.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ac301f459348de7bfc7906394c1235b61728588c commit ac301f459348de7bfc7906394c1235b61728588c Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Nov 08 18:08:25 2017 cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) This adds '-c chromeos-commit-bot@chromium.org' to git when running 'commit'. On failure it should log a warning but the PFQ master should still succeed. (This is temproary while we attempt to debug the problems uploading the chrome change). BUG= chromium:732579 TEST=CHROMEOS_LKGM is updated and committed in master-chromium-pfq Change-Id: I0a8449f090cd5c3aa0a5c75157f02308de2c9555 Reviewed-on: https://chromium-review.googlesource.com/757474 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/ac301f459348de7bfc7906394c1235b61728588c/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/ac301f459348de7bfc7906394c1235b61728588c/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/ac301f459348de7bfc7906394c1235b61728588c/scripts/chrome_chromeos_lkgm_unittest.py
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d36fc78274771cc2c4620076192d8dbffc93f508 commit d36fc78274771cc2c4620076192d8dbffc93f508 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Nov 09 01:22:03 2017 chrome_chromeos_lkgm: Remove any existing chrome checkout This iteration removes the chrome_src checkout and always runs 'git clone'. This will add < 10 minutes to the total run time and ensure that previous incorrect implementations are not affecting the script. It also outputs a warning instead of failing for any LKGMNotCommitted exception. BUG= chromium:732579 TEST=chrome_chromeos_lkgm_unittest Change-Id: I2e799a820207ea04f5c25bd00d2c8805e6502f26 Reviewed-on: https://chromium-review.googlesource.com/759151 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/d36fc78274771cc2c4620076192d8dbffc93f508/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/d36fc78274771cc2c4620076192d8dbffc93f508/scripts/chrome_chromeos_lkgm_unittest.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/18d8bc5675869f8a394d85f2c39f54f577e09484 commit 18d8bc5675869f8a394d85f2c39f54f577e09484 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Nov 10 00:55:22 2017 chrome_chromeos_lkgm: Add --email to 'git cl upload' BUG= chromium:732579 TEST=chrome_chromeos_lkgm_unittest Change-Id: I747ac4ddf53486f2e90614e11e975f6b795b6882 Reviewed-on: https://chromium-review.googlesource.com/761118 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/18d8bc5675869f8a394d85f2c39f54f577e09484/scripts/chrome_chromeos_lkgm.py
,
Nov 10 2017
Passing --email to 'git cl upload' does not help. I think we need an expert on 'git cl' to get involved at this point. 23:27:21: INFO: RunCommand: git cl upload -v -m 'Automated Commit: Committing new LKGM version 10114.0.0 for chromeos.' --bypass-hooks -f '--email=chromeos-commit-bot@chromium.org' --send-mail '--tbrs=chrome-os-gardeners@google.com' in /b/c/cbuild/repository/chrome_src chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) remote: remote: Processing changes: refs: 1 remote: Processing changes: refs: 1, done remote: remote: ERROR: In commit ac565fffe7c96b4a9539116f56318756698a4a2a remote: ERROR: committer email address chrome-bot@chromium.org remote: ERROR: does not match your user account and you have no 'forge committer' permission.
,
Nov 10 2017
Sounds like we need to give either chromeos-commit-bot or chrome-for the forge committer permissions. I can probably do that once I'm sure which account and repo needs to be updated. Which one is the original author of the CL, and which one is amending it? Is it necessary for it to be authored and then amended/uplaoded by a different account?
,
Nov 10 2017
I'm not sure I understand any of those questions :) Here is the link to the most recent failed builder: https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/5167 And the output from the UpdateChromeosLKGM stage: https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/5167/steps/UpdateChromeosLKGM This is the git command used to commit the change to CHROMEOS_LKGM in a shallow chrome checkout: git -c 'user.email=chromeos-commit-bot@chromium.org' -c 'user.name=chromeos-commit-bot@chromium.org' commit -m 'Automated Commit: Committing new LKGM version 10114.0.0 for chromeos.' And here is the script generating the change: https://cs.corp.google.com/chromeos_public/chromite/scripts/chrome_chromeos_lkgm.py?sq&q=chrome_chromeos_lkgm&l=1
,
Nov 10 2017
ACL change for review: https://chromium-review.googlesource.com/?polygerrit=0#/c/chromium/src/+/764040/
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/39bea0c80ab2f9fe3d3ad43152b730336ca95cfd commit 39bea0c80ab2f9fe3d3ad43152b730336ca95cfd Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Nov 16 21:32:04 2017 chrome_chromeos_lkgm: Use 'git -c user.email cl upload' BUG= chromium:732579 TEST=chrome_chromeos_lkgm_unittest, PFQ UpdateChromeosLKGM succeeds Change-Id: I53ba4f57d7284cc6d9015f7bd46766c412d871ae Reviewed-on: https://chromium-review.googlesource.com/775081 Tested-by: Steven Bennetts <stevenjb@chromium.org> Trybot-Ready: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/39bea0c80ab2f9fe3d3ad43152b730336ca95cfd/scripts/chrome_chromeos_lkgm.py
,
Nov 17 2017
New and exciting failure: 10:44:39: INFO: Uploading LKGM commit. 10:44:39: INFO: RunCommand: git -c 'user.email=chromeos-commit-bot@chromium.org' -c 'user.name=chromeos-commit-bot@chromium.org' cl upload -v -m 'Automated Commit: Committing new LKGM version 10137.0.0 for chromeos.' --bypass-hooks -f --send-mail '--tbrs=chrome-os-gardeners@google.com' in /b/c/cbuild/repository/chrome_src chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) remote: remote: Processing changes: (\) remote: Processing changes: new: 1 (|) ... remote: Processing changes: new: 1, done remote: (W) 4623c7b: commit subject >50 characters; use shorter first paragraph remote: remote: New Changes: remote: https://chromium-review.googlesource.com/#/c/chromium/src/+/775823 Automated Commit: Committing new LKGM version 10137.0.0 for chromeos. remote: To https://chromium.googlesource.com/a/chromium/src.git * [new branch] 4623c7b4c288548ec71133e282cffb077fa719eb -> refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload Adding self-LGTM (Code-Review +1) because of TBRs. Your Gerrit credentials might be misconfigured. Try: git cl creds-check ... [1;33m10:45:02: WARNING: LKGM Commit failed: LKGMNotCommitted('Could not submit LKGM: upload failed: RunCommandError("cmd=[\'git\', \'-c\', \'user.email=chromeos-commit-bot@chromium.org\', \'-c\', \'user.name=chromeos-commit-bot@chromium.org\', \'cl\', \'upload\', \'-v\', \'-m\', \'Automated Commit: Committing new LKGM version 10137.0.0 for chromeos.\', \'--bypass-hooks\', \'-f\', \'--send-mail\', \'--tbrs=chrome-os-gardeners@google.com\'], cwd=/b/c/cbuild/repository/chrome_src", <chromite.lib.cros_build_lib.CommandResult object at 0x7fd3bd5d95d0>, None)',)[0m
,
Nov 21 2017
This is working on the PFQ master, woot! https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/5242 23:21:54: INFO: Landing LKGM commit. 23:22:07: INFO: git cl land succeeded. dpranke@ - I am going to open a separate CL to actually turn down the now completely obsolete Chrome LKGM Builder.
,
Nov 21 2017
,
Jan 22 2018
,
Jan 23 2018
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1b9180f245ca84d8edb7ee17a99425ea731e3a7f commit 1b9180f245ca84d8edb7ee17a99425ea731e3a7f Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Mar 01 07:54:26 2018 [chrome_chromeos_lkgm]: Rename LGTM to LKGM. * Cleanup chrome src checkout on exit. * Improve error message when LKGM is older than current LKGM. BUG= chromium:732579 TEST=chrome_chromeos_lkgm_unittest Change-Id: If1dbcc564273e31809659a7f44d546368cc3107e Reviewed-on: https://chromium-review.googlesource.com/933865 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/1b9180f245ca84d8edb7ee17a99425ea731e3a7f/scripts/chrome_chromeos_lkgm.py [modify] https://crrev.com/1b9180f245ca84d8edb7ee17a99425ea731e3a7f/scripts/chrome_chromeos_lkgm_unittest.py |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by steve...@chromium.org
, Jun 13 2017