Enable VR browser automated tests on KLM devices |
||
Issue descriptionWe don't officially support VR browser on KLM devices, but it works on some KLM devices with flag enabled. It will be nice to enable existing VR browser automated tests on some KLM devices in FYI bot, so we will know if there is any issue.
,
Jun 15 2017
I think we only want to run it on FYI bot, since we don't officially support it, we don't want to block others if it is failed. FYI bot is better for this use case.
,
Jun 16 2017
My Nexus 5X doesn't seem to be able to enter the VR browser. The call to forceEnterVr() isn't doing anything, which seems to stem from this check https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java?q=vrshelldelegate&dr=CSs&l=455. Are we sure that the VR browser works on KLM devices at all?
,
Jun 16 2017
That is what I heard from David in our last sync up meeting, you can confirm with David.
,
Jun 16 2017
I would be surprised if it was. In practice no non-dev user (without root on their phone) will be able to use VR browser without an actual daydream headset (and of course a daydream ready device). The flag required to turn on VR entry from the menu (and do pretty much what the tests would do by calling forceEnterVr) can only be set from the command line (which requires root). I think it would be useful to enable the browser on all platforms (the gaze cursor works fine for me), but until we have a firm commitment to support it on all those platforms it probably doesn't make sense to try and test it when it won't work for any actual user. FWIW I still think a cardboard VR browser test (using daydream ready devices and OS to get past the check mentioned in comment #3, but setting the device to cardboard) would still be worthwhile (as developers probably are using it instead of always going through the daydream don flow and pairing controllers), but that's slightly different from what this issue proposes.
,
Jun 27 2017
I'm going to go ahead and close this as a wontfix since the VR browser is NOT supported on KLM. I think we got this confused with VR browser support for Cardboard on Daydream-ready devices, which is covered in Issue 734757 . |
||
►
Sign in to add a comment |
||
Comment 1 by bsheedy@chromium.org
, Jun 15 2017