Migrate views-based signin screen constants to a separate file |
|||
Issue descriptionAs the views-based signin screen is being developed, all the related constants should be moved to a file similar to ash/shelf/shelf_constants.h
,
Aug 2 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/810c5a28e18e3831911df6fb01efe1cac34e49cf commit 810c5a28e18e3831911df6fb01efe1cac34e49cf Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Aug 10 01:19:01 2017 Move all login screen related constants to a separate file Login/lock screen related constants may be used from at least three places: views-based lock, WebUi based login/lock and wallpaper. So we want to move them together just as shelf_constants.h TBR=wzang@chromium.org (cherry picked from commit eb86464a8cb4944b52be8572fbf7e7e1387381c1) Bug: 732566 , 733409 Change-Id: I791d5dfbd02f35cdcc6064b964b97b6978a376d2 Reviewed-on: https://chromium-review.googlesource.com/590483 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491196} Reviewed-on: https://chromium-review.googlesource.com/609546 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#425} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/ash/BUILD.gn [modify] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/ash/login/ui/lock_screen.cc [add] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/ash/login/ui/login_constants.h [modify] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
,
Aug 10 2017
This CL also points to crbug.com/733409 which gets merge approval. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 2 2017