Automate WebVR test cases for WebView |
|||
Issue descriptionRight now we don't support WebVR for WebView, but we still need manual test case to make sure WebVr site will not crash WebView, it will be great to automate this test case to reduce manual test effort. We may need to run existing WebVR automated tests in WebView if we support WebVR in WebView in future.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e325eee4ea667f7ac01ba53cbd3140eba24245b commit 7e325eee4ea667f7ac01ba53cbd3140eba24245b Author: bsheedy <bsheedy@chromium.org> Date: Tue Jun 13 20:18:25 2017 Add WebView Javatest for WebVR Adds a simple WebView test to make sure that enabling and attempting to use WebVR does not cause any crashes or return any VRDisplays. WebVR is not currently supported in WebView, but we want to make sure that a user who happens to visit a WebVR site in WebView doesn't have issues. Bug: 732557 Change-Id: I53ebf4b0d63a1d731d0cb1628b70140ecc0fd85a Reviewed-on: https://chromium-review.googlesource.com/533733 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#479121} [add] https://crrev.com/7e325eee4ea667f7ac01ba53cbd3140eba24245b/android_webview/javatests/src/org/chromium/android_webview/test/WebViewWebVrTest.java [modify] https://crrev.com/7e325eee4ea667f7ac01ba53cbd3140eba24245b/android_webview/test/BUILD.gn [add] https://crrev.com/7e325eee4ea667f7ac01ba53cbd3140eba24245b/android_webview/test/shell/assets/webvr_not_functional_test.html
,
Jun 13 2017
We now have an automated test that makes sure WebVR doesn't crash WebView and that it doesn't return any VRDisplays. Is this sufficient to close out this issue?
,
Jun 13 2017
Does it run with VrCore installed? It will be nice to cover this scenario as well.
,
Jun 13 2017
Not currently. I'd have to talk to one of the OWNERS, but my guess is that they wouldn't want the extra overhead of installing/setting up VrCore for a single test.
,
Jun 13 2017
Once John updates test runner script to support uninstalling/installing system apps on swarmed device, I think we can run our specific WebVR tests in WebView in swarmed device with VrCore installed on our own internal FYI bot, so we will not bother the offical WebView Tester bot, does it make sense?
,
Jun 13 2017
That's an option - it's a bit of a hack, and it won't catch regressions quickly (internal bot is only set to run every 4 hours), but it'll be better than nothing.
,
Jun 13 2017
Every 4 hours is still better than manual testing, since we run it once a week for manual testing.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ae40f6ddf3b2556bf5df22bb1b381f98d416be7 commit 0ae40f6ddf3b2556bf5df22bb1b381f98d416be7 Author: bsheedy <bsheedy@chromium.org> Date: Thu Jul 20 00:56:29 2017 Run WebVR WebView test on VR FYI bot There is currently a WebView test that makes sure WebVR is not available and that trying to use it does not cause any crashes, etc. However, this is currently only run on bots that are not configured for VR. While there shouldn't be a difference in this case, we want to be sure that running on a VR-configured device yields the same results. Bug: 732557 Change-Id: Ifdb4626b46550254b378849c79d3945135d996e8 Reviewed-on: https://chromium-review.googlesource.com/575727 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#488067} [modify] https://crrev.com/0ae40f6ddf3b2556bf5df22bb1b381f98d416be7/android_webview/test/BUILD.gn [modify] https://crrev.com/0ae40f6ddf3b2556bf5df22bb1b381f98d416be7/device/vr/features/features.gni [modify] https://crrev.com/0ae40f6ddf3b2556bf5df22bb1b381f98d416be7/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/0ae40f6ddf3b2556bf5df22bb1b381f98d416be7/tools/mb/mb_config.pyl
,
Jul 20 2017
,
Jul 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bsheedy@chromium.org
, Jun 12 2017Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)