New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732555 link

Starred by 8 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature


Sign in to add a comment

Get VizDisplayCompositor on Android working

Project Member Reported by danakj@chromium.org, Jun 12 2017

Issue description

This is similar to 730193 which is for desktop. Android platform-specific things here though. General things we'll address over there.
 

Comment 1 by danakj@chromium.org, Jun 12 2017

Blockedon: 732507

Comment 2 by danakj@chromium.org, Jun 12 2017

Blocking: 601863

Comment 3 by danakj@chromium.org, Jun 12 2017

Blockedon: 689754
Blockedon: 633281
Blockedon: 713696
Cc: danakj@chromium.org rjkroege@chromium.org aelias@chromium.org sadrul@chromium.org boliu@chromium.org

Comment 7 by aelias@chromium.org, Jun 22 2017

Blockedon: 736092

Comment 8 by sadrul@chromium.org, Sep 29 2017

Blockedon: 676384 657959
Blockedon: -732507
Blockedon: -657959
Blockedon: 790807
Components: -Internals>Compositing -Internals>MUS Internals>Services>Viz
Labels: M-67
Summary: Get VizDisplayCompositor on Android working (was: Get mus-gpu on Android functioning)
Blockedon: 811962
Blockedon: 811964
Blockedon: 811967
Blockedon: 811970
Blockedon: 811973
Cc: kylec...@chromium.org jonr...@chromium.org samans@chromium.org fsam...@chromium.org
Project Member

Comment 19 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db7eb24cddb36bc183b633279735e4ed16edfab5

commit db7eb24cddb36bc183b633279735e4ed16edfab5
Author: Eric Karl <ericrk@chromium.org>
Date: Wed May 16 17:16:59 2018

Viz for Android Groundwork

This change updates CompositorImpl and DelegatedFrameHostAndroid with
the necessary logic to create a Viz process.

TBR=piman@chromium.org

Bug: 732555
Change-Id: I9290aeec317a95cd375a8a3ba0867a3c1548c52f
Reviewed-on: https://chromium-review.googlesource.com/1055626
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559157}
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/content/browser/BUILD.gn
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/db7eb24cddb36bc183b633279735e4ed16edfab5/ui/android/delegated_frame_host_android_unittest.cc

Blockedon: 848881
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81bd2f80e2607e4e55972bd929314c4aad3562ab

commit 81bd2f80e2607e4e55972bd929314c4aad3562ab
Author: Saman Sami <samans@chromium.org>
Date: Fri Jun 01 19:50:20 2018

Enable Viz display compositor flag on Android

Viz is fairly stable on Android so let it be turned on via flags.

Bug: 732555
Change-Id: I6453fc97b82e3a76eb45a100f958dd893a2ed6c3
Reviewed-on: https://chromium-review.googlesource.com/1082672
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563763}
[modify] https://crrev.com/81bd2f80e2607e4e55972bd929314c4aad3562ab/chrome/browser/about_flags.cc

Blockedon: 801350
Blockedon: 849702
Blockedon: 849707
Blockedon: 849709
Blockedon: 849712
Blockedon: 849746
Scrolling looks really stuck on Android. Is it expected at this stage ? Attaching trace.
trace_viz_scroll_nytimes.json.zip
3.5 MB Download
Blockedon: 850546
Blockedon: 851643
Blockedon: -633281
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a45528bce7ce871e0d7b49d389602d39f0310fad

commit a45528bce7ce871e0d7b49d389602d39f0310fad
Author: Fady Samuel <fsamuel@chromium.org>
Date: Fri Jun 15 17:51:40 2018

Android Viz: Remove unnecessary access to BeginFrameSource

DelegatedFrameHostAndroid owns a CompositorFrameSinkSupport
which has a BeginFrameSource and calls DidFinishFrame at the
appropriate time. The code in RenderWidgetHostViewAndroid is
unnecessary.

Change-Id: Icf5419c2bfb542018e3bd2f63319b33aea3b8b7e
Bug: 732555
Reviewed-on: https://chromium-review.googlesource.com/1102563
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567723}
[modify] https://crrev.com/a45528bce7ce871e0d7b49d389602d39f0310fad/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/a45528bce7ce871e0d7b49d389602d39f0310fad/content/browser/renderer_host/render_widget_host_view_android.h

Blockedon: 853799
Blockedon: 853809
Blockedon: 856846
Blockedon: 857542
Blockedon: 867453
Blockedon: 868504
Blockedon: 868476
Blockedon: 869131
Project Member

Comment 42 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c466fd2389ddd82bb72310e291d4c87aea3cce9a

commit c466fd2389ddd82bb72310e291d4c87aea3cce9a
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 16 21:47:27 2018

webview: Disable VizDisplayCompositor feature.

The VizDisplayCompositor feature enables OOP-d which changes the display
compositor pipeline. WebView doesn't support OOP-D and any shared code
that checks the features status risks breaking if it's enabled.

Bug: 732555
Change-Id: Ibc84d53a0ca4691ba7fadd10ed362244fb2b0e7a
Reviewed-on: https://chromium-review.googlesource.com/1177630
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583828}
[modify] https://crrev.com/c466fd2389ddd82bb72310e291d4c87aea3cce9a/android_webview/lib/aw_main_delegate.cc

Blockedon: 893700
Blockedon: 903240

Sign in to add a comment