New issue
Advanced search Search tips

Issue 732554 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 680790



Sign in to add a comment

Write integration tests for proceed-to-site for quiet interstitial

Project Member Reported by ntfschr@chromium.org, Jun 12 2017

Issue description

We're about to add details and the "visit unsafe site anyway" link to quiet interstitials, so we should add some webview integration tests for the proceed-to-site behavior.
 
Blockedon: -731721
Removing blocking bug, since enough of the internals are in place that it's still testable.

Ideally, we would do more end-to-end tests by simulating JavaScript button presses, but this doesn't currently seem to be feasible (we can't use JS in WebView tests to interact with the interstitial frame).
Can you inject JS into the WebView like felt suggested?

Example for checking visibility:
 https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?l=575
Still investigating this. I don't think our current JavaScript helper can actually interface with the interstitial page elements. Still investigating this.
Whoops, didn't mean to write "Still investigating this" twice. Copy-paste mistake
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c76f0f856f2062d75c0f98c3942151ee2207439b

commit c76f0f856f2062d75c0f98c3942151ee2207439b
Author: Nate Fischer <ntfschr@chromium.org>
Date: Thu Jun 15 20:11:24 2017

AW: add test for proceeding through quiet interstitial

No change to production logic.

This makes sure we can always proceed through quiet interstitials, since
we were previously only testing for loud interstitials. The UI change to
allow users to proceed through landed in crbug/731721.

Bug:  732554 
Test: run_webview_instrumentation_test_apk -f testSafeBrowsingProceedQuietInterstitial
Change-Id: I4a4212d4af717e0b08898f502641e63b5f6c5178
Reviewed-on: https://chromium-review.googlesource.com/532295
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479803}
[modify] https://crrev.com/c76f0f856f2062d75c0f98c3942151ee2207439b/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java

Status: Fixed (was: Assigned)
Closing this bug, filing  issue 733815  as a follow up to see if we can get JS running in the interstitial frame.
Labels: WebView-SafeBrowsing
Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.

Sign in to add a comment