Write integration tests for proceed-to-site for quiet interstitial |
||||
Issue descriptionWe're about to add details and the "visit unsafe site anyway" link to quiet interstitials, so we should add some webview integration tests for the proceed-to-site behavior.
,
Jun 13 2017
Can you inject JS into the WebView like felt suggested? Example for checking visibility: https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?l=575
,
Jun 13 2017
Still investigating this. I don't think our current JavaScript helper can actually interface with the interstitial page elements. Still investigating this.
,
Jun 13 2017
Whoops, didn't mean to write "Still investigating this" twice. Copy-paste mistake
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c76f0f856f2062d75c0f98c3942151ee2207439b commit c76f0f856f2062d75c0f98c3942151ee2207439b Author: Nate Fischer <ntfschr@chromium.org> Date: Thu Jun 15 20:11:24 2017 AW: add test for proceeding through quiet interstitial No change to production logic. This makes sure we can always proceed through quiet interstitials, since we were previously only testing for loud interstitials. The UI change to allow users to proceed through landed in crbug/731721. Bug: 732554 Test: run_webview_instrumentation_test_apk -f testSafeBrowsingProceedQuietInterstitial Change-Id: I4a4212d4af717e0b08898f502641e63b5f6c5178 Reviewed-on: https://chromium-review.googlesource.com/532295 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#479803} [modify] https://crrev.com/c76f0f856f2062d75c0f98c3942151ee2207439b/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
,
Jun 15 2017
Closing this bug, filing issue 733815 as a follow up to see if we can get JS running in the interstitial frame.
,
Oct 11 2017
,
Aug 24
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ntfschr@chromium.org
, Jun 13 2017