Handle zero timestamp in RTCVideoEncoder timestamp matching |
||||||||||
Issue descriptionWe do not calculate googEncodeMs and googEncodeUsagePercent properly for tab/desktop capture when HW encoder is used due to: - When using tab capture, timestamp of the first frame can be zero[0]. - When we are matching capture timestamp to RTP timestamp in RTCVideoEncoder, zero is used to indicate that HW encoder didn't preserve timestamp[1]. A quick fix would be to change default value from zero to base::TimeDelta::Max(). [0] https://cs.chromium.org/chromium/src/content/browser/media/capture/desktop_capture_device.cc?rcl=72b0661cd1fbc0297200f9ca88be19bdeb865508&l=346 [1] https://cs.chromium.org/chromium/src/content/renderer/media/gpu/rtc_video_encoder.cc?rcl=927ddf0ccfa6947292f0551c83e427822ac18045&l=515
,
Jun 14 2017
,
Jun 14 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2017
Thanks for the fix - Can you please provide more details of why this is urgent for M60? We've already branched, so please specify why this is critical to be merged for M60. Rejecting merge for now, but please re-request if required.
,
Jun 14 2017
Without this fix, googEncodeMs and googEncodeUsagePercent stats are broken for tab/desktop capture when HW encoder is used. This real time stats are tracked by webrtc internally and can be tracked by devs via chrome://webrtc-internals. It is a safe merge touching a very specific file, rtcvideoencoder.cc. Therefore, re-requesting merge again.
,
Jun 14 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 16 2017
Thanks for details - based on comment 5, approving merge for M60.
,
Jun 19 2017
,
Jun 20 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2017
Merge already done: https://codereview.chromium.org/2948623002/. It looks like the bot is lagging. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2017