Make upstream CrOS functional testing on the chromium waterfalls better |
||||||||||||||||||
Issue descriptionWe have a trybot for amd64-generic simple chrome compile: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng This builder needs a test step to invoke cros_run_vm_tests.py, introduced here: https://codereview.chromium.org/2927423002/ This builder also needs a copy of qemu-system-x86_64: https://cs.corp.google.com/chromeos_public/chromite/scripts/cros_vm.py?l=123
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/18b23fc0fec890f0aadb16c348cdaceffbcc74ed commit 18b23fc0fec890f0aadb16c348cdaceffbcc74ed Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Jun 14 23:10:37 2017 Add non-compile-only simplechrome trybots. This change adds optional non-compile-only trybots for the "simple chrome" configuration for ChromeOS, for the three supported boards (amd64-generic, daisy, and x86-generic). This CL also adds placeholder definitions for waterfall versions of these bots, but no actual bots yet. In a follow-up CL I plan to rename the waterfall bots so that we can follow a more conventional configuration. R=dnj@chromium.org BUG=732531 Change-Id: I97e09ca87702f05e69dc2c6079add5105431f909 Reviewed-on: https://chromium-review.googlesource.com/531762 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/18b23fc0fec890f0aadb16c348cdaceffbcc74ed/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/18b23fc0fec890f0aadb16c348cdaceffbcc74ed/masters/master.tryserver.chromium.linux/slaves.cfg [modify] https://crrev.com/18b23fc0fec890f0aadb16c348cdaceffbcc74ed/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/18b23fc0fec890f0aadb16c348cdaceffbcc74ed/masters/master.tryserver.chromium.linux/master.cfg
,
Jun 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/0cad99c5faf6b0cd4c0531b65a6a0bc1a7869cff commit 0cad99c5faf6b0cd4c0531b65a6a0bc1a7869cff Author: Dirk Pranke <dpranke@google.com> Date: Wed Jun 14 23:35:48 2017
,
Jun 15 2017
,
Jun 15 2017
,
Jun 15 2017
,
Jul 11 2017
,
Aug 30 2017
Requesting a change back to Pri-1 based on email exchange. Please let me know if we can't get to it.
,
Sep 8 2017
Update ... I'm finally freed up enough from the other stuff that was on my plate, and this (and related CrOS work) is now my P1 task. I've dusted off achuith's initial CL and am working again with him to get things working.
,
Oct 20 2017
I'm going to retitle this and use this bug as a rollup bug for the general "make upstream CrOS testing on the chromium waterfalls better" effort. This effort includes at least: - getting builds and some basic actual perf tests running on real devices (see bug 725766) - getting builds and some basic functional testing running on CrOS VM images (what is listed in the description of this bug) on both the waterfall and CQ.
,
Oct 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/307b41f51bead2ed2e83af3fc61888b0bfcf8ceb commit 307b41f51bead2ed2e83af3fc61888b0bfcf8ceb Author: Dirk Pranke <dpranke@chromium.org> Date: Sat Oct 21 02:13:16 2017 Rework chromium.chromiumos waterfalls and builders. As part of cleaning up how we test CrOS upstream on the chromium waterfalls (see the bug), this adds new builders to the chromium.chromiumos and tryserver.chromium.chromiumos waterfalls. As part of this, this CL switches builders to a new naming scheme that is based (loosely) on the iOS naming scheme: target_os[-{descriptor}]*[-compile]-(dbg|rel)[-arch] and uses those same names on the continuous waterfall and the tryserver waterfall. For example: linux-chromeos-rel linux-chromeos-compile-dbg linux-chromeos-dbg chromeos-amd64-generic-rel chromeos-betty-rel chromeos-daisy-rel With "linux-chromeos-rel", this indicates that this is a linux build in the "chromeos" configuration, as opposed to a build that is meant to run on an actual CrOS image, e.g. a simplechrome or ebuild build. (To make things even more confusing, the "chromeos" config sets the GN arg target_os="chromeos", but I don't think we should replicate that mistake here). With "chromeos-amd64-generic-rel", "amd64-generic" is the descriptor, which corresponds to the "amd64-generic" board. We'll use the board to imply the architecture, which is why "chromeos-daisy-rel" isn't "chromeos-daisy-rel-arm". R=friedman@chromium.org, smut@google.com BUG=732531, 777020 Change-Id: I08ef3e0d31399f4cd93c3e48c22868d15b420d10 Reviewed-on: https://chromium-review.googlesource.com/731832 Reviewed-by: smut <smut@google.com> Reviewed-by: Elliott Friedman <friedman@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/307b41f51bead2ed2e83af3fc61888b0bfcf8ceb/tests/masters_recipes_test.py [modify] https://crrev.com/307b41f51bead2ed2e83af3fc61888b0bfcf8ceb/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/307b41f51bead2ed2e83af3fc61888b0bfcf8ceb/masters/master.tryserver.chromium.chromiumos/builders.pyl [modify] https://crrev.com/307b41f51bead2ed2e83af3fc61888b0bfcf8ceb/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py [modify] https://crrev.com/307b41f51bead2ed2e83af3fc61888b0bfcf8ceb/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/307b41f51bead2ed2e83af3fc61888b0bfcf8ceb/masters/master.chromium.chromiumos/builders.pyl
,
Oct 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad2f8b4a0d98d96616eb99da6033ca671ce3c4d3 commit ad2f8b4a0d98d96616eb99da6033ca671ce3c4d3 Author: Dirk Pranke <dpranke@chromium.org> Date: Sat Oct 21 02:48:24 2017 Add MB, test configs for new CrOS builders. This is the src-side CL to set up the new CrOS builders as part of crrev.com/c/731832 R=smut@google.com NOTRY=true BUG=732531, 777020 Change-Id: Ic507c6a2262d18de623a0559dd4cfce42c06b356 Reviewed-on: https://chromium-review.googlesource.com/731838 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: smut <smut@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#510647} [modify] https://crrev.com/ad2f8b4a0d98d96616eb99da6033ca671ce3c4d3/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/ad2f8b4a0d98d96616eb99da6033ca671ce3c4d3/tools/mb/mb_config.pyl
,
Oct 21 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a38c589b0e2b2b60016e0718cdc887f91afc5ed commit 9a38c589b0e2b2b60016e0718cdc887f91afc5ed Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Oct 25 00:50:58 2017 Start turning up the new CrOS bots in the CQ. We will replace - chromeos_amd64-generic_chromium_compile_only_ng - chromeos_daisy_chromium_compile_only_ng - linux_chromium_chromeos_rel_ng with - chromeos-amd64-generic-rel - chromeos-daisy-rel - linux-chromeos-rel respectively. R=smut@google.com BUG=732531 Change-Id: Ia053a859666456319c2248caa31b23e8f619aa3a Reviewed-on: https://chromium-review.googlesource.com/731768 Reviewed-by: smut <smut@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#511320} [modify] https://crrev.com/9a38c589b0e2b2b60016e0718cdc887f91afc5ed/infra/config/cq.cfg
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/7eb174518be7da301d95b73fc22a40575334c690 commit 7eb174518be7da301d95b73fc22a40575334c690 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 01 00:04:23 2017 Remove chromeos-betty-rel config; we aren't going to use it. R=jbudorick@chromium.org BUG=732531 Change-Id: I52e25f3fea1f111248d7e2facd33d9edc5b5f849 Reviewed-on: https://chromium-review.googlesource.com/747817 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/7eb174518be7da301d95b73fc22a40575334c690/masters/master.chromium.chromiumos/builders.pyl [modify] https://crrev.com/7eb174518be7da301d95b73fc22a40575334c690/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py [modify] https://crrev.com/7eb174518be7da301d95b73fc22a40575334c690/scripts/slave/gatekeeper.json [modify] https://crrev.com/7eb174518be7da301d95b73fc22a40575334c690/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/7eb174518be7da301d95b73fc22a40575334c690/masters/master.tryserver.chromium.chromiumos/builders.pyl
,
Nov 1 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/7c8349f3784d7b29957c4ad0eb8f622f1a0b8e0f commit 7c8349f3784d7b29957c4ad0eb8f622f1a0b8e0f Author: Dirk Pranke <dpranke@google.com> Date: Wed Nov 01 00:38:51 2017
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b922d8ab1cdbf0eca0317bfc2b7cd6d119f4dfd commit 5b922d8ab1cdbf0eca0317bfc2b7cd6d119f4dfd Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 01 01:08:48 2017 Remove the "betty" board configs from chromium.chromiumos. We're not actually going to use that particular config. R=jbudorick@chromium.org BUG=732531 Change-Id: I6ab1cda23fdb621cccd19418263a57e955d032f8 Reviewed-on: https://chromium-review.googlesource.com/744594 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513034} [modify] https://crrev.com/5b922d8ab1cdbf0eca0317bfc2b7cd6d119f4dfd/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/5b922d8ab1cdbf0eca0317bfc2b7cd6d119f4dfd/tools/mb/mb_config.pyl
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ada995a67762d8ecb41b0243df88c58509bb4fe2 commit ada995a67762d8ecb41b0243df88c58509bb4fe2 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 01 23:51:04 2017 Move first of 3 CrOS (Chromium) CQ bots to a new waterfall. This CL flips the CQ configuration from running chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux to running chromeos-amd64-generic-rel on tryserver.chromium.chromiumos (which is the same bot configuration, just a different master and a different bot pool). R=jbudorick@chromium.org BUG=732531 Change-Id: Iba92a1de7df4e693f2c803c506adbe4912ce43f5 Reviewed-on: https://chromium-review.googlesource.com/749287 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513325} [modify] https://crrev.com/ada995a67762d8ecb41b0243df88c58509bb4fe2/infra/config/cq.cfg
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3d28226c758b95229f3ef715c550b2e69be3fee4 commit 3d28226c758b95229f3ef715c550b2e69be3fee4 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 08 03:08:02 2017 Move 10 bots from tryserver.chromium.linux -> chromiumos. This moves 10 bots from tryserver.chromium.linux to tryserver.chromium.chromiumos to give the latter a bit more capacity to handle CQ bots. We probably need to actually add 70-100 more bots to the pool in order to shift the other 3 builders over as well, and can probably only move 30-50 off of the linux pool, so we'll need more capacity, but let's see how this goes. TBR=jbudorick@chromium.org BUG=732531 Change-Id: Ie6de1633714a0ce1b4e3acaca5a303b0c68ecb9a Reviewed-on: https://chromium-review.googlesource.com/757982 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/3d28226c758b95229f3ef715c550b2e69be3fee4/masters/master.tryserver.chromium.linux/slaves.cfg [modify] https://crrev.com/3d28226c758b95229f3ef715c550b2e69be3fee4/masters/master.tryserver.chromium.chromiumos/builders.pyl
,
Nov 8 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/556ecc526066bc40e330b5b31ff65cabecaee45b commit 556ecc526066bc40e330b5b31ff65cabecaee45b Author: Dirk Pranke <dpranke@google.com> Date: Wed Nov 08 03:15:06 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b279947bf4b7649fdf7dadfcb696fc397d5a1ec commit 7b279947bf4b7649fdf7dadfcb696fc397d5a1ec Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 08 03:20:30 2017 Make chromeos-amd64-generic-rel part of the CQ. This makes chromeos-amd64-generic-rel a full member of the CQ (on tryserver.chromium.chromiumos), and removes chromeos_amd64-generic_chromium_compile_only_ng from tryserver.chromium.linux. TBR=jbudorick@chromium.org BUG=732531 Change-Id: Iec807d648841cad911338556558ff17ee656e83a Reviewed-on: https://chromium-review.googlesource.com/758140 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#514727} [modify] https://crrev.com/7b279947bf4b7649fdf7dadfcb696fc397d5a1ec/infra/config/cq.cfg
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53169efc778284a99b3c4c6637cbeab1b9e8da7d commit 53169efc778284a99b3c4c6637cbeab1b9e8da7d Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Nov 09 03:06:56 2017 Bump chromeos-daisy-rel, linux-chromeos-rel to 50% experiments. This is being done as part of migrating traffic off of tryserver.chromium.linux and onto tryserver.chromium.chromiumos, for better load balancing. R=smut@google.com BUG=732531 Change-Id: If4695fd38b1452fbbe37fa3ba4d99cb1c68f4130 Reviewed-on: https://chromium-review.googlesource.com/759271 Reviewed-by: smut <smut@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515080} [modify] https://crrev.com/53169efc778284a99b3c4c6637cbeab1b9e8da7d/infra/config/cq.cfg
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a60d0aa12be09fa738b6a93d66f9c962ddffa70 commit 3a60d0aa12be09fa738b6a93d66f9c962ddffa70 Author: Dirk Pranke <dpranke@chromium.org> Date: Mon Nov 13 23:11:52 2017 Move remaining CrOS CQ bots to tryserver.chromium.chromiumos. This moves chromeos-daisy-rel and linux-chromeos-rel from 50% experiments to full members of the CQ, and removes chromeos_daisy_chromium_compile_only_ng and linux_chromium_chromeos_rel_ng (which are on tryserver.chromium.linux) from the CQ. R=jbudorick@chromium.org BUG=732531 Change-Id: I3d91014b8c1f4f1d9d91acb0f8816faa155813b3 Reviewed-on: https://chromium-review.googlesource.com/767042 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516090} [modify] https://crrev.com/3a60d0aa12be09fa738b6a93d66f9c962ddffa70/infra/config/cq.cfg
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80f9360ddf776928b5d260321c2fb48343ccbfa2 commit 80f9360ddf776928b5d260321c2fb48343ccbfa2 Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Nov 14 04:57:59 2017 Add missing tests for linux-chromeos-{dbg,rel} builders. TBR=jbudorick@chromium.org BUG=732531 Change-Id: Ie6739813bd7655611d5a91974182342481fd0240 Reviewed-on: https://chromium-review.googlesource.com/768095 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516197} [modify] https://crrev.com/80f9360ddf776928b5d260321c2fb48343ccbfa2/testing/buildbot/chromium.chromiumos.json
,
Nov 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/daba9d7d04e50e546abd8cb926f63a997e89493e commit daba9d7d04e50e546abd8cb926f63a997e89493e Author: Dirk Pranke <dpranke@google.com> Date: Tue Nov 14 17:42:25 2017
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/95ce44b33f0accf5e10f0892099d9cffd77dacb9 commit 95ce44b33f0accf5e10f0892099d9cffd77dacb9 Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Nov 14 18:03:11 2017 Remove old CrOS builders. The following builders are now obsolete: - tryserver.chromium.linux - chromeos_amd64-generic - chromeos_amd64-generic_chromium_compile_only_ng - chromeos_daisy - chromeos_daisy_chromium_compile_only_ng - linux_chromium_chromeos_dbg_ng - linux_chromium_chromeos_rel_ng - linux_chromium_chromeos_compile_dbg_ng - chromium.chromiumos - Linux ChromiumOS Builder (dbg) - Linux ChromiumOS Tests (dbg)(1) - Linux ChromiumOS Builder - Linux ChromiumOS Tests (1) They have been replaced by the newer-named chromeos-* builders on chromium.chromiumos and tryserver.chromium.chromiumos. The only remaining old-style chromiumos builders are the ASan/MSan builders on chromium.memory (and the matching trybots) and the "Linux ChromiumOS Full" builder; I have to figure out what the latter is being used for. The former may eventually move to tryserver.chromium.chromiumos, or to a tryserver.chromium.memory waterfall, but that'll probably wait until after migrating to LUCI. This also removes the "linux-chromeos-compile-dbg" builder, since I don't think we really need it. R=jbudorick@chromium.org BUG=732531 Change-Id: I03013572e1070827fbfa49a1d92b1c029fe6c9ca Reviewed-on: https://chromium-review.googlesource.com/768088 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/95ce44b33f0accf5e10f0892099d9cffd77dacb9/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/95ce44b33f0accf5e10f0892099d9cffd77dacb9/masters/master.tryserver.chromium.linux/master.cfg [modify] https://crrev.com/95ce44b33f0accf5e10f0892099d9cffd77dacb9/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py [modify] https://crrev.com/95ce44b33f0accf5e10f0892099d9cffd77dacb9/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [delete] https://crrev.com/59849c21b839d92cd474b8779a2623dfccad6d09/scripts/slave/recipes/chromium_trybot.expected/chromeos_analyze.json [modify] https://crrev.com/95ce44b33f0accf5e10f0892099d9cffd77dacb9/masters/master.chromium.chromiumos/builders.pyl [modify] https://crrev.com/95ce44b33f0accf5e10f0892099d9cffd77dacb9/scripts/slave/recipes/chromium_trybot.py [modify] https://crrev.com/95ce44b33f0accf5e10f0892099d9cffd77dacb9/masters/master.tryserver.chromium.linux/slaves.cfg [delete] https://crrev.com/59849c21b839d92cd474b8779a2623dfccad6d09/scripts/slave/recipes/chromium_trybot.expected/recipe_config_changes_not_retried_without_patch.json
,
Nov 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/5f3a111d10d7ecfa7d9fdd6dae512e9e7096d1e6 commit 5f3a111d10d7ecfa7d9fdd6dae512e9e7096d1e6 Author: Dirk Pranke <dpranke@google.com> Date: Tue Nov 14 18:15:15 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bbcf27b9cd00f624006a663bc6c8d749aa6f148 commit 7bbcf27b9cd00f624006a663bc6c8d749aa6f148 Author: Hans Wennborg <hans@chromium.org> Date: Wed Nov 15 23:29:21 2017 docs/updating_clang.md: Use the new linux-chromeos-dbg trybot The old linux_chromium_chromeos_dbg_ng one doesn't exist anymore. Bug: 732531 Change-Id: I792eabe3111431b113e5224037dbd0f9fd6ce5f1 Reviewed-on: https://chromium-review.googlesource.com/772908 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#516888} [modify] https://crrev.com/7bbcf27b9cd00f624006a663bc6c8d749aa6f148/docs/updating_clang.md
,
Nov 16 2017
Pretty sure you guys are on it, but JIC I think the builders: [bucket "master.tryserver.chromium.linux"] //... builder = chromeos_amd64-generic_chromium_compile_only_ng builder = chromeos_daisy_chromium_compile_only_ng //... builder = linux_chromium_chromeos_compile_dbg_ng builder = linux_chromium_chromeos_compile_rel_ng builder = linux_chromium_chromeos_dbg_ng // builder = linux_chromium_chromeos_rel_ng At or around https://chromium.googlesource.com/chromium/src/+/refs/meta/config/buildbucket.config#62 should be removed, now that there's a specific category for those under the master.tryserver.chromium.chromiumos bucket, right? The turn purple in e.g.: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/550602 https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/451515
,
Nov 16 2017
@mcasas - correct, I'll get to this later today.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/29e6ce8b72e29459b3137939ca9aea33e1b5899e commit 29e6ce8b72e29459b3137939ca9aea33e1b5899e Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Nov 17 18:21:24 2017 Fix gatekeeper config for chromium.chromiumos. Previously the new builders I'd been working on were configured to be ignored by gatekeeper; however, now that I've removed the old builders, these need to be on by default. R=jbudorick@chromium.org BUG=732531 Change-Id: I054524cb9f48024fdb3b79d226059eac7e453e5c Reviewed-on: https://chromium-review.googlesource.com/777023 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/29e6ce8b72e29459b3137939ca9aea33e1b5899e/scripts/slave/gatekeeper.json
,
Jan 11 2018
,
Jan 11 2018
,
Jan 11 2018
Taking this over, as well as all cros-related efforts. Reiterating dpranke's comment #10 for my own sake. Current list of initiatives: - get functional tests on chromium's CQ running in cros VMs (this bug) - get chromium's performance tests/benchmarks running on real cros devices (bug 725766)
,
Jan 20 2018
Had a quick chat with Achuith earlier and he walked me through the scripts we'd be using to spinup VMs and manage the tests inside. Pointers for myself: https://chromium.googlesource.com/chromiumos/docs/+/master/cros_vm.md https://chromium.googlesource.com/chromiumos/chromite/+/master/scripts/cros_vm.py https://chromium.googlesource.com/chromiumos/chromite/+/master/scripts/cros_run_vm_test.py Couple thoughts so far: - It looks like we need to be in the cros chrome-sdk env to launch the vms. If we launch them on a per-task basis on the swarming bots, I wonder how much of a chromium checkout it would need to enter the env. (Surely not the whole thing?) - The scripts can automatically fetch a needed qemu binary and image before running. Alternatively, it can be pointed to pre-downloaded copies of each via cmd args. Given our affinity for idempotent tasks/tasks that don't download things from the network, we'd definitely want to isolate/package both up before scheduling the task. - qemu is only ~20 mb ( bug 776987 ), but the images are ~900 mb. Depending on how often the image changes, we need to be careful about how we fetch it, since we're always in danger of exceeding bandwidth where ever we run our stuff. - if the image doesn't change much, we might be able to simply throw it in the isolate and let the swarming bot's isolate cache keep it warm. I'll probably go with this approach for now. - if the image changes often, we might want the swarming bot itself to manage the image (and maybe even the VMs themselves?) so it could prioritize bots with the latest images and explicitly keep them around for re-use. Tentatively exploring this in https://docs.google.com/document/d/18Z8vnRFf2C0z3WoNUTmqNTkYatCG9Cm3PL4xKYLXwrQ/ - The VMs are launched with a ~4gb disk. I just tried to a flat push of my build dir and quickly ran out of space. I'm not seeing an arg to tweak that disk space, so we'd definitely want to be able to customize that. (probably trivial)
,
Jan 20 2018
Hrmmm, I think I found where the filesystems in the images are configured: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/master/overlay-amd64-generic/scripts/disk_layout.json#29 Doesn't seem easily tweaked, at least not at runtime. A unit_tests executable for amd64-generic is itself 1.5g (!). That makes things awfully tight. I wonder if we can add an additional drive at vm launch time? I'll need to look into this more next week...
,
Feb 13 2018
,
Feb 14 2018
#30/#31: getting more complaints of the old builders still being available in the "Choose More Trybots" menu, since they're still in buildbucket.config, since they're still in mb_config: https://bugs.chromium.org/p/chromium/issues/detail?id=812267
,
Feb 14 2018
Issue 812267 has been merged into this issue.
,
Feb 14 2018
Ugh, I must've dropped that on the floor :(. Will fix ASAP.
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b78db0e67b1ac69d36e4dffbe8fcc7e7ea69bed0 commit b78db0e67b1ac69d36e4dffbe8fcc7e7ea69bed0 Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Feb 15 23:12:43 2018 Add missing entry for linux-chromeos-compile-dbg to trybots.py. R=bpastene@chromium.org BUG=732531 Change-Id: Ib542ccc1c60816abfab15447242d03e98c460a3c Reviewed-on: https://chromium-review.googlesource.com/920779 Reviewed-by: Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/b78db0e67b1ac69d36e4dffbe8fcc7e7ea69bed0/scripts/slave/recipe_modules/chromium_tests/trybots.py
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b6d3f7d8f556c8c2d4a87a201801fbe7de9fe7e commit 6b6d3f7d8f556c8c2d4a87a201801fbe7de9fe7e Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Feb 16 03:49:22 2018 Clean up tryserver.chromium.linux entries in mb_config.pyl. This removes entries for a number of builders that have either been removed or were never actually added. This will allow us to update the buildbucket config as well. R=bpastene@chromium.org, agable@chromium.org BUG=732531 Change-Id: I1155f0a2eeb95de4da029ea4ff8dd8f894cb3898 Reviewed-on: https://chromium-review.googlesource.com/920602 Reviewed-by: Benjamin Pastene <bpastene@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537182} [modify] https://crrev.com/6b6d3f7d8f556c8c2d4a87a201801fbe7de9fe7e/tools/mb/mb_config.pyl
,
Feb 16 2018
Thanks for #43; note that some of those bots were already removed in crrev.com/c/920602 (r537182) but they came back in crrev.com/c/855510, so perhaps they should be removed elsewhere too? Just a thought.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d8ac1b4c1fe49b249575ed7d935fc533b720eb1 commit 9d8ac1b4c1fe49b249575ed7d935fc533b720eb1 Author: Benjamin Pastene <bpastene@chromium.org> Date: Tue Apr 03 20:33:02 2018 Add a DEPS hook that fetches simplechrome artifacts when targetting cros https://chromium-review.googlesource.com/c/chromium/tools/build/+/988694/ will turn it on for the simple chrome bots (Right now they invoke all of gclient inside the chrome-sdk.) Bug: 732531, 828392 Change-Id: I1f892970cd19fd8f64dcfb6615d3033301ac2fcb Reviewed-on: https://chromium-review.googlesource.com/989235 Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#547812} [modify] https://crrev.com/9d8ac1b4c1fe49b249575ed7d935fc533b720eb1/DEPS [modify] https://crrev.com/9d8ac1b4c1fe49b249575ed7d935fc533b720eb1/build/.gitignore
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/39f1b9fcee124c8665789ce583e69ab0102dea80 commit 39f1b9fcee124c8665789ce583e69ab0102dea80 Author: Benjamin Pastene <bpastene@chromium.org> Date: Fri Apr 13 22:10:40 2018 Disable vpython in all cros-chrome-sdk invocations for simplechrome bots Needed to get our simplechrome bots working on luci. Without this patch: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/1 With the patch: https://chromium-swarm.appspot.com/task?id=3ca1978860226810 This mirrors what the PFQ does to resolve the vpython import problems for chromite. See https://bugs.chromium.org/p/chromium/issues/detail?id=783517 for more context. Recipe-Nontrivial-Roll: build_limited_scripts_slave Bug: 732531, 793907, 793908 Change-Id: Iffae1693aa60c2f789da5bbdaed58cc09a3db845 Reviewed-on: https://chromium-review.googlesource.com/991120 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/chromium/tests/run_mb.expected/cros_board.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/empty_string_args.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/tryjob_complex.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/chromium/__init__.py [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/chromite/api.py [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/tryjob_simple.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/swarming_builder.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/README.recipes.md [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/tuple_args.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/filter/__init__.py [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/chromium/api.py [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/chromium/tests/compile.expected/chromeos.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/swarming/staging.expected/cros.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/chromium/tests/runhooks.expected/chromeos.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/complex_slave_builder.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/goma_canary.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipes/cros/swarming.expected/master_builder.json [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/filter/api.py [modify] https://crrev.com/39f1b9fcee124c8665789ce583e69ab0102dea80/scripts/slave/recipe_modules/filter/tests/analyze.expected/basic.json
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/1fb06b3a7184e0cdb70a7dede13c921bde02f88f commit 1fb06b3a7184e0cdb70a7dede13c921bde02f88f Author: Benjamin Pastene <bpastene@chromium.org> Date: Wed Apr 18 00:58:19 2018 Don't clear the cros chrome-sdk cache during mb gen. Runhooks currently takes care of cleaning the cache. This secondary cleaning removes the vm image we download during runhooks and is totally unnecessary. Recipe-Nontrivial-Roll: build_limited_scripts_slave Bug: 732531 Change-Id: I61b238200543da49e81909ec924dc08ccf3f0d92 Reviewed-on: https://chromium-review.googlesource.com/1016035 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/1fb06b3a7184e0cdb70a7dede13c921bde02f88f/scripts/slave/recipe_modules/chromium/tests/run_mb.expected/cros_board.json [modify] https://crrev.com/1fb06b3a7184e0cdb70a7dede13c921bde02f88f/scripts/slave/recipes/swarming/staging.expected/cros.json [modify] https://crrev.com/1fb06b3a7184e0cdb70a7dede13c921bde02f88f/scripts/slave/recipe_modules/chromium/api.py
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99550d2779068b45189a360c8db4c3076b69d9c9 commit 99550d2779068b45189a360c8db4c3076b69d9c9 Author: Benjamin Pastene <bpastene@chromium.org> Date: Thu Apr 19 00:16:43 2018 Only download vm images for available CrOS boards during sync. With the current setup, gclient runhooks will try (and fail) downloading a vm image when the board is set to anything but "amd64-generic". This'll fix that. Note that we could make the chrome-sdk non fatal when downloading a vm image that doesn't exist, but I don't think that makes sense. Bug: 732531 Change-Id: I2714c8ecd913acf606671504fe0e5dc49f369494 Reviewed-on: https://chromium-review.googlesource.com/1017584 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#551892} [modify] https://crrev.com/99550d2779068b45189a360c8db4c3076b69d9c9/DEPS
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b254d023b48d450f39ef865746317f164c2ac549 commit b254d023b48d450f39ef865746317f164c2ac549 Author: Benjamin Pastene <bpastene@chromium.org> Date: Thu Apr 19 17:11:47 2018 Don't wrap runhooks in the cros chrome-sdk for simplechrome bots. And point all other invocations of it to the new cache location. (Used to be "src/../.cros_cache" but now it's "src/build/cros_cache") And also set the gclient var cros_board so the gclient hook downloads the right board for each bot. Recipe-Nontrivial-Roll: build_limited_scripts_slave Bug: 832374 , 732531 Change-Id: I9aea093d7a6e519922eb375cf82bc0da1ebd0336 Reviewed-on: https://chromium-review.googlesource.com/1013289 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium/tests/run_mb.expected/cros_board.json [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium/examples/full.py [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium/api.py [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/README.recipes.md [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/filter/tests/analyze.expected/basic.json [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium/gclient_config.py [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium/tests/compile.expected/chromeos.json [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium/tests/runhooks.expected/chromeos.json [add] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipe_modules/chromium/examples/full.expected/chromeos_simplechrome.json [modify] https://crrev.com/b254d023b48d450f39ef865746317f164c2ac549/scripts/slave/recipes/swarming/staging.expected/cros.json
,
Apr 20 2018
,
Apr 25 2018
+rjkroege@ who also praised the effort of having one or two physical CrOs devices in the Chromium CQ running a set of unittests to verify we don't break -- which I understand to be a (the?) goal of this Issue (or is it the goal of Issue 725766?).
,
Apr 25 2018
"Make upstream CrOS functional testing on the chromium waterfalls better" is obviously a vague statement. As I described to posciak@, wuchengli@ and others in a meeting yesterday, there's a bunch of different goals we might have for this: 1. continuous testing of chrome tests (unit_tests, browser_tests, telemetry_unittests) on VMs 2. continuous testing of (generic) chrome tests on real devices 3. continuous testing of highly-device-specific tests (like GPU and media tests) on real devices 4. smoke testing of perf benchmarks and integration tests (i.e., chromeos-specific tests), either on VMs or real devices 5. real perf testing on real devices 6. some or all of the above in the CQ. Currently we are focusing most on (1), and have VMs running chrome tests reliably on an FYI builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests We are probably about at the point where we can move these tests to a continuous main (non-fyi) builder and start looking at adding them to the CQ. We'll need devs' help getting many of the tests green. We're still working on some things like telemetry support so we're not fully there yet. Adding these sorts of things to the CQ should be a straightforward matter of scaling and capacity, which we think we have. We have real devices configured, but we don't have a lot of them yet (we have ~30 kevins). It's unclear what the right split of functional vs. gpu/media vs. perf should be right now. We will hopefully have those running some tests soon as well, we're just person-bandwidth-limited on doing both this and the VM testing, so we could also benefit from help here. Running all of the tests we want to run just on the waterfall (functional, gpu/media, perf) will probably require more than 30 devices. Putting real devices on the CQ is a whole different kettle of fish. To do that, we'll need probably 500-1000 of each board or device we want to test. It's unclear to me if there are any devices we can hope to get in such quantities; maybe we could get Kevins, Carolines, or Eves? Regardless, even if we can get them, it'll be a sizable effort to acquire them, rack them, and make sure they're running stably. So, I don't expect us to have that particularly soon.
,
Apr 26 2018
I'm told there are a large number of Kevins around somewhere. How many would be helpful? I can try to track down the folks who know where they are.
,
Apr 26 2018
> How many would be helpful? I'm not sure we really need any at the moment, i.e., we can't effectively use more than the 30 we have. However, it's probably a good idea to figure out what we'd need if we did want to do this at scale, so I'll file a separate bug for that and we can get the labs folks on it.
,
Apr 26 2018
> How many would be helpful? At the moment, I don't think we can effectively use any more, as we are neither using the ones we have nor likely have rack space for any more. I think it'll be at least a while before we can scale up past the 30 we have. However, it's probably a good idea to get started figuring out how to scale out now. I'll file a separate bug for this and link to it from here.
,
Apr 26 2018
I had a quick chat with kanliu@ on it after my comment #53. I guess it's Carolines rather than Kevins. If/when you do get to a place where you need more machines textor@ should know where those are.
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c35c578d6b5fc3c7f6e4d36e7014a4306e19960 commit 4c35c578d6b5fc3c7f6e4d36e7014a4306e19960 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Apr 30 23:21:48 2018 Declare cros board and sdk version as gn args. This will let the chrome-sdk explicitly set them as args (ie CL:1035427) Once that lands, then we can remove the default env-var logic. Bug: 732531 Change-Id: Id8283e6018f8f7e652a29cb367b0a3c10adc6fa8 Reviewed-on: https://chromium-review.googlesource.com/1035602 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#554917} [modify] https://crrev.com/4c35c578d6b5fc3c7f6e4d36e7014a4306e19960/build/config/chromeos/rules.gni [modify] https://crrev.com/4c35c578d6b5fc3c7f6e4d36e7014a4306e19960/testing/test.gni
,
May 3 2018
,
May 8 2018
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f531b1eb97370d0cc42f5e0ed08fa32304590f4 commit 0f531b1eb97370d0cc42f5e0ed08fa32304590f4 Author: Ben Pastene <bpastene@chromium.org> Date: Wed May 09 21:16:04 2018 Add the LKGM file as data for cros VM test runner. Bug: 732531 Change-Id: Ic29cd0a7032f707509797229d995a4a4e28b2582 Reviewed-on: https://chromium-review.googlesource.com/1052915 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#557317} [modify] https://crrev.com/0f531b1eb97370d0cc42f5e0ed08fa32304590f4/build/config/chromeos/rules.gni
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8a1ffe0c9756bff7503ab77c2452bc3089653654 commit 8a1ffe0c9756bff7503ab77c2452bc3089653654 Author: Ben Pastene <bpastene@chromium.org> Date: Wed May 23 08:25:48 2018 chrome-sdk: Add board and sdk version as gn args. This will let us propagate board/sdk values to test wrapper scripts generated at build time. In other words, we have gn rules that create a wrapper script around each test that's built. The gn rules bind whatever build-time-constants the tests need in the generated wrapper. (eg: output directory, path to test binary, runtime deps) For our cros use-case, that also includes the board/sdk-version. This explicitly lists those as gn args. (CL:1035602 declares them, so this should be safe to land after that.) BUG=chromium:732531 TEST=Unittests Change-Id: I9934201e6ccd9eb9e86b179163b01d096df8b7d8 Reviewed-on: https://chromium-review.googlesource.com/1035427 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/8a1ffe0c9756bff7503ab77c2452bc3089653654/cli/cros/cros_chrome_sdk.py
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b704df54a7307feff9cbcfcf3bd8edbd9fa4678d commit b704df54a7307feff9cbcfcf3bd8edbd9fa4678d Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 23 09:45:54 2018 Roll src/third_party/chromite/ fdd7e08cd..8a1ffe0c9 (1 commit) https://chromium.googlesource.com/chromiumos/chromite.git/+log/fdd7e08cde5d..8a1ffe0c9756 $ git log fdd7e08cd..8a1ffe0c9 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 bpastene chrome-sdk: Add board and sdk version as gn args. Created with: roll-dep src/third_party/chromite BUG=chromium:732531 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If7a8fea914f24d0f4719d2f44cba84d7a6896c96 Reviewed-on: https://chromium-review.googlesource.com/1069918 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561018} [modify] https://crrev.com/b704df54a7307feff9cbcfcf3bd8edbd9fa4678d/DEPS
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06b8433a29577df38d64f4fdefbb192d01fa059e commit 06b8433a29577df38d64f4fdefbb192d01fa059e Author: Ben Pastene <bpastene@chromium.org> Date: Wed May 23 20:33:32 2018 CrOS-SimpleChrome: Don't use env vars for default board and sdk args. After https://chromium-review.googlesource.com/1035427, they're declared directly as gn args when entering the chrome-sdk. Bug: 732531 Change-Id: Ida9f58fc01482da4357ac822bd04f288fb140d34 Reviewed-on: https://chromium-review.googlesource.com/1070491 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#561235} [modify] https://crrev.com/06b8433a29577df38d64f4fdefbb192d01fa059e/build/config/chromeos/rules.gni
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c228d491eb86e4a116799d3e3a68e28c843077f5 commit c228d491eb86e4a116799d3e3a68e28c843077f5 Author: Ben Pastene <bpastene@chromium.org> Date: Thu Jul 12 01:48:55 2018 cros_chrome_sdk: Change default location of cros cache dir. This changes it from "src/../.cros_cache" to "src/build/cros_cache". This gives the following benefits: - It places the sdk's toolchains near where we put toolchains for other platforms. (See the linux sysroot location: https://chromium.googlesource.com/chromium/src/+/master/build/.gitignore#19). - It places the cache inside the checkout (instead of outside it, ie: above the "src" dir). This plays nicely when using the sdk in environments that expect all needed files to be contained within "src/" (eg: a swarming bot's workdir). - It makes the cache more visible by removing the leading "." in the dir's name. The fewer hidden surprises we have in a checkout, the better. BUG=chromium:732531 TEST=unittests Change-Id: I11b72a4bc818c45a88fa3ce2b1f8848e9c1aa317 Reviewed-on: https://chromium-review.googlesource.com/1123274 Commit-Ready: Ben Pastene <bpastene@chromium.org> Tested-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/c228d491eb86e4a116799d3e3a68e28c843077f5/lib/path_util_unittest.py [modify] https://crrev.com/c228d491eb86e4a116799d3e3a68e28c843077f5/lib/path_util.py [modify] https://crrev.com/c228d491eb86e4a116799d3e3a68e28c843077f5/scripts/cros_gdb.py
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d2b40f1e97ac53c5a2cb52d05a9dac1cd27eaebb commit d2b40f1e97ac53c5a2cb52d05a9dac1cd27eaebb Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Jul 20 12:31:16 2018 cros_chrome_sdk: Delete .cros_cache when --clear-sdk-cache is specified. Add testClearSDKCache to test --clear-sdk-cache. BUG=chromium:732531 TEST=RunThroughTest.testClearSDKCache Change-Id: Ic2c7ddd547e2a74050a85411e1354c58a0ecfc9c Reviewed-on: https://chromium-review.googlesource.com/1142467 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d2b40f1e97ac53c5a2cb52d05a9dac1cd27eaebb/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/d2b40f1e97ac53c5a2cb52d05a9dac1cd27eaebb/lib/path_util.py [modify] https://crrev.com/d2b40f1e97ac53c5a2cb52d05a9dac1cd27eaebb/cli/cros/cros_chrome_sdk_unittest.py
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60f80879af74355bff3f1b95a8ec1a24e74f8655 commit 60f80879af74355bff3f1b95a8ec1a24e74f8655 Author: Ben Pastene <bpastene@chromium.org> Date: Wed Jul 25 18:53:13 2018 Refactor cros VM test runner with more test abstraction. Now with more OOP! Class structure is: RemoteTest | --- GTestTest | --- BrowserSanityTest Doesn't add anything new. Just splits out sanity-test and gtest-test logic into their own classes (and resuses what it can in a parent class) I'm planning on making some changes to how GTests are launched in the VM. This'll make that easier. I'm also thinking about reusing some logic in here when running hardware tests. This will make that easier as well. Bug: 732531, 866062 Change-Id: I80a6e29c657b1db6c7911cb873c64be094c9b5ef Reviewed-on: https://chromium-review.googlesource.com/1145796 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#577996} [add] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/PRESUBMIT.py [modify] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/create_vm_test_script.py [add] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/pylintrc [modify] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/run_vm_test.py
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f275fd94375783f830c24aae5a4a6cc07da93da commit 7f275fd94375783f830c24aae5a4a6cc07da93da Author: Ben Pastene <bpastene@chromium.org> Date: Fri Aug 24 22:01:39 2018 Generate a single shell script for cros VM tests. And invoke that instead of invoking a long list of chained commands. This generates a temporary shell script on the host at test-time, pushes it over to the VM, then removes it after the test on the host. (The VM gets auto cleaned-up.) Bug: 732531, 876587 Change-Id: I7a2e5749d329d6f7a8716724c8c1060d4f8f80d3 Reviewed-on: https://chromium-review.googlesource.com/1149189 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#586014} [modify] https://crrev.com/7f275fd94375783f830c24aae5a4a6cc07da93da/build/chromeos/run_vm_test.py
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58e1347031d3d01dd2671cb5933cb9323702a3a7 commit 58e1347031d3d01dd2671cb5933cb9323702a3a7 Author: Miguel Casas <mcasas@chromium.org> Date: Tue Sep 04 20:29:31 2018 Enable jpeg_decode_accelerator_unittest in chromiumos_preflight jpeg_decode_accelerator_unittest is compiled and run on the CrOs autotest infra, but is not compiled on the bots, when it possibly should. This CL adds that target to the chromiumos_preflight of the top level BUILD.gn. Bug: 732531, 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iee1c95a4c0c12d3a0e55451447d6d862e1cb1484 Reviewed-on: https://chromium-review.googlesource.com/1199580 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#588635} [modify] https://crrev.com/58e1347031d3d01dd2671cb5933cb9323702a3a7/BUILD.gn [modify] https://crrev.com/58e1347031d3d01dd2671cb5933cb9323702a3a7/media/gpu/BUILD.gn
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7cc370e948265fe0f617d943544cda51b1f5239 commit f7cc370e948265fe0f617d943544cda51b1f5239 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Sep 04 21:19:23 2018 Revert "Enable jpeg_decode_accelerator_unittest in chromiumos_preflight" This reverts commit 58e1347031d3d01dd2671cb5933cb9323702a3a7. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 588635 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU4ZTEzNDcwMzFkM2QwMWRkMjY3MWNiNTkzM2NiOTMyMzcwMmEzYTcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win-rel/2001 Sample Failed Step: compile Original change's description: > Enable jpeg_decode_accelerator_unittest in chromiumos_preflight > > jpeg_decode_accelerator_unittest is compiled and run on the CrOs > autotest infra, but is not compiled on the bots, when it possibly > should. This CL adds that target to the chromiumos_preflight of > the top level BUILD.gn. > > Bug: 732531, 877694 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Iee1c95a4c0c12d3a0e55451447d6d862e1cb1484 > Reviewed-on: https://chromium-review.googlesource.com/1199580 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588635} Change-Id: I0092e01151c3e9700ef64be7646849ff90066b01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732531, 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1204599 Cr-Commit-Position: refs/heads/master@{#588642} [modify] https://crrev.com/f7cc370e948265fe0f617d943544cda51b1f5239/BUILD.gn [modify] https://crrev.com/f7cc370e948265fe0f617d943544cda51b1f5239/media/gpu/BUILD.gn
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dcce853f96a2def66b860afe65c1a333d98f778 commit 4dcce853f96a2def66b860afe65c1a333d98f778 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Sep 05 23:13:36 2018 RELAND: Enable jpeg_decode_accelerator_unittest in chromiumos_preflight The original CL crrev.com/c/1199580 was reverted in crrev.com/c/1204599 because it broke windows compilation (File path literals etc). This CL limits the compilation to linux and chromeos: the new changes can be seen in crrev.com/c/1206675/1..2 TBR=jbudorick@chromium.org, sandersd@chromium.org since the changes are trivial re. the previous CL. Original CL description ----------------------------------------------- jpeg_decode_accelerator_unittest is compiled and run on the CrOs autotest infra, but is not compiled on the bots, when it possibly should. This CL adds that target to the chromiumos_preflight of the top level BUILD.gn. Bug: 732531, 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1199580 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588635} Change-Id: Ic71fc5076484d30dda90654cd5501aa802258feb Reviewed-on: https://chromium-review.googlesource.com/1206675 Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589051} [modify] https://crrev.com/4dcce853f96a2def66b860afe65c1a333d98f778/BUILD.gn [modify] https://crrev.com/4dcce853f96a2def66b860afe65c1a333d98f778/media/gpu/BUILD.gn
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e865a56bd15e1ff2acc8f6a0a919036c3f6760b8 commit e865a56bd15e1ff2acc8f6a0a919036c3f6760b8 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Sep 05 23:23:17 2018 Do not use components/arc/common in non CrOs builds I found that (at least win) bots are using components/arc/common stuff (see e.g. [1]), when this are supposed to be limited to CrOs. This CL corrects that by sandwiching the appropriate BUILD entries between if(is_chromeos). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout /BUILD.gn mojom(media) Bug: 732531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic0e807b5b97d1aadd5736377188456634424647d Reviewed-on: https://chromium-review.googlesource.com/1208410 Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589056} [modify] https://crrev.com/e865a56bd15e1ff2acc8f6a0a919036c3f6760b8/components/arc/common/BUILD.gn [modify] https://crrev.com/e865a56bd15e1ff2acc8f6a0a919036c3f6760b8/services/viz/privileged/interfaces/gl/BUILD.gn
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34cd555a197d2296d99cf63d4d83b7297dc6a931 commit 34cd555a197d2296d99cf63d4d83b7297dc6a931 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Sep 05 23:52:24 2018 Revert "Do not use components/arc/common in non CrOs builds" This reverts commit e865a56bd15e1ff2acc8f6a0a919036c3f6760b8. Reason for revert: Causing gn analyze problems e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-dbg/331 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/2125 /b/swarming/w/ir/cache/builder/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //components/viz/service/main/viz_main_impl.cc:22:11: Can't include this header from here. #include "media/gpu/buildflags.h" ^--------------------- The target: //components/viz/service/main:main is including a file from the target: //media/gpu:buildflags It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //components/viz/service/main:main --> //components/viz/service:service --[private]--> //media/gpu/ipc/service:service --[private]--> //media/gpu:buildflags Original change's description: > Do not use components/arc/common in non CrOs builds > > I found that (at least win) bots are using components/arc/common > stuff (see e.g. [1]), when this are supposed to be limited to > CrOs. This CL corrects that by sandwiching the appropriate > BUILD entries between if(is_chromeos). > > [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout > /BUILD.gn mojom(media) > > Bug: 732531 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: Ic0e807b5b97d1aadd5736377188456634424647d > Reviewed-on: https://chromium-review.googlesource.com/1208410 > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589056} TBR=lhchavez@chromium.org,mcasas@chromium.org,rsesek@chromium.org,kylechar@chromium.org Change-Id: I2638bbedd77268b26ca0c3ca4fc94606d196b545 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1208678 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589065} [modify] https://crrev.com/34cd555a197d2296d99cf63d4d83b7297dc6a931/components/arc/common/BUILD.gn [modify] https://crrev.com/34cd555a197d2296d99cf63d4d83b7297dc6a931/services/viz/privileged/interfaces/gl/BUILD.gn
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78000e55d0ba664609cdb9a30bab42b503864d38 commit 78000e55d0ba664609cdb9a30bab42b503864d38 Author: Miguel Casas <mcasas@chromium.org> Date: Fri Sep 07 14:59:54 2018 RELAND: Do not use components/arc/common in non CrOs builds The original CL was reverted bc it caused a gn gen --check problem -- I assumed this was checked somewhere in our CQ :-( Anyways, fixed: //components/viz/service/main:main used the removed dependency to use //media/gpu{:buildflags,:vaapi}, so these are added explicitly. gn gen --check passes locally now w/ the diffs: crrev.com/c/1208418/2..11 TBR=rsesek@ for services/viz/privileged/interfaces/gl/gpu_service.mojom and lhchavez@ for components/arc/common/BUILD.gn (since there are no new changes in this CL re those files). Original CL ---------------------------------------------------------- Do not use components/arc/common in non CrOs builds I found that (at least win) bots are using components/arc/common stuff (see e.g. [1]), when this are supposed to be limited to CrOs. This CL corrects that by sandwiching the appropriate BUILD entries between if(is_chromeos). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout /BUILD.gn mojom(media) Bug: 732531 Change-Id: Ie870b0ccb90216b9b455a25f34761a03d5a13b16 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1208410 Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589056} Reviewed-on: https://chromium-review.googlesource.com/1208418 Cr-Commit-Position: refs/heads/master@{#589516} [modify] https://crrev.com/78000e55d0ba664609cdb9a30bab42b503864d38/components/arc/common/BUILD.gn [modify] https://crrev.com/78000e55d0ba664609cdb9a30bab42b503864d38/components/viz/host/BUILD.gn [modify] https://crrev.com/78000e55d0ba664609cdb9a30bab42b503864d38/components/viz/service/main/BUILD.gn [modify] https://crrev.com/78000e55d0ba664609cdb9a30bab42b503864d38/services/viz/privileged/interfaces/gl/BUILD.gn [modify] https://crrev.com/78000e55d0ba664609cdb9a30bab42b503864d38/services/viz/privileged/interfaces/gl/gpu_service.mojom
,
Sep 11
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e62c31b76164db9dc22f4ce7ebeff3c970a45687 commit e62c31b76164db9dc22f4ce7ebeff3c970a45687 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Oct 24 00:45:56 2018 BUILD: add jpeg_encode_accelerator_unittests on CrOs CQ bots This CL adds jpeg_encode_accelerator_unittests to the chromiumos_preflight target, so it gets compiled as part of the CQ (chromeos-amd64-generic-rel bot). Bug: 732531 Change-Id: I49e2db7d8259ee7746100cd858d1d19638384e87 Reviewed-on: https://chromium-review.googlesource.com/c/1297249 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#602193} [modify] https://crrev.com/e62c31b76164db9dc22f4ce7ebeff3c970a45687/BUILD.gn |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by steve...@chromium.org
, Jun 12 2017