New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732525 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 616244



Sign in to add a comment

Remove WebController dependency from tab_test_util.mm

Project Member Reported by baxley@chromium.org, Jun 12 2017

Issue description

tab_test_util needs to depend on ios/web/web_state/ui/crw_web_controller.h, based on how tab eviction is implemented for tests.

The test helper for tab eviction should be re-written to use a different API, or the tests could be updated (or deleted?), then the dependency can be removed.
 
Blocking: 616244
Labels: -Type-Bug -Pri-2 Pri-3 Type-Task
Cc: -eugene...@chromium.org
Owner: eugene...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/974e0b5564781b8c620acc6efa78e0566f2bf397

commit 974e0b5564781b8c620acc6efa78e0566f2bf397
Author: Eugene But <eugenebut@google.com>
Date: Fri Jul 21 21:36:38 2017

Removed -[CRWWebController handleLowMemory] call.

Disabling and enabling web usage has the same effect of evicting tabs.

Bug:  732525 
Change-Id: I2ecafe2ddaf419aaeea81500f94d8b5893dee95e
Reviewed-on: https://chromium-review.googlesource.com/581848
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488755}
[delete] https://crrev.com/446e5b893436ceab5dae61e87d5df95467348975/ios/chrome/test/app/DEPS
[modify] https://crrev.com/974e0b5564781b8c620acc6efa78e0566f2bf397/ios/chrome/test/app/tab_test_util.mm

Status: Fixed (was: Started)

Sign in to add a comment