Image Capture: add getPhotoOptions() method |
||||
Issue descriptionFollow up spec issue https://github.com/w3c/mediacapture-image/pull/183
,
Jun 15 2017
https://www.chromestatus.com/feature/5104908176982016 is tracking this feature.
,
Jun 15 2017
https://www.chromestatus.com/feature/5104908176982016 is tracking this feature. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EZruVTchex8 is the blink-dev@ discussion.
,
Jun 20 2017
Somehow my landed patches didn't ping this bug, so copying by hand: https://chromium-review.googlesource.com/c/534754/ Image Capture: add getPhotoSettings() method This CL adds a method getPhotoSettings() to catch up with the idl [1], and also adds tests for it. ToT code calls the two mojo methods (getPhotoState() and SetOptions()) and distinguishes how to Resolve() the Promises via the Blink's |service_requests_| map. Instead of extending this mechanism, this CL binds to the OnMojo...() methods one of 4 new callbacks (WTF::Function): - ResolveWithNothing() - ResolveWithPhotoSettings() - ResolveWithPhotoCapabilities() - ResolveWithMediaTrackConstraints() So that the different sequences to mojo and back are now: getPhotoCapabilities --> OnMojoGetPhotoState --> ResolveWithPhotoCapabilities getPhotoSettings --> OnMojoGetPhotoState --> ResolveWithPhotoSettings setOptions --> OnMojoSetOptions --> OnMojoGetPhotoState --> ResolveWithNothing SetMediaTrackConstraints --> OnMojoSetOptions --> OnMojoGetPhotoState --> ResolveWithMediaTrackConstraints (note that the "set" versions have a cycle of setting and a cycle of current state readback). [1] https://github.com/w3c/mediacapture-image/issues/167 Bug: 732521 Change-Id: Id5a3ee3b58cedd289a18fa1c721be390776c6543 Reviewed-on: https://chromium-review.googlesource.com/534754 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#480447} https://chromium-review.googlesource.com/c/539756/ Image Capture: use single quotes throughout layout tests This CL homogeneises all JS quotes to be single, where they are mixed on ToT. ** No new code ** HTML quotes stay double, i.e.: <script src="resources/mock-imagecapture.js"></script> Bug: 732521 Change-Id: I590d93e258dfb5d2e620431d6d73b1cee0247ec4 Reviewed-on: https://chromium-review.googlesource.com/539756 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#480481}
,
Jun 20 2017
Commit 141446c9... initially landed in 61.0.3136.0
,
Jun 20 2017
,
Jul 18 2017
ImageCapture.getPhotoSettings() is landed: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl?sq=package:chromium&dr&l=19 |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2017