Hide info menu item in Downloads' search mode |
||||||||
Issue descriptionChrome Version: 61.0.3129.0 OS: Android What steps will reproduce the problem? (1) On home page, open overflow menu and click 'Downloads' (2) Download some web pages so that info menu item shows in toolbar (3) Click 'search' menu item to enter search mode (4) type something in the search bar, and then click 'clear text' (x button) Observed behavior: Info menu item shows in the search bar Expected behavior: Info menu item should never show in search mode Frequency: 100%
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad604940edf862c4379cf916eaa81d3fc8b7ee36 commit ad604940edf862c4379cf916eaa81d3fc8b7ee36 Author: huayinz <huayinz@chromium.org> Date: Mon Jun 12 21:11:58 2017 Hide info menu item in Downloads' search mode Before: info menu item shows when user clear edit text in search mode Now: info menu item does not show in search mode BUG= 732516 Review-Url: https://codereview.chromium.org/2939523002 Cr-Commit-Position: refs/heads/master@{#478764} [modify] https://crrev.com/ad604940edf862c4379cf916eaa81d3fc8b7ee36/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
,
Jun 12 2017
,
Jun 12 2017
Requesting a merge for this really simple (one line) fix, since the download info toggle landed in 60.0.3101.0.
,
Jun 13 2017
,
Jun 13 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2017
As described in the original bug report, the downloads info button shows up when typing any query in the downloads search bar that matches one or more query. Tapping the button does nothing. The current user experience is confusing, but doesn't crash.
,
Jun 13 2017
*that matches one or more download.
,
Jun 13 2017
Approved for M60 branch 3112. Please merge ASAP.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17836174c5a06af39ae12482c27aa8321b1fd18a commit 17836174c5a06af39ae12482c27aa8321b1fd18a Author: Theresa Wellington <twellington@google.com> Date: Tue Jun 13 18:00:55 2017 Hide info menu item in Downloads' search mode Before: info menu item shows when user clear edit text in search mode Now: info menu item does not show in search mode BUG= 732516 TBR=twellington@chromium.org,huayinz@chromium.org Review-Url: https://codereview.chromium.org/2939523002 Cr-Original-Commit-Position: refs/heads/master@{#478764} Review-Url: https://codereview.chromium.org/2939493004 . Cr-Commit-Position: refs/branch-heads/3112@{#322} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/17836174c5a06af39ae12482c27aa8321b1fd18a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
,
Jun 13 2017
,
Jun 14 2017
Verified on chrome:60.0.3112.33 Device:Pixel XL/OPR1.170614.001 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by twelling...@chromium.org
, Jun 12 2017Components: UI>Browser>Downloads
Labels: -Pri-3 Pri-1