New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732507 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Figure out FrameSinkManagerHost usage on Android

Project Member Reported by fsam...@chromium.org, Jun 12 2017

Issue description

On desktop, FrameSinkManagerHost is owned by BrowserMainLoop, independently of ImageTransportFactory. On Android, FrameSinkManagerHost is owned by CompositorImpl and a surfaces_utils file contain functions that grab FrameSinkManagerHost from either CompositorImpl on Android and BrowserMainLoop on other platforms.

CompositorImpl implements content::Compositor which is a public interface in content used outside of content by the VR shell.

CompositorImpl is owned by CompositorView on Chrome for Android, and VrCompositor.

CompositorImpl accesses CompositorDependencies which is a singleton that holds FrameSinkManagerHost, FrameSinkIdAllocator and so on. 

It is unclear what the global root object where other objects hang off of is on Android.

We should refactor Android code to use a single code path for accessing the FrameSinkManagerHost and friends.

Perhaps both Chrome desktop and Chrome for Android should use content::Compositor as a singleton?

I don't think any code really needs to access FrameSinkManagerHost. Perhaps content::Compositor can handle higher level concepts like "CreateCompositorFrameSink"?

I think content::Compositor could entirely replace ImageTransportFactory/ContextFactory on all platforms eventually.
 
Status: Available (was: Untriaged)

Comment 2 by danakj@chromium.org, Jun 12 2017

Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature

Comment 3 by danakj@chromium.org, Jun 12 2017

Blocking: -730193

Comment 4 by danakj@chromium.org, Jun 12 2017

Blocking: 732555
Components: -Internals>MUS
Cc: vollick@chromium.org
+vollick since this also impacts VR.
Blocking: -732555
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
This doesn't seem relevant after the Viz Android work that has been done. Closing this out.

Sign in to add a comment