search box needs color info based on the wallpaper |
|||||
Issue descriptionBased on specification document, search box will have different UI based on color info based on the wallpaper. Xiyuan notes: "most of ui/app_list/* runs as part of the browser process (including SearchBoxView). They could not (and should not) access the ash WallpaperController directly. And even chrome browser should not do that, considering we are moving towards mash. We might need to add mojo interface to ash/public/interfaces/wallpaper.mojom so that browser can observer the wallpaper color change and notify app list about it."
,
Jun 19 2017
,
Jun 27 2017
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02a49172b8b948e288a8a382f9b98a70c33bf1de commit 02a49172b8b948e288a8a382f9b98a70c33bf1de Author: Qiang Xu <warx@chromium.org> Date: Fri Jun 30 00:10:23 2017 add components/wallpaper to ui/app_list/DEPS Usage is reviewed at https://chromium-review.googlesource.com/c/550320/. Bug: 732492 R: xiyuan@chromium.org, xdai@chromium.org TEST: none Change-Id: Iecbb3dbae48fecb9e62756f4546d4bf64d3de596 Reviewed-on: https://chromium-review.googlesource.com/556934 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#483555} [modify] https://crrev.com/02a49172b8b948e288a8a382f9b98a70c33bf1de/ui/app_list/DEPS
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91d2e90881fc404976e1aa462d1d6a1681c0d687 commit 91d2e90881fc404976e1aa462d1d6a1681c0d687 Author: Qiang Xu <warx@chromium.org> Date: Wed Jul 05 20:47:09 2017 cros: Get wallpaper prominent colors for closed searchbox view changes: In crrev.com/2943333003, multiple/six wallpaper prominent colors are extracted in ash::WallpaperController. This CL wants to get dark muted color and light vibrant color for app_list::SearchBoxView. (1) Define remote observer mojo::WallpaperObserver for this purpose. (2) Make AppListViewDelegate in chrome/ as a observer, and notify wallpaper color changes for search box model. And add WallpaperProminentColorsChanged() API in SearchBoxModelObserver to update the search box view. (3) if wallpaper prominent color is available, using dark muted color extracted form the wallpaper for G, microphone as well as the label; using (light vibrant color 100% + #FFF 70%) at 100% opacity for searchbox background color. flag, screenshot: https://screenshot.googleplex.com/awwbVHnjDPV R: xiyuan@chromium.org, xdai@chromium.org, jamescook@chromium.org Bug: 733391 , 732492 TEST: tested with and without --enable-features=EnableFullscreenAppList Change-Id: I07890f48ea02518bbfd948035d9e4d4a01d56c65 Reviewed-on: https://chromium-review.googlesource.com/550320 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#484344} [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ash/public/interfaces/wallpaper.mojom [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ash/wallpaper/wallpaper_controller.h [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/chrome/browser/ui/app_list/app_list_view_delegate.cc [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/chrome/browser/ui/app_list/app_list_view_delegate.h [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/components/wallpaper/BUILD.gn [add] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/components/wallpaper/wallpaper_color_profile.h [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ui/app_list/BUILD.gn [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ui/app_list/search_box_model.cc [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ui/app_list/search_box_model.h [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ui/app_list/search_box_model_observer.h [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/91d2e90881fc404976e1aa462d1d6a1681c0d687/ui/app_list/views/search_box_view.h
,
Jul 5 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by warx@chromium.org
, Jun 14 2017