VR: Disable back button when back button would have no effect. |
|||||
Issue descriptionRight now we don't allow the back button in VR to exit chrome/exit VR. In the case where the back button would exit Chrome we silently ignore it. We should detect this case in advance and disable the back button.
,
Jul 14 2017
mthiesse: Ping. Assigning at least to update the bug.
,
Jul 14 2017
Patch in progress: https://chromium-review.googlesource.com/c/571289/
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b252e79db1eeb875b31269f520dcf4c2905f6904 commit b252e79db1eeb875b31269f520dcf4c2905f6904 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Jul 20 17:19:51 2017 VR: Disable back button when back would background Chrome. Refactors some code from CTAs back button flow to be reusable by VR to know in advance whether clicking the back button will backgroud chrome (or try to show Chrome Home when that's enabled, which isn't supported in VR anyways). Bug: 732475 Change-Id: Ife41c456fac880f55ba3190f257fa7ed340d00e0 Reviewed-on: https://chromium-review.googlesource.com/571289 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488283} [modify] https://crrev.com/b252e79db1eeb875b31269f520dcf4c2905f6904/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/b252e79db1eeb875b31269f520dcf4c2905f6904/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java [modify] https://crrev.com/b252e79db1eeb875b31269f520dcf4c2905f6904/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/b252e79db1eeb875b31269f520dcf4c2905f6904/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java [modify] https://crrev.com/b252e79db1eeb875b31269f520dcf4c2905f6904/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrTransitionUtils.java [modify] https://crrev.com/b252e79db1eeb875b31269f520dcf4c2905f6904/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCommon.java [modify] https://crrev.com/b252e79db1eeb875b31269f520dcf4c2905f6904/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestRule.java
,
Jul 20 2017
,
Jul 20 2017
Issue 735143 has been merged into this issue.
,
Aug 2 2017
verified in 62.0.3173.0 Opened new tab, entered Chrome VR, and back button was disabled. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vollick@chromium.org
, Jul 10 2017