New issue
Advanced search Search tips

Issue 732474 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Select saved region in shipping address editor when loaded asynchronously.

Project Member Reported by se...@chromium.org, Jun 12 2017

Issue description

Currently, it is only selected if the rules are done loading when the view is displayed.

This should also work if they are loaded after. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01849b7576ac59271bc1b52f276347adebcc6b81

commit 01849b7576ac59271bc1b52f276347adebcc6b81
Author: sebsg <sebsg@chromium.org>
Date: Mon Jun 12 20:29:41 2017

[Payments] Select saved region when loaded async in ship addr editor.

Bug:  732474 
Change-Id: Ibe686ac089ec53cda5b4a21705e2006445eabbb6
Reviewed-on: https://chromium-review.googlesource.com/531854
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478743}
[modify] https://crrev.com/01849b7576ac59271bc1b52f276347adebcc6b81/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/01849b7576ac59271bc1b52f276347adebcc6b81/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Comment 2 by se...@chromium.org, Jun 13 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 13 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can you please provide more justification for why this is required to be merged in for M60, and can't wait until 61?
Labels: -Merge-Review-60 Merge-Rejected-60
Rejecting merge for now, until there is more justification for post-branch merge. Please re-request if needed. 

Comment 6 by se...@chromium.org, Jun 15 2017

Labels: Merge-Request-60
This is a blocker for the launch of Payment Request on Desktop platforms. If it's not in, most user's states won't be selected in the Payment Request profile editor.
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 15 2017

Labels: -Merge-Request-60 Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Rejected-60 Merge-Approved-60
Based on comment 5/6, approving merge for M60. 
Labels: -Merge-Review-60
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 16 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6adf556aeefcb155b33a98bf6bf45e1a5d0447d9

commit 6adf556aeefcb155b33a98bf6bf45e1a5d0447d9
Author: sebsg <sebsg@chromium.org>
Date: Fri Jun 16 20:31:51 2017

Merge-60 Select saved region when loaded async in ship addr editor.

Bug:  732474 
Change-Id: Ibe686ac089ec53cda5b4a21705e2006445eabbb6
Reviewed-on: https://chromium-review.googlesource.com/531854
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#478743}
Review-Url: https://codereview.chromium.org/2943113003 .
Cr-Commit-Position: refs/branch-heads/3112@{#365}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/6adf556aeefcb155b33a98bf6bf45e1a5d0447d9/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/6adf556aeefcb155b33a98bf6bf45e1a5d0447d9/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Comment 11 by se...@chromium.org, Jun 16 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment