Select saved region in shipping address editor when loaded asynchronously. |
|||||||||||
Issue descriptionCurrently, it is only selected if the rules are done loading when the view is displayed. This should also work if they are loaded after.
,
Jun 13 2017
,
Jun 13 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2017
Can you please provide more justification for why this is required to be merged in for M60, and can't wait until 61?
,
Jun 14 2017
Rejecting merge for now, until there is more justification for post-branch merge. Please re-request if needed.
,
Jun 15 2017
This is a blocker for the launch of Payment Request on Desktop platforms. If it's not in, most user's states won't be selected in the Payment Request profile editor.
,
Jun 15 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 16 2017
Based on comment 5/6, approving merge for M60.
,
Jun 16 2017
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6adf556aeefcb155b33a98bf6bf45e1a5d0447d9 commit 6adf556aeefcb155b33a98bf6bf45e1a5d0447d9 Author: sebsg <sebsg@chromium.org> Date: Fri Jun 16 20:31:51 2017 Merge-60 Select saved region when loaded async in ship addr editor. Bug: 732474 Change-Id: Ibe686ac089ec53cda5b4a21705e2006445eabbb6 Reviewed-on: https://chromium-review.googlesource.com/531854 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#478743} Review-Url: https://codereview.chromium.org/2943113003 . Cr-Commit-Position: refs/branch-heads/3112@{#365} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/6adf556aeefcb155b33a98bf6bf45e1a5d0447d9/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc [modify] https://crrev.com/6adf556aeefcb155b33a98bf6bf45e1a5d0447d9/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
,
Jun 16 2017
,
Jun 27 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 12 2017