New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 732452 link

Starred by 3 users
Status: Fixed
Owner:
█ xiaoyinh@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
r...@chromium.org
jdufault@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
LoginRefresh

Show other hotlists

Other hotlists containing this issue:
Hotlist-1
Hotlist-2


Sign in to add a comment

public session information needed for view based login screen

Project Member Reported by xiaoyinh@chromium.org, Jun 12 2017 
Public session exist in login screen, but not lock screen. So we don't need it for views based lock screen for now, later if we want to make login screen in views, public session information needs to be populated and send to login screen views.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d2aa0f19c22ec48929d59bf95175ac75945b9ff

commit 1d2aa0f19c22ec48929d59bf95175ac75945b9ff
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Sat Feb 10 01:08:13 2018

Populate public session info in chrome.

1. Create mojo struct for the public session info.
2. Connect LoginDisplayViews with UserSelectionScreen and populate the
information in UserSelectionScreen then send it via LoadUsers mojo call.
3. Remove unused user data: initialKeyboardLayout and gaiaId



Bug:  732452 
Change-Id: Id67b1b29f0f7fad853ad475557099af38a239fce
Reviewed-on: https://chromium-review.googlesource.com/907973
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535908}
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/ash/BUILD.gn
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/ash/public/interfaces/login_user_info.mojom
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/chrome/browser/chromeos/login/ui/login_display_views.cc
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/chrome/browser/chromeos/login/ui/login_display_views.h
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/mojo/common/values_struct_traits.cc
[modify] https://crrev.com/1d2aa0f19c22ec48929d59bf95175ac75945b9ff/mojo/common/values_struct_traits.h

Comment 2 by xiaoyinh@chromium.org, Mar 2 2018

Status: Fixed (was: Untriaged)
UI work  for public session is tracked in  crbug.com/809635
►

Sign in to add a comment