New issue
Advanced search Search tips

Issue 732447 link

Starred by 1 user
Status: Fixed
Owner:
guidou@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MediaStreamConstraintsUtilAudioTest.ValidGeometry fails on WinTests dbg bot

Project Member Reported by guidou@chromium.org, Jun 12 2017 
See
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/60774

[ RUN      ] MediaStreamConstraintsUtilAudioTest.ValidGeometry/0
c:\b\c\b\win\src\content\renderer\media\media_stream_constraints_util_audio_unittest.cc(1269): error:       Expected: 2u
      Which is: 2
To be equal to: geometry.size()
      Which is: 0
[ RUN      ] MediaStreamConstraintsUtilAudioTest.ValidGeometry/0
c:\b\c\b\win\src\content\renderer\media\media_stream_constraints_util_audio_unittest.cc(1269): error:       Expected: 2u
      Which is: 2
To be equal to: geometry.size()
      Which is: 0
[ RUN      ] MediaStreamConstraintsUtilAudioTest.ValidGeometry/0
c:\b\c\b\win\src\content\renderer\media\media_stream_constraints_util_audio_unittest.cc(1269): error:       Expected: 2u
      Which is: 2
To be equal to: geometry.size()
      Which is: 0
[ RUN      ] MediaStreamConstraintsUtilAudioTest.ValidGeometry/0
c:\b\c\b\win\src\content\renderer\media\media_stream_constraints_util_audio_unittest.cc(1269): error:       Expected: 2u
      Which is: 2
To be equal to: geometry.size()
      Which is: 0

Comment 1 by guidou@chromium.org, Jun 12 2017

Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)
There is no reason why this should fail only on this bot.
Apparently ParsePointsFromString (https://cs.chromium.org/chromium/src/media/base/audio_point.cc?q=ParsePointsFromString&sq=package:chromium&dr=CSs&l=29) is broken somehow on this particular configuration.

The test passes on all other Windows bots.

Comment 2 by guidou@chromium.org, Jun 12 2017 

However, that function has tests with the same values as MediaStreamConstraintsUtilAudioTest.ValidGeometry. 
Running on a win debug trybot to see if the problem reproduces.
Otherwise, disabling the test on win-debug looks like a valid choice.

Comment 3 by guidou@chromium.org, Jun 12 2017 

The failure is reproducible on the win_chromium_dbg_ng trybot.
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_dbg_ng/builds/2366

Comment 4 by guidou@chromium.org, Jun 14 2017 

The problem seems to be a compiler bug (either the Win Debug compiler is buggy or all others are).
Comparing a pointer-to-member-function value for equality is false on the  WinDbg compiler and true on all other compilers.
However, if this value is stored in an array, the same comparison returns true when comparing against the array member.
The unittest was fixed in https://codereview.chromium.org/2941553003/

Comment 5 by guidou@chromium.org, Jun 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment