"JsonPrefStoreCallbackTest.TestSerializeDataCallbacks" is flaky |
||
Issue description"JsonPrefStoreCallbackTest.TestSerializeDataCallbacks" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRKc29uUHJlZlN0b3JlQ2FsbGJhY2tUZXN0LlRlc3RTZXJpYWxpemVEYXRhQ2FsbGJhY2tzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db69a3c824adfdfa2ee72018485217e1c02d2d32 commit db69a3c824adfdfa2ee72018485217e1c02d2d32 Author: Henrik Grunell <grunell@chromium.org> Date: Tue Jun 13 11:54:04 2017 Disable flaky JsonPrefStoreCallbackTest.TestSerializeDataCallbacks on Linux TSAN. TBR=pam@chromium.org,fdoray@chromium.org Bug: 732445 Change-Id: I97b53f93ac403ea0c2af0089e8e8ef54379e0f5c Reviewed-on: https://chromium-review.googlesource.com/533034 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#478974} [modify] https://crrev.com/db69a3c824adfdfa2ee72018485217e1c02d2d32/components/prefs/json_pref_store_unittest.cc
,
Jun 26 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f54795c5e4848eca77835c2ac79c685c675315e commit 5f54795c5e4848eca77835c2ac79c685c675315e Author: Francois Doray <fdoray@chromium.org> Date: Tue Jul 25 21:02:05 2017 Fix race in JsonPrefStoreCallbackTest.TestSerializeDataCallbacks. Previously, the callback was allowed to run before methods were called to verify that the callback did not run (GetAndResetPreWriteObservationState() and GetAndResetPostWriteObservationState()). This resulted in a data race. This CL uses a QUEUED ScopedTaskEnvironment to ensure that the callback does not run before the test has verified that it did not run. Bug: 732445 Change-Id: Id8da025667cd7a7b4dab876802418cd1e885ba82 Reviewed-on: https://chromium-review.googlesource.com/549097 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489427} [modify] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/components/prefs/in_memory_pref_store_unittest.cc [modify] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/components/prefs/json_pref_store_unittest.cc [modify] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/components/prefs/overlay_user_pref_store_unittest.cc [modify] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/components/prefs/persistent_pref_store_unittest.cc [modify] https://crrev.com/5f54795c5e4848eca77835c2ac79c685c675315e/components/prefs/persistent_pref_store_unittest.h
,
Jul 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by grunell@chromium.org
, Jun 13 2017Owner: fdoray@chromium.org
Status: Assigned (was: Untriaged)