New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732443 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

google-chrome.desktop file needs: StartupNotify=true

Reported by ckr...@gmail.com, Jun 12 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36

Steps to reproduce the problem:
1. Click the Google Chrome icon in the GNOME >= 3.18 Ubuntu desktop applications menu.
2. If first start, wait a longer period for application to source and startup.
3. Wonder if anything is happening since the launcher gives no appreciable feedback due to lack of StartupNotify=true in .desktop file.

What is the expected behavior?
/usr/share/applications/google-chrome.desktop _needs_ StartupNotify=true in order to give feedback to users in non Unity-based desktop environments.

What went wrong?
Not sure if upstream or packager failed to include this in the google-chrome-stable package.

Did this work before? N/A 

Chrome version: 59.0.3071.86  Channel: stable
OS Version: Ubuntu Gnome 17.04
Flash Version: ???

Please add or provide logic to detect non Unity-based desktop environments as Ubuntu is switching back to GNOME for all future releases as of 17.10.
 
Cc: pbomm...@chromium.org thomasanderson@chromium.org thestig@chromium.org
Labels: pre-stable-59.0.3071.86 M-59
Labels: TE-NeedsTriageHelp
This issue seems to be out of TE-scope. Hence, adding label TE-NeedsTriageHelp for further investigation.

Thanks...!!
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 19 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: ma...@endlessm.com
+mario@ This seems similar to the work you did in  bug 553956 .  I haven't done my research, but do you know if Chrome should now add StartupNotify=true ?

Comment 6 by ma...@endlessm.com, Jun 20 2018

@thomasanderson Oh, yes.. it does indeed need that now if it was not there already. Sorry about not mentioning this before, I was focused on the chromium side of things since we based our browser on the chromium-browser from Ubuntu, which already included this line in the desktop file that comes along with their debian package.

About the google-chrome package, though, I'm a bit confused on whether such change should be done, since I can't see the google-chrome.desktop file anywhere in the chromium git repo (I assume it lives somewhere else, where the packaging for Chrome happens?)

Comment 7 by ckr...@gmail.com, Jun 20 2018

As the OP for this bug, I can confirm that the issue is still outstanding in Version 67.0.3396.87 (Official Build) (64-bit).

If this needs to be escalated to the "Chrome" packaging team, please let me know where to post.

Thanks. 
google-chrome.desktop
8.2 KB Download

Comment 8 by ma...@endlessm.com, Jun 20 2018

Anywhere in the `[Desktop Entry]` section of the desktop file should be fine, just need to add a line with `StartupNotify=true` and that should do it.
Owner: thomasanderson@chromium.org
Status: Started (was: Archived)
Thanks, Mario.  I'll add the change on Chrome's side.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c405bafadea4b31024750ec6e536588e4b439f43

commit c405bafadea4b31024750ec6e536588e4b439f43
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jun 20 18:10:05 2018

Add StartupNotify=true to Linux desktop entry

Startup notification is a mechanism for apps to notify the desktop environment
when they are finished starting [1].  Desktop environments may use this to
eg. animate a progress spinner on an app icon until it's finished starting.

As of r565390 [2], Chrome should correctly send the notification.  To let the
launcher know that Chrome now supports this protocol, advertise it by adding
StartupNotify=true to the desktop entry.

[1] https://developer.gnome.org/integration-guide/stable/startup-notification.html.en
[2] https://chromium.googlesource.com/chromium/src.git/+/0a85ddf22d19c89ca524182b42f938ebf4fa50a0

BUG= 732443 
R=thestig
CC=mario@endlessm.com

Change-Id: Id37dba4b7272e30316e930f6dc0eb625c7107ba6
Reviewed-on: https://chromium-review.googlesource.com/1108354
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568924}
[modify] https://crrev.com/c405bafadea4b31024750ec6e536588e4b439f43/chrome/installer/linux/common/desktop.template

Status: Fixed (was: Started)

Sign in to add a comment