New issue
Advanced search Search tips

Issue 732432 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

wekit-patch rebaseline-cl crash: AttributeError: 'NoneType' object has no attribute 'group'

Project Member Reported by wangxianzhu@chromium.org, Jun 12 2017

Issue description

I encountered the crash when trying to rebaseline for https://chromium-review.googlesource.com/c/529525/.

To reproduce:
1. Create a local branch
2. git cl patch https://chromium-review.googlesource.com/c/529525/ (which has already try results)
3. webkit-patch rebaseline-cl

The above reproduction steps are just for others to reproduce. They are not exactly what I did when encountered the issue. I just used the normal webkit-patch rebaseline-cl process.

Traceback (most recent call last):
  File "/usr/local/google/home/wangxianzhu/chrome/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/usr/local/google/home/wangxianzhu/chrome/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py", line 116, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py", line 110, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py", line 53, in execute
    jobs = self.latest_try_jobs()
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py", line 126, in latest_try_jobs
    return self.git_cl().latest_try_jobs(self._try_bots())
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 107, in latest_try_jobs
    try_results = self.try_job_results()
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 117, in try_job_results
    return {self._build(r): self._try_job_status(r) for r in raw_results}
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 117, in <dictcomp>
    return {self._build(r): self._try_job_status(r) for r in raw_results}
  File "/ssd/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 142, in _build
    build_number = match.group(1)
AttributeError: 'NoneType' object has no attribute 'group'

 
Status: Started (was: Assigned)
Ah, thanks for reporting! 

From the error message it appears that in the output of `git cl --json`, one of the try job result dictionaries has a 'url' entry that doesn't match r'.*/builds/(\d+)?$'.
The code in webkitpy.common.net.git_cl was trying to parse a build number from URLs like "https://luci-milo.appspot.com/swarming/task/36a767f405d9ee10" - uploaded a fix at https://chromium-review.googlesource.com/531664.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf1510ef49539b5a60eb73d984e2089f3bc52bb

commit 2cf1510ef49539b5a60eb73d984e2089f3bc52bb
Author: Quinten Yearsley <qyearsley@google.com>
Date: Mon Jun 12 19:59:38 2017

webkitpy git_cl: Handle build urls with unexpected formats

Bug:  732432 
Change-Id: Id9b1ef6f89c03b3bddc2d3b5a4a8ed1d901dae98
Reviewed-on: https://chromium-review.googlesource.com/531664
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478732}
[modify] https://crrev.com/2cf1510ef49539b5a60eb73d984e2089f3bc52bb/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py
[modify] https://crrev.com/2cf1510ef49539b5a60eb73d984e2089f3bc52bb/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment