New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732418 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit 16 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

22.7% regression in browser_tests at 478516:478516

Project Member Reported by niklase@google.com, Jun 12 2017

Issue description

Pretty much all the H264 windows perf tests alerted after this change: https://codereview.chromium.org/2925313002. It's the only CL in the range.
 
Labels: -Pri-2 Pri-1
Additionally, Mac Tester started failing with the below errors starting with that CL. It shows that we have multiple frames with the same timestamp. I am going to check to see how that is happening.
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/68735
[19735:26891:0610/114914.883677:FATAL:rtc_video_encoder.cc(667)] Check failed: std::find_if(pending_timestamps_.begin(), pending_timestamps_.end(), [&frame](const RTCTimestamps& entry) { return entry.media_timestamp_ == frame->timestamp(); }) == pending_timestamps_.end(). 

Comment 2 by magjed@chromium.org, Jun 12 2017

emircan@ - I'm looking into that as well, in issue 732345.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 13 2017

Labels: Hotlist-Google

Sign in to add a comment