Signin access the command line from the IO thread |
|||||
Issue descriptionAs per the CommandLine documentation, it is not thread safe. However, signin code accesses it on the IO thread, for account consistency switches. See some discussion in https://codereview.chromium.org/2925083002
,
Jul 14 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 17 2017
Keeping this assigned. David: Do you have any news about this? Is is a problem to use the CommandLine from the IO thread?
,
Jul 17 2017
Nothing new here. From what I understand the class is not thread safe, but it works in Chrome because the command line is never changed after startup. It is somewhat hacky though, because it is not enforced in any way, and someone could introduce subtle a crash easily, by simply appending a switch from what seems to be the right thread. Not sure what to do though. The CommandLine class should maybe be changed to become "read-only" after startup?
,
Jul 17 2017
I think we should close this bug as WontFix or assign it to brett@ if we expect an answer from him for comment #1. WDYT?
,
Aug 16 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by droger@chromium.org
, Jun 13 2017