New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 732402
issue 772105

Blocking:
issue 672311



Sign in to add a comment

blink hit-test service

Project Member Reported by rjkroege@chromium.org, Jun 12 2017

Issue description

For some hit-testing cases found on the webplatform (e.g. css clip-path), the hit-testing component may not be able to resolve whether a given event is inside or outside of a arbitrarily-bounded area. In this case, the hit-test client library will ( http://crbug.com/732402 ) ask the client what to do. Implement the blink service able to determine which of its frames should receive events in this context.
 
Status: Assigned (was: Untriaged)
Components: Blink>Input
Labels: Hotlist-Input-Dev
Labels: event-targeting
Status: Started (was: Assigned)

Comment 5 by bokan@chromium.org, Jun 29 2017

Cc: bokan@chromium.org
Blockedon: 732402
Blockedon: 772105
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d86e5f9c367557ea0e9c607399acc65d9607fd6

commit 0d86e5f9c367557ea0e9c607399acc65d9607fd6
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Mon Oct 23 18:09:22 2017

Expose hit-testing API in Blink to the renderer

Expose the hit-testing API to the renderer and
add another API to return the web frame id
from the result frame.

Bug:  732405 
Change-Id: Id17cd8e9f8b258c1420ee4fd42ec452cb19f38ed
Reviewed-on: https://chromium-review.googlesource.com/702996
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510850}
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/content/renderer/input/render_widget_input_handler.h
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/content/renderer/render_widget.cc
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/content/renderer/render_widget.h
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/content/renderer/render_widget_browsertest.cc
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/third_party/WebKit/Source/core/exported/WebFrame.cpp
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/third_party/WebKit/Source/core/frame/WebViewFrameWidget.cpp
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/third_party/WebKit/Source/core/frame/WebViewFrameWidget.h
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/third_party/WebKit/public/web/WebFrame.h
[modify] https://crrev.com/0d86e5f9c367557ea0e9c607399acc65d9607fd6/third_party/WebKit/public/web/WebWidget.h

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e71b8ec84c640da708cea03e939f5ac3ceba6b00

commit e71b8ec84c640da708cea03e939f5ac3ceba6b00
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Sat Dec 16 07:03:36 2017

Add mojo interface for renderer hit test API

Expose renderer hit test API to the browser
with a mojo interface. With this API browser
can ask a renderer about the target frame
of a given point. The API returns the sink id
of the target frame. The result frame could be
either a remote or local frame from the
renderer's point of view.

Bug:  732405 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I2606dbeb71eb0cc7d593c80eb73cbcb24d2774ad
Reviewed-on: https://chromium-review.googlesource.com/751721
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524597}
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/components/viz/host/DEPS
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/renderer/BUILD.gn
[add] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/renderer/input/input_target_client_impl.cc
[add] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/renderer/input/input_target_client_impl.h
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/services/viz/public/interfaces/BUILD.gn
[add] https://crrev.com/e71b8ec84c640da708cea03e939f5ac3ceba6b00/services/viz/public/interfaces/hit_test/input_target_client.mojom

Status: Fixed (was: Started)

Sign in to add a comment