Some InfoBars are leaked. |
||
Issue descriptionA retain cycle causes some infobars to be leaked. Example of leak in the attached screenshot.
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db9fc12b563cc860af67e91a571c262afcef72f8 commit db9fc12b563cc860af67e91a571c262afcef72f8 Author: jif <jif@chromium.org> Date: Mon Jun 12 14:50:46 2017 [iOS] Break retain cycle in InfoBars. This CLs breaks retain cycles such as: InfoBarView -> LabelLinkController -> BeforeTranslateInfoBarController -> InfoBarView BUG= 732384 Review-Url: https://codereview.chromium.org/2933833002 Cr-Commit-Position: refs/heads/master@{#478618} [modify] https://crrev.com/db9fc12b563cc860af67e91a571c262afcef72f8/ios/chrome/browser/infobars/confirm_infobar_controller.mm [modify] https://crrev.com/db9fc12b563cc860af67e91a571c262afcef72f8/ios/chrome/browser/passwords/update_password_infobar_controller.mm [modify] https://crrev.com/db9fc12b563cc860af67e91a571c262afcef72f8/ios/chrome/browser/translate/before_translate_infobar_controller.mm
,
Jun 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by jif@chromium.org
, Jun 12 2017311 KB
311 KB View Download