Opening a New Incognito tab is not smooth. |
|||||
Issue descriptionApp Version: 60.0.3112.30 beta iOS Version: iOS 11 Device : iPhone6+ Steps to reproduce: 1. Launch chrome. 2. Send the app to background. 3. Double tap on home button and relaunch chrome. 4. Tap on Menu > New incognito tab. Observed results: Opening a New incognito tab is not smooth. Expected results: Opening a new incognito tab should be smooth. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): iOS 11 issue Bug reproducible on the current beta channel build (App Version, iOS Version): iOS 11 issue Link to : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpcDBMVGtlU2Qzajg/view?usp=sharing
,
Jul 21 2017
I can't reproduce this in beta 3. Can you still repro this?
,
Nov 29 2017
Issue 789410 has been merged into this issue.
,
Nov 29 2017
Friendly ping? See crbug/789410, I can reproduce this with iPhone X running 11.1.2 (15B202) on Chrome 62.0.3202.70.
,
Nov 29 2017
,
Nov 29 2017
Why reduce to Pri-3? This looks pretty poor and unpolished :-(
,
Nov 30 2017
Whatever solution is used for pulling the toolbar out of the NTP with new fullscreen/new toolbar I assume will require updating the new tab animation, and probably resolve this bug as well. gambard@/sczs@ Does that seem accurate?
,
Nov 30 2017
The new toolbar will replace the WebToolbar. The NTP/StackView toolbars will stay the same. And we don't plan to change the new tab animation as it is not related to the toolbar specifically.
,
Nov 30 2017
So what would be the next steps for this bug specifically?
,
Nov 30 2017
Properly animating in the toolbar is a larger fix that's more long term. However, there's a simpler fix to make sure we at least keep the background the same (no black->grey) switch: https://chromium-review.googlesource.com/c/chromium/src/+/800731
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35b77300017be7905dc0a84ebb5c96aa21be909f commit 35b77300017be7905dc0a84ebb5c96aa21be909f Author: Justin Cohen <justincohen@google.com> Date: Thu Nov 30 16:13:34 2017 [ios] Fix integer truncation in NTP incognito animation. Bug: 732361 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If339db655f69d107f5b5978631e42a170b6c36ea Reviewed-on: https://chromium-review.googlesource.com/800731 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520558} [modify] https://crrev.com/35b77300017be7905dc0a84ebb5c96aa21be909f/ios/chrome/browser/ui/stack_view/page_animation_util.mm
,
Nov 30
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 3
This was filed for M60. Please file new bug against latest version if this is still an issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sczs@chromium.org
, Jun 14 2017Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)