New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732357 link

Starred by 18 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 729924



Sign in to add a comment

"Add to desktop" apps when pinned to Windows start menu get default chrome icon instead of the apps icon

Reported by san0...@gmail.com, Jun 12 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36

Steps to reproduce the problem:
1. "Add to desktop"
2. Right click the icon on desktop and "add to start"

What is the expected behavior?
The icon from the webapp is picked, same as the icon shown on desktop

What went wrong?
The icon is instead the default chrome one

Did this work before? N/A 

Chrome version: 59.0.3071.86  Channel: stable
OS Version: 10.0
Flash Version:
 
Chrome_start.PNG
5.0 KB View Download

Comment 1 by san0...@gmail.com, Jun 12 2017

Current workaround is to delete the 'chrome.VisualElementsManifest.xml' file at chrome root and then refresh the icon (by selecting the same icon again from the properties of the icon file). Also then on - new icons get pinned as expected with proper icon.
 Issue 732356  has been merged into this issue.
Cc: pbomm...@chromium.org mgiuca@chromium.org
Components: UI>Browser>AppShortcuts
Labels: pre-stable-59.0.3071.86 Needs-triage Needs-Bisect M-59
Status: Untriaged (was: Unconfirmed)

Comment 5 by mgiuca@chromium.org, Jun 13 2017

Cc: -mgiuca@chromium.org
Owner: mgiuca@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the report.

It looks like this is a new problem introduced in Windows 10 which we may not have control over (since it's an interaction with the Windows desktop icon and the Windows "add to start menu" flow). But we will have a look.
Blocking: 729924
Cc: benwells@chromium.org robertshield@chromium.org

Comment 7 by mgiuca@chromium.org, Jun 16 2017

Cc: calamity@chromium.org
Interesting.. one fix might be need to have these shortcuts point to a new exe that doesn't have a VisualElementsManfiest.xml. The exe would forward parameters to chrome.exe and exit. 
I can confirm that the workaround in #1 seems to work. Is there any negative effect to removing the xml file? What things does having that file do that the system default doesn't?
Labels: Needs-Feedback
Somehow I was unable to reproduce this issue using reported version #59.0.3071.86 and latest canary #61.0.3136.0. Could you please find the attched screen cast and let us know if we missed any steps while reproducing the issue.


Thanks!!
Jun 21 2017 12-15 AM.webm
8.1 MB View Download

Comment 11 by san0...@gmail.com, Jun 22 2017

@Sandeep Did you not find the "Amazon" icon in the end to have wrong (default) chrome icon in you "Start menu" after this?
Labels: -Needs-triage -M-59 -pre-stable-59.0.3071.86 M-62 Needs-Triage-M62
Can someone re-triage this issue in latest chrome version.

Adjusting the milestone.
Labels: -Needs-Bisect
Tested the issue using #61.0.3163.7 and #63.0.3204.0 on Win 7, 10. Observed the icon of PWA after selecting Pin to Taskbar, Pin to Start Menu options as per the steps mentioned below.

1. Launched Browser, navigate to amazon, or some webpages
2. Added to Home screen
3. Pinned to Taskbar, Pinned to Start menu as well
4. Observed the icon's of the respective PWA's

Removing bisect label for now, add it back if required.

Thanks!!
#13: Thanks for looking. So you could not reproduce it?
Components: UI>Browser>WebAppInstalls
I'm still able to reproduce this in the #68.0.3405.0 Canary build on Windows 10:

1. Navigate to YouTube.com
2. More Tools > Create Shortcut...
3. Shortcut creates on desktop with YouTube's icon.
4. Right-click, Pin to Start
5. Icon is the default Chrome Canary icon.

Deleting the chrome.VisualElementsManifest.xml does cause the YouTube icon to be used in a newly created shortcut in Start. However, it's displayed at a pretty small scale (see attachment).

Now, YouTube does not currently serve a Web App Manifest, so it's not technically a "PWA". It seems like Chrome could still use whatever icon is used in the desktop shortcut though.

screenshot.png
21.1 KB View Download
This bug is extremely annoying!! My windows 10 auto updated itself to the new release and all chrome app icons got reset and now display the bloody chrome icon instead of the actual icon.

The following link seems to have more information on this issue.
https://superuser.com/questions/1143974/how-to-get-chrome-favicons-to-appear-in-windows-10-start-menu

Unfortunately all my employees and customers who I have setup windows 10 machines for do not know how to use powershell and to navigate to this stuff!! I dont understand why this bug has not been fixed in the last couple of years!
Blocking: 851845
 Issue 803545  has been merged into this issue.
The dupe in comment 19 has workaround instructions. The code could probably just do what that workaround does.

I agree this is a pretty ugly bug. I pinned "Secure Shell App" to my start menu, and while the non-pinned start menu entry has the right icon, the pinned one has chrome's icon.
screenie.png
577 KB View Download
Labels: -Needs-Feedback -Arch-x86_64 -Via-Wizard-Other -M-62 -Needs-Triage-M62
Cc: mgiuca@chromium.org
Owner: alancutter@chromium.org
I think Alan is in this area at the moment. We should look into fixing this for Windows DPWA.
Blocking: -851845
Labels: M-70
Labels: -Pri-2 Pri-1
This has been noted on Twitter with M70 going to stable (https://twitter.com/webmaxru/status/1052306241794580480) and now has 12 stars. It's been a P1 since August.
Cc: phanindra.mandapaka@chromium.org
 Issue 896708  has been merged into this issue.
Although Chrome doesn't use the desktop bridge, could it use these APIs to make a secondary tile in the start menu for pinned sites/apps: https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/secondary-tiles-desktop-pinning
Cc: robliao@chromium.org
+robliao who may know if it's possible to use the SecondaryTile API from Chrome.
Just rounding other here for completeness, as documented, the SecondaryTile API appears to require Desktop Bridge, likely to provide an application identity. Chrome will be unable to use Desktop Bridge for the foreseeable future.
Screenshot of chrome_proxy.exe upgrade state.
new-chrome-proxy.png
19.2 KB View Download
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d4576ad4644c9a41e7801d635d3894a2f783ed2

commit 6d4576ad4644c9a41e7801d635d3894a2f783ed2
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Nov 30 00:41:26 2018

Add chrome_proxy.exe target for bookmark app shortcuts to target on Windows

This change adds a new executable to Windows called chrome_proxy.exe which
opens chrome.exe with all arguments forwarded.

The purpose of the executable is for bookmark app shortcuts to target so
they don't pick up the chrome.VisualElementsManifest.xml file when pinned
to the Windows 10 start menu. This fixes a bug where pinned bookmark app
shortcuts all use the Chrome logo instead of their own.

Bug:  732357 
Change-Id: I6f4385219329e6d6e446053fc1325082ce4328c6
Reviewed-on: https://chromium-review.googlesource.com/c/1335075
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612477}
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/BUILD.gn
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/browser/web_applications/components/web_app_shortcut_win.cc
[add] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/BUILD.gn
[add] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/OWNERS
[add] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/chrome_proxy.ver
[add] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/chrome_proxy_main_win.cc
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/installer/setup/install_worker.h
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/installer/util/util_constants.cc
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/installer/util/util_constants.h
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/chrome_beta_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/chrome_canary_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/chrome_dev_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/chrome_multi_system_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/chrome_multi_user_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/chrome_system_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/chrome_user_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/previous_chrome_system_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/test/mini_installer/config/previous_chrome_user_installed.prop
[modify] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/tools/build/win/FILES.cfg

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a3c852f4b08efee3c2fa013c68d683bd1b893bc

commit 2a3c852f4b08efee3c2fa013c68d683bd1b893bc
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Nov 30 01:02:48 2018

Revert "Add chrome_proxy.exe target for bookmark app shortcuts to target on Windows"

This reverts commit 6d4576ad4644c9a41e7801d635d3894a2f783ed2.

Reason for revert:
On second thought this is too risky to land on branch day.
Also I want to land the new binary separately from the shortcuts pointing to it so we can make sure it deploys properly before irreversibly depending on it (it's difficult to update shortcuts).

Original change's description:
> Add chrome_proxy.exe target for bookmark app shortcuts to target on Windows
> 
> This change adds a new executable to Windows called chrome_proxy.exe which
> opens chrome.exe with all arguments forwarded.
> 
> The purpose of the executable is for bookmark app shortcuts to target so
> they don't pick up the chrome.VisualElementsManifest.xml file when pinned
> to the Windows 10 start menu. This fixes a bug where pinned bookmark app
> shortcuts all use the Chrome logo instead of their own.
> 
> Bug:  732357 
> Change-Id: I6f4385219329e6d6e446053fc1325082ce4328c6
> Reviewed-on: https://chromium-review.googlesource.com/c/1335075
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612477}

TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org

Change-Id: If327a489864c0bd6066ec13b3f9421f3be57636b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  732357 
Reviewed-on: https://chromium-review.googlesource.com/c/1356163
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612478}
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/BUILD.gn
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/browser/web_applications/components/web_app_shortcut_win.cc
[delete] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/BUILD.gn
[delete] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/OWNERS
[delete] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/chrome_proxy.ver
[delete] https://crrev.com/6d4576ad4644c9a41e7801d635d3894a2f783ed2/chrome/chrome_proxy/chrome_proxy_main_win.cc
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/installer/setup/install_worker.h
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/installer/util/util_constants.cc
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/installer/util/util_constants.h
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/chrome_beta_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/chrome_canary_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/chrome_dev_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/chrome_multi_system_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/chrome_multi_user_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/chrome_system_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/chrome_user_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/previous_chrome_system_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/test/mini_installer/config/previous_chrome_user_installed.prop
[modify] https://crrev.com/2a3c852f4b08efee3c2fa013c68d683bd1b893bc/chrome/tools/build/win/FILES.cfg

Screenshots for WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1362696
before.png
279 KB View Download
after.png
278 KB View Download
Project Member

Comment 34 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86e7ed69a96f03ffcbb6af63d632f7951bf34b28

commit 86e7ed69a96f03ffcbb6af63d632f7951bf34b28
Author: Alan Cutter <alancutter@chromium.org>
Date: Wed Dec 05 23:34:36 2018

Add chrome_proxy.exe target on Windows

This change adds a new executable to Windows called chrome_proxy.exe which
opens chrome.exe with all arguments forwarded.

In a future patch bookmark app shortcuts will be updated to point to
chrome_proxy.exe instead of chrome.exe so they don't pick up the
chrome.VisualElementsManifest.xml file when pinned to the Windows 10
start menu. This fixes a bug where pinned bookmark app shortcuts all
use the Chrome logo instead of their own.

Bug:  732357 
Change-Id: I551093f6f111041b424d30ec3f829fa6a06a265c
Reviewed-on: https://chromium-review.googlesource.com/c/1362695
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614177}
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/BUILD.gn
[add] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/chrome_proxy/BUILD.gn
[add] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/chrome_proxy/OWNERS
[add] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/chrome_proxy/chrome_proxy.ver
[add] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/chrome_proxy/chrome_proxy_main_win.cc
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/installer/setup/install_worker.h
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/installer/util/util_constants.cc
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/installer/util/util_constants.h
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/chrome_beta_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/chrome_canary_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/chrome_dev_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/chrome_multi_system_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/chrome_multi_user_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/chrome_system_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/chrome_user_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/previous_chrome_system_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/test/mini_installer/config/previous_chrome_user_installed.prop
[modify] https://crrev.com/86e7ed69a96f03ffcbb6af63d632f7951bf34b28/chrome/tools/build/win/FILES.cfg

Project Member

Comment 35 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0edcdf14a29397ba43d8e303bcf01f04705ed95e

commit 0edcdf14a29397ba43d8e303bcf01f04705ed95e
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Dec 07 07:03:46 2018

Revert "Add chrome_proxy.exe target on Windows"

This reverts commit 86e7ed69a96f03ffcbb6af63d632f7951bf34b28.

Reason for revert: Broke Chrome Canary update while the browser is open.
Bug: 912716

Original change's description:
> Add chrome_proxy.exe target on Windows
>
> This change adds a new executable to Windows called chrome_proxy.exe which
> opens chrome.exe with all arguments forwarded.
>
> In a future patch bookmark app shortcuts will be updated to point to
> chrome_proxy.exe instead of chrome.exe so they don't pick up the
> chrome.VisualElementsManifest.xml file when pinned to the Windows 10
> start menu. This fixes a bug where pinned bookmark app shortcuts all
> use the Chrome logo instead of their own.
>
> Bug:  732357 
> Change-Id: I551093f6f111041b424d30ec3f829fa6a06a265c
> Reviewed-on: https://chromium-review.googlesource.com/c/1362695
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614177}

TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.
NOPRESUBMIT=TRUE # TBR doesn't apply because this revert touches an OWNERS file.

Bug:  732357 
Change-Id: I73cddef3173e3abc22f8c8c4720d84f9a9069ab1
Reviewed-on: https://chromium-review.googlesource.com/c/1366471
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614632}
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/BUILD.gn
[delete] https://crrev.com/1c1992d02fa89792498f5e3533772bd65d93973d/chrome/chrome_proxy/BUILD.gn
[delete] https://crrev.com/1c1992d02fa89792498f5e3533772bd65d93973d/chrome/chrome_proxy/OWNERS
[delete] https://crrev.com/1c1992d02fa89792498f5e3533772bd65d93973d/chrome/chrome_proxy/chrome_proxy.ver
[delete] https://crrev.com/1c1992d02fa89792498f5e3533772bd65d93973d/chrome/chrome_proxy/chrome_proxy_main_win.cc
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/installer/setup/install_worker.h
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/installer/util/util_constants.cc
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/installer/util/util_constants.h
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/chrome_beta_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/chrome_canary_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/chrome_dev_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/chrome_multi_system_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/chrome_multi_user_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/chrome_system_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/chrome_user_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/previous_chrome_system_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/test/mini_installer/config/previous_chrome_user_installed.prop
[modify] https://crrev.com/0edcdf14a29397ba43d8e303bcf01f04705ed95e/chrome/tools/build/win/FILES.cfg

Project Member

Comment 36 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e598d8a77cf9466ea3116c852039080ab3d1a69

commit 9e598d8a77cf9466ea3116c852039080ab3d1a69
Author: Alan Cutter <alancutter@chromium.org>
Date: Wed Dec 12 06:42:58 2018

Add chrome_proxy.exe target on Windows

This change adds a new executable to Windows called chrome_proxy.exe which
opens chrome.exe with all arguments forwarded.

In a future patch bookmark app shortcuts will be updated to point to
chrome_proxy.exe instead of chrome.exe so they don't pick up the
chrome.VisualElementsManifest.xml file when pinned to the Windows 10
start menu. This fixes a bug where pinned bookmark app shortcuts all
use the Chrome logo instead of their own.

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1362695
with the rename logic to account for chrome_proxy.exe not existing.
Diff: https://chromium-review.googlesource.com/c/chromium/src/+/1367385/1..2

Bug:  732357 
Change-Id: If670aaec69532aa7f2d8094470aabac716aa8035
Reviewed-on: https://chromium-review.googlesource.com/c/1367385
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615824}
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/BUILD.gn
[add] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/chrome_proxy/BUILD.gn
[add] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/chrome_proxy/OWNERS
[add] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/chrome_proxy/chrome_proxy.ver
[add] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/chrome_proxy/chrome_proxy_main_win.cc
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/installer/setup/install_worker.h
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/installer/util/util_constants.cc
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/installer/util/util_constants.h
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/chrome_beta_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/chrome_canary_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/chrome_dev_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/chrome_multi_system_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/chrome_multi_user_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/chrome_system_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/chrome_user_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/previous_chrome_system_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/test/mini_installer/config/previous_chrome_user_installed.prop
[modify] https://crrev.com/9e598d8a77cf9466ea3116c852039080ab3d1a69/chrome/tools/build/win/FILES.cfg

Project Member

Comment 37 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/988b2b1b2511a464ff3164913ff1fcd3743d48d7

commit 988b2b1b2511a464ff3164913ff1fcd3743d48d7
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Jan 10 04:44:13 2019

Make bookmark app shortcuts target chrome_proxy.exe on Windows

This CL updates the bookmark app shortcut creation code to target
chrome_proxy.exe instead of chrome.exe. chrome_proxy.exe just opens
chrome.exe with all arguments forwarded and is behaviourally equivalent.

The primary difference is chrome_proxy.exe isn't associated with the
chrome.VisualElementsManifest.xml file. This fixes a bug where pinned
bookmark app shortcuts all use the Chrome logo instead of their own.

Bug:  732357 
Change-Id: I70365619d79922de85218a775e8e6dbb9eb81b1d
Reviewed-on: https://chromium-review.googlesource.com/c/1379597
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621464}
[modify] https://crrev.com/988b2b1b2511a464ff3164913ff1fcd3743d48d7/chrome/browser/web_applications/components/web_app_shortcut_win.cc

Comment 38 by alancutter@chromium.org, Jan 15 (3 days ago)

Status: Fixed (was: Assigned)
Verified this is fixed for new shortcuts on Windows 10 Chrome canary 73.0.3672.0.

Comment 39 by benwells@chromium.org, Jan 16 (3 days ago)

Yay, this is awesome. Great stuff Alan!

Comment 40 by alancutter@chromium.org, Jan 16 (3 days ago)

Screenshot of fix working because I like screenshots.
pinned-icon.png
207 KB View Download

Sign in to add a comment