V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls failing on chromium.webrtc (Linux) |
||||||||||||
Issue description@@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (run #1):@@@ @@@STEP_LINK@logdog-->V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webrtc%2FLinux_Tester%2F29945%2F%2B%2Frecipes%2Fsteps%2Fcapture_unittests%2F0%2Flogs%2FV4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls%2F0@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ RUN ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@../../media/capture/video/linux/v4l2_capture_delegate_unittest.cc:169: Failure@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Expected: range.default_value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 100@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@To be equal to: current.value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 101@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ FAILED ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (534 ms)@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (run #2):@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ RUN ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@../../media/capture/video/linux/v4l2_capture_delegate_unittest.cc:169: Failure@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Expected: range.default_value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 100@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@To be equal to: current.value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 101@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ FAILED ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (464 ms)@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (run #3):@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ RUN ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@../../media/capture/video/linux/v4l2_capture_delegate_unittest.cc:169: Failure@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Expected: range.default_value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 100@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@To be equal to: current.value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 101@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ FAILED ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (597 ms)@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (run #4):@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ RUN ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@../../media/capture/video/linux/v4l2_capture_delegate_unittest.cc:169: Failure@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Expected: range.default_value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 100@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@To be equal to: current.value@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@ Which is: 101@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@[ FAILED ] V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls (579 ms)@@@ @@@STEP_LOG_LINE@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@@ @@@STEP_LOG_END@V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls@@@ First failing build https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/29945
,
Jun 12 2017
horo@ you seem to be the last who touched the code in this area before the failure - could you PTAL?
,
Jun 12 2017
,
Jun 12 2017
VideoCaptureCamera2.java is executed in Linux?
,
Jun 12 2017
No idea. The only thing I know is the test is being executed and failing.
,
Jun 12 2017
olka@ What is "the code in this area" that I touched?
,
Jun 12 2017
The latest commit in //media/capture/ is yours. Sorry, I don't have any vague knowledge of this area. I assume that probably you do. Let me know if I'm wrong.
,
Jun 12 2017
posciak@ PTAL as an owner of the code.
,
Jun 12 2017
IIUC https://codereview.chromium.org/2904503002/ should have skipped verifying the zoom control like it's done in [1]. Adding such an early bail-out condition in l.160 should do the trick. tovep@ can you take this up please? [1] https://cs.chromium.org/chromium/src/media/capture/video/linux/v4l2_capture_delegate_unittest.cc?type=cs&q=CreateAndDestroyAndVerifyControls&sq=package:chromium&l=138
,
Jun 13 2017
Raising the priority: Linux tester on chromium.webrtc is constantly failing (https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester?numbuilds=200) tovep@ could you address the issue ASAP or revert the CL from #9 (it landed 2 weeks ago so I'm not risking to revert it myself)
,
Jun 13 2017
On chromium.webrtc.fyi besides V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls these tests are failing: VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/0 VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/1 VideoCaptureDeviceTest.CaptureMjpeg VideoCaptureDeviceTest.GetPhotoCapabilities VideoCaptureDeviceTest.TakePhoto First failing build https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Tester/builds/37088 (empty blamelist)
,
Jun 13 2017
I'm looking into it now.
,
Jun 13 2017
I have investigated the sudden breakage of V4L2CaptureDelegateTest at 9th of June, and I have a hard time seeing why it broke 10 days after I submitted my changes, and even if it has anything to do with my changes. I have not been able to run this test successfully on my local machine. Without a camera attached the test is skipped but with a camera it fails with or without my changes. If anyone has a suggestion on how to run it locally, I would be interested in hearing how to do that. I have made the change Miguel suggested in https://bugs.chromium.org/p/chromium/issues/detail?id=732355#c9 and uploaded the CL here: https://chromium-review.googlesource.com/c/533833/. All try job tests have run successfully (except mac/win_chromium_rel_ng that are still running), but perhaps this test is skipped there too? I will set Miguel as a reviewer for the CL if he wants to accept it. Otherwise I think it is fine to revert my old change, https://codereview.chromium.org/2904503002/, from the master branch, and I'll try to sort things out. (I can do that if you think that is the right thing to do here). Note, this change has also been backported to M60 and M59, but I'm a bit wary of urgently backport the new change or reverting the old one before we know better what has happened here.
,
Jun 13 2017
tovep@: I landed recently a CL that added a test manipulating the zoom level [1], i.e.: read the zoom level, write it back +1 and read it back. This new test should not affect the current test because we decided a while ago to skip the zoom reset-testing in V4L2CaptureDelegateTest, hence my comment in #9 that we should just skip testing the zoom-reset here (in V4L2CaptureDelegateTest). [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_image_capture_browsertest.cc?q=webrtc_image_capture_browsertest.cc&sq=package:chromium&dr&l=148
,
Jun 14 2017
This one? Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri Jun 9 18:42:13 2017 -0700 Image Capture: reenable disabled android content_browsertests Are you planning to backport this change to any earlier release? Otherwise I guess we can leave M59 and M60 as is, because there should be no problem with this test there?
,
Jun 14 2017
#15: this one: https://chromium.googlesource.com/chromium/src/+/8214bacc307012249e0628661907781214e1c8e1 Image Capture: add more content_browsertests This CL adds 3 new tests to image capture's content_browsertests: [...] - ManipulateZoom retrieves the capabilities and, if zoom is supported (it is, at least, when using the fake device), then it tries to configure it to current_zoom + zoom_step, then reads back the value and sees if it coincides. FTR I see olka@ has decided to disable the test (https://crrev.com//2940863002/)
,
Jun 14 2017
Yes, we are unable to run the test without failures even for versions that are supposedly working, so we can't really verify if a change fixes the problem or not. It would be extremely helpful if you could tell us how we run this test locally.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f3e3298635a5c9cefbacbc2d5647e6ba804868a commit 2f3e3298635a5c9cefbacbc2d5647e6ba804868a Author: olka <olka@chromium.org> Date: Wed Jun 14 16:35:18 2017 Disabling V4L2CaptureDelegateTest.CreateAndDestroyAndVerifyControls on Linux BUG= 732355 TBR=posciak@chromium.org Review-Url: https://codereview.chromium.org/2940863002 Cr-Commit-Position: refs/heads/master@{#479415} [modify] https://crrev.com/2f3e3298635a5c9cefbacbc2d5647e6ba804868a/media/capture/video/linux/v4l2_capture_delegate_unittest.cc
,
Jun 15 2017
This is likely related to crbug/733640
,
Jun 15 2017
I have no way of verifying if my CL, [1], based on your suggestion above, actually fixes the problem so I assign this case over to you Miguel. [1] https://chromium-review.googlesource.com/c/533833/
,
Jun 19 2017
Bot is green now.
,
Jun 19 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by olka@chromium.org
, Jun 12 2017