Issue metadata
Sign in to add a comment
|
Regression: Pixels are corrupted in help and NTP pages |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3112.30 OS: Ubuntu 14.04 Pre-Condition: Enable GPU rasterization flag from chrome://flags What steps will reproduce the problem? (1)Launch chrome and enable above flag >> Go to NTP or hit F1 and check font Expected: Font should be clear and readable. Actual: Instead weird font is seen. This is a regression issue broken in M60. Good Build: 60.0.3104.0 dev Bad Build: 60.0.3105.0 dev NOTE: Issue is not seen on windows.
,
Jun 12 2017
Unable to reproduce this issue on Mac OS 10.12 using chrome dev #60.0.3112.30. Observed similar behavior on Ubuntu 14.04 as well. This issue might be specific to GPU. Sindhu@ Please provide bisect information.
,
Jun 12 2017
This issue is seen for many pages, Compose button of Gmail , Account info page etc.. You are probably looking for a change made after 473360 (known good), but no later than 473367 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/cdcd0b7cbe1630435abab4a03ca0543752138b56..e9cc6305714c1a585bc5cf51d289fdf000070ea0 Suspecting https://skia.googlesource.com/skia.git/+/d547fb602d3fd970882c3fa39464ec48bc6c4d5d from skia roll @egdaniel:Please confirm the issue and help in re-assigning if it is not related to your change.
,
Jun 12 2017
Attaching chrome://gpu of system where it reproduces..
,
Jun 12 2017
The attached chrome_gpu says rasterization is using software. When the bug occurs is this the case or did you just have gpu-rasterization disabled when you took the screen shot?
,
Jun 12 2017
Also this does not repo on ubuntu with nvidia gpu. I'll have to find an ubuntu machine with intel gpu to build chrome on and test there.
,
Jun 12 2017
Greg, just noting that the Skia revision in use is from the M60 branch, here: https://skia.googlesource.com/skia/+/chrome/m60
,
Jun 13 2017
With responce to comment#4: Attached wrong GPU. Now attaching GPU details when GPU Rasterization is enabled. Issue is seen in some more places like print preview [buttons,links] as well.
,
Jun 13 2017
Just to make sure we're tracking down the right thing - GPU rasterization is disabled on Linux by default - sc00335628@, had you enabled GPU rasterization yourself? Not saying we shouldn't treat this as high priority - we plan to turn GPU raster on for Linux soon - but just want to make sure this doesn't happen with SW raster as well.
,
Jun 13 2017
So I tried repoing the bug on Fedora with an Intel GPU, but I was not able to repo the bug. My driver is newer than the one reported here (13.0.2 vs 11.0.2) which may be the cause. Since I haven't been able to actual get this to repo I can't claim whether or not this a specific hardware issue, a driver issue, OS issue, or bug in Skia. However, I did put together a CL (https://skia-review.googlesource.com/c/19703/), which should get us a least back to where we were before m60. sc00335628@ can you try patching in that change and see if it fixes the bug?
,
Jun 14 2017
With respect to comment#9: Yes i enabled GPU Rasterization from chrome://flags
,
Jun 14 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/b54bdef86eb5cf63b94588afaa9197f49374a5f5 commit b54bdef86eb5cf63b94588afaa9197f49374a5f5 Author: Greg Daniel <egdaniel@google.com> Date: Wed Jun 14 15:13:58 2017 Go back to using dual source blending for lcd src-over even with non-opaque color This is change is currently still safe since earlier in Skia we are still requiring the dst to be opaque. The change is a workaround to spots where trying to read the dst to do in shader blending is failing for some reason. This also should give back a little performance since doing dual source blending should be better than shader blends. Bug: chromium:732341 Change-Id: I795f8a520f87f3fbf5d63a9509fbd9f394ea2b29 Reviewed-on: https://skia-review.googlesource.com/19703 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/b54bdef86eb5cf63b94588afaa9197f49374a5f5/src/gpu/effects/GrPorterDuffXferProcessor.cpp [modify] https://crrev.com/b54bdef86eb5cf63b94588afaa9197f49374a5f5/tests/GrPorterDuffTest.cpp
,
Jun 14 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/7d6fe0b9964d139de64ca88c46d87eba41c7f84e commit 7d6fe0b9964d139de64ca88c46d87eba41c7f84e Author: Greg Daniel <egdaniel@google.com> Date: Wed Jun 14 15:55:50 2017 Revert "Go back to using dual source blending for lcd src-over even with non-opaque color" This reverts commit b54bdef86eb5cf63b94588afaa9197f49374a5f5. Reason for revert: breaking some bots Original change's description: > Go back to using dual source blending for lcd src-over even with non-opaque color > > This is change is currently still safe since earlier in Skia we are still requiring > the dst to be opaque. The change is a workaround to spots where trying to read the > dst to do in shader blending is failing for some reason. This also should give back > a little performance since doing dual source blending should be better than shader > blends. > > Bug: chromium:732341 > Change-Id: I795f8a520f87f3fbf5d63a9509fbd9f394ea2b29 > Reviewed-on: https://skia-review.googlesource.com/19703 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: Ibb9bc1ef4ec5967dabcd62c81f62c0989c14fbb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:732341 Reviewed-on: https://skia-review.googlesource.com/19815 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/7d6fe0b9964d139de64ca88c46d87eba41c7f84e/src/gpu/effects/GrPorterDuffXferProcessor.cpp [modify] https://crrev.com/7d6fe0b9964d139de64ca88c46d87eba41c7f84e/tests/GrPorterDuffTest.cpp
,
Jun 14 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/d7b1159d787de27d75032ec213903a03962ec839 commit d7b1159d787de27d75032ec213903a03962ec839 Author: Greg Daniel <egdaniel@google.com> Date: Wed Jun 14 18:40:25 2017 Revert "Revert "Go back to using dual source blending for lcd src-over even with non-opaque color"" This reverts commit 7d6fe0b9964d139de64ca88c46d87eba41c7f84e. Reason for revert: Relanding with fix Original change's description: > Revert "Go back to using dual source blending for lcd src-over even with non-opaque color" > > This reverts commit b54bdef86eb5cf63b94588afaa9197f49374a5f5. > > Reason for revert: breaking some bots > Original change's description: > > Go back to using dual source blending for lcd src-over even with non-opaque color > > > > This is change is currently still safe since earlier in Skia we are still requiring > > the dst to be opaque. The change is a workaround to spots where trying to read the > > dst to do in shader blending is failing for some reason. This also should give back > > a little performance since doing dual source blending should be better than shader > > blends. > > > > Bug: chromium:732341 > > Change-Id: I795f8a520f87f3fbf5d63a9509fbd9f394ea2b29 > > Reviewed-on: https://skia-review.googlesource.com/19703 > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com > > Change-Id: Ibb9bc1ef4ec5967dabcd62c81f62c0989c14fbb8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:732341 > Reviewed-on: https://skia-review.googlesource.com/19815 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com Bug: chromium:732341 Change-Id: I7481755a9aa64364371d8149af4458fc2c15c8aa Reviewed-on: https://skia-review.googlesource.com/19840 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/d7b1159d787de27d75032ec213903a03962ec839/src/gpu/effects/GrPorterDuffXferProcessor.cpp [modify] https://crrev.com/d7b1159d787de27d75032ec213903a03962ec839/tests/GrPorterDuffTest.cpp
,
Jun 29 2017
Should be fixed on ToT.
,
Jul 11 2017
Do we need a merge to M60 here? I'm seeing the issue on the beta channel.
,
Jul 11 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 11 2017
Approving merge to M60.
,
Jul 12 2017
So just want to double check before we Merge to M60. From what was described in the bug this is an issue on just Linux with GPU rasterization enabled. AFAIK we don't default to GPU on Linux so a user would manually have to switch it. If this is the case do we still want to cherry pick?
,
Jul 17 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 17 2017
Thanks Greg, I hadn't realized this is Linux/GPU-only. If that's the case, then I agree -- the m60 merge is not high priority. I'd say we should only merge if there aren't conflicts and the change is low-risk.
,
Jul 18 2017
Thanks for more information - I think per comment 19 and 21, let's wait until M61.
,
Aug 2 2017
,
Aug 17 2017
,
Aug 17 2017
Issue 750494 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bsalo...@google.com
, Jun 12 2017