Issue metadata
Sign in to add a comment
|
Regression: Focus Ring for 'System security setting' text is exceeding in EULA screen |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3112.26/9592.15.0 beta channel Kip,Paine,Minnie,Daisy and Peppy OS: Chrome What steps will reproduce the problem? (1)Recover build -> In OOBE screen click on "Let's go" > In 'Connect to Network' screen Connect to any Wi-Fi network (2)Now in EULA screen press 'Tab' button until focus reaches to 'System security setting' (3)Now Observe Blue focus ring on 'System security setting' (Please refer screenshot) Expected: Blue Focus Ring should be around 'System security setting' text i.e. focus should not exceed the text Actual: Instead Focus Ring for 'System security setting' text is exceeding This is Regression Issue as same is working fine for 57.0.2987.146/9202.64.2 Candy @alemate : Please confirm the issue Note: 1.Issue is seen in M-58, M-59 and in latest M-61 also 2.Issue is not applicable to Linux,Windows OS
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2c6e0a1055c560d6c29d99b119ff95aacd93e60 commit c2c6e0a1055c560d6c29d99b119ff95aacd93e60 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Jul 21 23:23:32 2017 Chrome OS: Adjust size of a hyperlink on the EULA screen. This CL makes keyboard focus highlighting match the text size of a hyperlink on the EULA screen. Bug: 732324 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifbfed41f7c52e0089d780917a5431638a92d9476 Reviewed-on: https://chromium-review.googlesource.com/580431 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488786} [modify] https://crrev.com/c2c6e0a1055c560d6c29d99b119ff95aacd93e60/chrome/browser/resources/chromeos/login/oobe_eula.css
,
Jul 21 2017
,
Jul 24 2017
,
Jul 25 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d36e48f3e87c168118304627e948e0f1a6fad8a1 commit d36e48f3e87c168118304627e948e0f1a6fad8a1 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Jul 26 03:05:18 2017 Chrome OS: Adjust size of a hyperlink on the EULA screen. This CL makes keyboard focus highlighting match the text size of a hyperlink on the EULA screen. TBR=alemate@chromium.org (cherry picked from commit c2c6e0a1055c560d6c29d99b119ff95aacd93e60) Bug: 732324 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifbfed41f7c52e0089d780917a5431638a92d9476 Reviewed-on: https://chromium-review.googlesource.com/580431 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488786} Reviewed-on: https://chromium-review.googlesource.com/585898 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#50} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d36e48f3e87c168118304627e948e0f1a6fad8a1/chrome/browser/resources/chromeos/login/oobe_eula.css
,
Aug 9 2017
9765.21.0, 61.0.3163.38 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alemate@chromium.org
, Jul 21 2017