New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732310 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in memory.top_10_mobile at 476838:476890

Project Member Reported by alexclarke@chromium.org, Jun 12 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=732310

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg5uXz6QsM


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2017

Cc: chfremer@chromium.org
Owner: chfremer@chromium.org

=== Auto-CCing suspected CL author chfremer@chromium.org ===

Hi chfremer@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Christian Fremerey
  Commit : 177b9b934d8398dfb0d17b88fd9ff00f3291cca5
  Date   : Sat Jun 03 00:15:25 2017
  Subject: Fix copy-paste error in comment in sequence_checker.h

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:java_heap:effective_size_avg/background/after_https_mobile_twitter_com_justinbieber_skip_interstitial_true
  Change       : 0.03% | 17233355.4286 -> 17237738.8889

Revision             Result                   N
chromium@476837      17233355 +- 13047.9      14      good
chromium@476838      17162989 +- 5549.39      6       bad       <--
chromium@476839      17149912 +- 86416.7      6       bad
chromium@476840      17146929 +- 82385.6      6       bad
chromium@476842      17080190 +- 356844       6       bad
chromium@476852      17215960 +- 132025       14      bad
chromium@476864      17236587 +- 14689.1      14      bad
chromium@476890      17237739 +- 11830.9      9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977001781699430048

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5781760601751552


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
I don't understand the result numbers. Is this average memory usage during the test? It looks like it actually went down from 476837->476838.

In any case, the suspected Commit almost certainly did not cause any change to memory consumption, since all it did is changing a comment :-).

Owner: ----
Yep, this test is noisy and it did in fact pinpoint your CL for a memory decrease which was within the noise. I'm going to try to re-run the bisect.
Status: WontFix (was: Untriaged)
Actually this is just noise.

Sign in to add a comment