Issue metadata
Sign in to add a comment
|
11.6% regression in blink_perf.parser at 478516:478516 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 12 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8977002081453881120
,
Jun 12 2017
=== Auto-CCing suspected CL author magjed@chromium.org === Hi magjed@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : magjed Commit : 74bf3d028824e0cb58519bd18839490f89bf7ac1 Date : Sat Jun 10 16:49:34 2017 Subject: Update WebRtcVideoFrameAdapter to new buffer interface Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : blink_perf.parser Metric : query-selector-all-deep/query-selector-all-deep Change : 0.59% | 132.065414522 -> 131.290319259 Revision Result N chromium@478515 132.065 +- 2.14896 14 good chromium@478516 131.29 +- 2.16553 14 bad <-- To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.parser Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8977002081453881120 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5845618980814848 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Jul 28 2017
There is no way my CL caused this because the changed code is not even executed in the test.
,
Jul 28 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8972836283036919056
,
Jul 28 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8972822933334327104
,
Jul 28 2017
=== Auto-CCing suspected CL author thakis@chromium.org === Hi thakis@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : thakis Commit : f823f843f06636feb082521d76c282a16fe2d577 Date : Sat Jun 10 17:33:46 2017 Subject: android: switch from gcc to clang. Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : blink_perf.parser Metric : query-selector-all-deep/query-selector-all-deep Change : 14.54% | 138.525671263 -> 118.382416113 Revision Result N chromium@478100 138.526 +- 1.20441 6 good chromium@478310 129.93 +- 0.822288 6 good chromium@478415 135.912 +- 1.13549 6 good chromium@478468 133.414 +- 0.751841 6 good chromium@478494 133.741 +- 2.7027 6 good chromium@478507 131.459 +- 1.56243 6 good chromium@478514 136.862 +- 1.0365 6 good chromium@478516 134.197 +- 1.52302 6 good chromium@478517 112.297 +- 2.26117 6 bad <-- chromium@478520 118.382 +- 2.30558 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.parser More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8972836283036919056 For feedback, file a bug with component Speed>Bisection
,
Jul 28 2017
,
Jul 29 2017
=== Auto-CCing suspected CL author thakis@chromium.org === Hi thakis@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : thakis Commit : f823f843f06636feb082521d76c282a16fe2d577 Date : Sat Jun 10 17:33:46 2017 Subject: android: switch from gcc to clang. Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : blink_perf.parser Metric : query-selector-all-deep/query-selector-all-deep Change : 11.59% | 131.901848712 -> 116.617521043 Revision Result N chromium@478513 131.902 +- 2.06918 6 good chromium@478516 132.882 +- 3.23966 6 good chromium@478517 118.477 +- 0.870143 6 bad <-- chromium@478518 119.622 +- 1.13184 6 bad chromium@478519 115.818 +- 2.75183 6 bad chromium@478524 116.913 +- 0.625536 6 bad chromium@478535 116.618 +- 1.34041 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.parser More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8972822933334327104 For feedback, file a bug with component Speed>Bisection |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Jun 12 2017