New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732253 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add type mapping for media::BitstreamBuffer and JpegDecodeAccelerator::Error

Project Member Reported by c.pa...@samsung.com, Jun 12 2017

Issue description

Convert mojom::BitstreamBuffer to media::BitstreamBuffer and vice-versa using StructTraits. Similarly, add EnumTraits for JpegDecodeAccelerator::Error as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0edf32054bc4767088e835e9bc54ed61876bb331

commit 0edf32054bc4767088e835e9bc54ed61876bb331
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Thu Jun 29 02:48:06 2017

Define EnumTraits for JpegDecodeAccelerator::Error

This CL typemaps mojom::Error to JpegDecodeAccelerator::Error.
It is in preparation for migration of JPEG Decoder IPC to mojo
in https://chromium-review.googlesource.com/c/525672.

Bug:  732253 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If11caa673a42c41bfb937361095e174b046c6213
Reviewed-on: https://chromium-review.googlesource.com/544372
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483269}
[modify] https://crrev.com/0edf32054bc4767088e835e9bc54ed61876bb331/media/gpu/mojo/OWNERS
[modify] https://crrev.com/0edf32054bc4767088e835e9bc54ed61876bb331/media/gpu/mojo/jpeg_decoder.mojom
[add] https://crrev.com/0edf32054bc4767088e835e9bc54ed61876bb331/media/gpu/mojo/jpeg_decoder.typemap
[add] https://crrev.com/0edf32054bc4767088e835e9bc54ed61876bb331/media/gpu/mojo/jpeg_decoder_typemap_traits.cc
[add] https://crrev.com/0edf32054bc4767088e835e9bc54ed61876bb331/media/gpu/mojo/jpeg_decoder_typemap_traits.h
[add] https://crrev.com/0edf32054bc4767088e835e9bc54ed61876bb331/media/gpu/mojo/typemaps.gni
[modify] https://crrev.com/0edf32054bc4767088e835e9bc54ed61876bb331/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d92f0f004dbc7afb8fe78436b8caf9e98012f06c

commit d92f0f004dbc7afb8fe78436b8caf9e98012f06c
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Wed Jul 05 18:11:20 2017

Define StructTraits for media::BitstreamBuffer

This CL typemaps mojom::BitstreamBuffer to media::BitstreamBuffer.
It is in preparation for migration of JPEG Decoder IPC to mojo in
https://chromium-review.googlesource.com/c/525672.

Bug:  732253 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifeb6aa1ac61412bbb58d87b288b74dcdd883f138
Reviewed-on: https://chromium-review.googlesource.com/555470
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#484310}
[modify] https://crrev.com/d92f0f004dbc7afb8fe78436b8caf9e98012f06c/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc
[modify] https://crrev.com/d92f0f004dbc7afb8fe78436b8caf9e98012f06c/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h
[add] https://crrev.com/d92f0f004dbc7afb8fe78436b8caf9e98012f06c/media/gpu/mojo/DEPS
[modify] https://crrev.com/d92f0f004dbc7afb8fe78436b8caf9e98012f06c/media/gpu/mojo/jpeg_decoder.typemap
[modify] https://crrev.com/d92f0f004dbc7afb8fe78436b8caf9e98012f06c/media/gpu/mojo/jpeg_decoder_typemap_traits.cc
[modify] https://crrev.com/d92f0f004dbc7afb8fe78436b8caf9e98012f06c/media/gpu/mojo/jpeg_decoder_typemap_traits.h

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51afa76960fff2a82471ba84253a257f8f79553d

commit 51afa76960fff2a82471ba84253a257f8f79553d
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Wed Jul 12 18:18:58 2017

media: Use int64 as mojom equivalent type for off_t

This CL replaces uint64 with int64 as mojom type for off_t
in BitstreamBuffer mojom struct.

Bug:  732253 
Change-Id: Ie9434832c2556efd43ed7269a30dc49565ddf02c
Reviewed-on: https://chromium-review.googlesource.com/567908
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#486027}
[modify] https://crrev.com/51afa76960fff2a82471ba84253a257f8f79553d/media/gpu/mojo/jpeg_decoder.mojom
[modify] https://crrev.com/51afa76960fff2a82471ba84253a257f8f79553d/media/gpu/mojo/jpeg_decoder_typemap_traits.cc
[modify] https://crrev.com/51afa76960fff2a82471ba84253a257f8f79553d/media/gpu/mojo/jpeg_decoder_typemap_traits.h

Sign in to add a comment