Issue metadata
Sign in to add a comment
|
Regression: 'New Folder' text is not visible after hitting Space bar key at 'New Folder button' on bookmark overlay
Reported by
sans...@etouch.net,
Jun 12 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3112.30 (Official Build) 3c3a751adc7b297b98a09461f8df5caa1cf52e56-refs/branch-heads/3112@{#304}-32/64 bit OS: Mac (10.12.3,10.11.6) Pre-condition: Enable Material Design in the rest of the browser's native UI from chrome://flags Steps: 1. Launch Chrome, click on 'Star' icon of omnibox and click on Edit button of bookmark bubble 2. Now press tab key till focus reaches 'New Folder' button and then press Space bar key 3. Observe Actual: 'New Folder' text is not visible after hitting Space bar key at 'New Folder button' i.e Blank text field is seen. Expected: Blank field should not be seen i.e 'New Folder' text is should be visible after hitting Space bar key at 'New Folder button' This is regression issue broken in M-57, will soon update the bisect info. Good build: 57.0.2983.0 Bad build: 57.0.2984.0 Note: This issue works fine via mouse click and is not seen on Windows and Linux OS
,
Jun 12 2017
Hi Trent, can you take a look at this. Thanks!
,
Jun 12 2017
,
Jun 13 2017
Seems the event isn't being marked handled when it gets used to activate the button. Causes the space keypress to get sent to the input field.
,
Jul 4 2017
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a42d24fc97610d00ddf15722e14aa0f413e56561 commit a42d24fc97610d00ddf15722e14aa0f413e56561 Author: tapted <tapted@chromium.org> Date: Thu Jul 06 06:03:45 2017 MacViews: Don't InsertChar() for consumed events. Currently, BridgedContentView ignores KeyEvent::handled() when processing a key event both as a KeyDown and as text input. Handling should only proceed to text input when the event isn't handled after first being sent to OnKeyEvent handlers. Otherwise, it means a <space> on a control that causes a textfield to be focused will also send that space as input to the textfield. BUG= 732229 Review-Url: https://codereview.chromium.org/2973463002 Cr-Commit-Position: refs/heads/master@{#484475} [modify] https://crrev.com/a42d24fc97610d00ddf15722e14aa0f413e56561/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/a42d24fc97610d00ddf15722e14aa0f413e56561/ui/views/controls/textfield/textfield_unittest.cc
,
Jul 6 2017
,
Jul 11 2017
Note: Above issue is fixed on latest Canary version 61.0.3154.0
,
Jul 11 2017
Correction: Above issue is fixed on latest Dev version 61.0.3153.4 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sans...@etouch.net
, Jun 12 2017Owner: karandeepb@chromium.org
Status: Assigned (was: Unconfirmed)