New issue
Advanced search Search tips

Issue 732214 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use WTF::Time for FetchResponseData.response_time_.

Project Member Reported by horo@chromium.org, Jun 12 2017

Issue description

When I implemented this (https://codereview.chromium.org/1738723002), there was no way to keep the int64_t value of base::Time in Blink.

But after https://codereview.chromium.org/2543663002, we have WTF::Time.
So we should use WTF::Time in FetchResponseData.response_time_.

 

Comment 1 by horo@chromium.org, Jun 26 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a0f7a71f4e41854566138cf7b9920d486c45bf6

commit 0a0f7a71f4e41854566138cf7b9920d486c45bf6
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Mon Jun 26 13:57:39 2017

Use Time class for response time in Blink instead of int64.

After https://crrev.com/2543663002 we can use Time class in Blink.

BUG= 732214 

Change-Id: I6ef34fd8d342c7776c4fbe69837f727bedb131a1
Reviewed-on: https://chromium-review.googlesource.com/547820
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482260}
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/content/renderer/cache_storage/cache_storage_dispatcher.cc
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/content/renderer/service_worker/service_worker_type_util.cc
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/modules/fetch/FetchResponseData.h
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/Source/platform/loader/fetch/ResourceTest.cpp
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/public/platform/WebURLResponse.h
[modify] https://crrev.com/0a0f7a71f4e41854566138cf7b9920d486c45bf6/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

Comment 3 by horo@chromium.org, Jun 26 2017

Status: Fixed (was: Started)

Sign in to add a comment