New issue
Advanced search Search tips

Issue 732212 link

Starred by 0 users
Status: Fixed
Owner:
nhiroki@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Worklet: Reject w/ AbortError when module fetching is failed

Project Member Reported by nhiroki@chromium.org, Jun 12 2017 
In the current impl, it's rejected w/ NetworkError.

Spec: https://drafts.css-houdini.org/worklets/#fetch-and-invoke-a-worklet-script

3. If script is null, then queue a task on outsideSettings’s responsible event loop to run these steps:
 3.1. If pendingTaskStruct’s counter is not -1, then run these steps:
  3.1.1. Set pendingTaskStruct’s counter to -1.
  3.1.2. Reject promise with an "AbortError" DOMException.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1152a1ce4a45a9d2c97709f4cac931bb8028b33f

commit 1152a1ce4a45a9d2c97709f4cac931bb8028b33f
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Jun 12 10:14:35 2017

Worklet: Reject with an AbortError when module loading fails

In the current impl, it rejects w/ NetworkError. That should be AbortError
according to the spec.

Spec: https://drafts.css-houdini.org/worklets/#fetch-and-invoke-a-worklet-script

3. If script is null, then queue a task on outsideSettings’s responsible event
   loop to run these steps:
 3.1. If pendingTaskStruct’s counter is not -1, then run these steps:
  3.1.1. Set pendingTaskStruct’s counter to -1.
  3.1.2. Reject promise with an "AbortError" DOMException.

There are no wpt tests yet (see  issue 724907 )

Bug:  732212 
Change-Id: Idc352dd6555de8ef49108662deeb24202f76d667
Reviewed-on: https://chromium-review.googlesource.com/530447
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478576}
[modify] https://crrev.com/1152a1ce4a45a9d2c97709f4cac931bb8028b33f/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/worklet-import-blocked-expected.txt
[modify] https://crrev.com/1152a1ce4a45a9d2c97709f4cac931bb8028b33f/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/worklet-import-blocked.html
[modify] https://crrev.com/1152a1ce4a45a9d2c97709f4cac931bb8028b33f/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
[modify] https://crrev.com/1152a1ce4a45a9d2c97709f4cac931bb8028b33f/third_party/WebKit/Source/core/workers/WorkletPendingTasks.cpp

Comment 2 by nhiroki@chromium.org, Jun 12 2017

Labels: M-61
Status: Fixed (was: Started)
►

Sign in to add a comment