Issue metadata
Sign in to add a comment
|
Eject button is not accessible in Files app |
||||||||||||||||||||||||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) Enable ChromeVox (2) Open Files app (3) Connect any usb flash drive (4) Traverse with Search + Left or Right arrow keys (previous / next object) to move focus on the flash drive. (5) Listen the feedback. What is the expected result? Feedback should indicate that there is a eject button. Also it would be better if the eject button is accessible by Search + Arrow keys. What happens instead? No feedback about the existence of eject button. Additional information If I press Search + Down arrow key (next line) while the focus is on the flash drive, I could have accessed to the eject button.
,
Jun 12 2017
On previous canary (61.0.3123.0 / 9628.0.0) on chell device, it reproduced. On the latest canary (61.0.3127.0 / 9681.0.0) on link device, it did not reproduce. I also verified this by deploy_chrome-ing ToT e43c9f5c05c4d6a929907441388882a8f1795b46. Steps I took: (1) Select the USB drive by Search + Left or Right. (2) Search + Down & Search + Right properly goes to "Eject device." (3) Search + Space properly ejects the device.
,
Jun 12 2017
Did you get a feedback about the existence of eject button when you put focus on the USB drive at the step 1? IMHO, it would be better if user can get a feedback about it at least.
,
Jun 12 2017
Oh, sorry I missed the point. It only says "(Drive name) Tree item Collapsed n of m level 2" I try to add the feedback about the existence of eject button.
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22c0bf14345003e73ba13be78089d31f3e00bd9f commit 22c0bf14345003e73ba13be78089d31f3e00bd9f Author: tetsui <tetsui@chromium.org> Date: Tue Jun 13 10:28:18 2017 Add the feedback about the existnce of eject device button. In ChromeVox, it was hard to tell there is a eject device button in directory tree. It adds "Eject device" to aria-label of the tree item. BUG= 732202 TEST=manually with USB removable device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2933193004 Cr-Commit-Position: refs/heads/master@{#478957} [modify] https://crrev.com/22c0bf14345003e73ba13be78089d31f3e00bd9f/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
,
Jun 13 2017
Hi dtseng@ and dmazzoni@, I wonder if you would give me some advice on ChromeVox. Is it better that we can move to the eject button only using Search + Left / Right ? Or current implementation which also needs Search + Down sufficient? Also, I tried adding aria-flowto to the parent DOM node (directory tree item) but could not move to the child DOM node (eject button). Is there any solution for this? The eject button is in the tree item of the directory tree on the left side of files app. The tree item represents USB flash drive. Thank you for your help.
,
Jun 19 2017
In ChromeVox, now we can eject the device by keyboard, and also it feedbacks the existence of the button. But I also got a suggestion from Dominic about making the button tab focusable, which sounds better. I might look into this.
,
Jun 20 2017
We can't still select eject button only by Search + Left / Right, but now it's possible by Tab, and ChromeVox recognizes it as a button now. https://codereview.chromium.org/2944813002/
,
Jul 7 2017
verified on 61.0.3151.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Jun 12 2017Status: Assigned (was: Untriaged)