Issue metadata
Sign in to add a comment
|
Chrome lacks CSS names so it is very hard to style with GTK3 themes
Reported by
aykevanl...@gmail.com,
Jun 11 2017
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36
Steps to reproduce the problem:
1. Install Debian with the MATE desktop environment
2. Install Google Chrome
3. Enable the BlackMATE theme
What is the expected behavior?
Before the switch to GTK3[1] the URL bar was dark with light-colored text when using a dark theme like BlackMATE. See [2] for screenshots.
What went wrong?
With the recent switch to GTK3 [2] the URL bar and some other parts of Chrome are hard to read when using a theme like BlackMATE. See the attached file. They have now worked around it by making it light (which looks really ugly but is readable), but for a proper fix Chrome needs to add CSS names so Chrome can be specifically targeted in the theme. That way, we could, for example, use something like the following:
google-chrome textview.view,
google-chrome textview.view text {
background-color: @less_dark_color;
color: @theme_selected_fg_color;
}
But this is currently impossible.
Did this work before? Yes Chrome 58, with GTK2
Chrome version: 59.0.3071.86 Channel: stable
OS Version: Debian stretch
Flash Version:
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=79722#c110
[2] https://github.com/mate-desktop/mate-themes/issues/182
,
Jun 12 2017
I don't think this needs a bisect, it's pretty clear which change introduced the issue. The GTK3 UI is new (it has probably never worked in GTK3), but from the user POV it's a regression as it worked fine with GTK2.
,
Jun 13 2017
As per comment #2 removing the bisect label and adding appropriate component for further triage.
,
Jun 13 2017
,
Jun 13 2017
All widgets in Chrome already have the "chromium" style class applied to them. Would it better/more conventional to have a base widget with name/class "chromium" instead? Please see https://cs.chromium.org/chromium/src/docs/linux_gtk_theme_integration.md
,
Jun 13 2017
Thank you! We can target chromium using the style classes. I think the bug can be closed.
,
Jun 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Jun 12 2017