Parse and display the pushed content suggestions via GCM
Parse and display the content suggestions pushed via GCM
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/418d1a8bb6da708ec32b32dcc99bed41acac035f commit 418d1a8bb6da708ec32b32dcc99bed41acac035f Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Jun 12 15:18:06 2017 [NTP::Push] Extract JSON-to-Snippet in Helper Bug: 732161 Change-Id: I57dd0dd8029fd83fabdab063040fc5163059afc9 Reviewed-on: https://chromium-review.googlesource.com/530371 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#478626} [modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/BUILD.gn [add] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/json_to_categories.cc [add] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/json_to_categories.h [modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_fetcher.cc [modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_fetcher.h [modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc [modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_provider_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46f95bcb4effb1dcdf32ab3f760072240022cb81 commit 46f95bcb4effb1dcdf32ab3f760072240022cb81 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Tue Jun 13 13:20:37 2017 [NTP::Push] Parse pushed content suggestions Parse the JSON content suggestions pushed via GCM. Bug: 732161 Change-Id: Ic12cd8a2687983dc5e698a5a93e20ad6b27b5c43 Reviewed-on: https://chromium-review.googlesource.com/530305 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#478994} [modify] https://crrev.com/46f95bcb4effb1dcdf32ab3f760072240022cb81/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/46f95bcb4effb1dcdf32ab3f760072240022cb81/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.cc [modify] https://crrev.com/46f95bcb4effb1dcdf32ab3f760072240022cb81/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h [modify] https://crrev.com/46f95bcb4effb1dcdf32ab3f760072240022cb81/components/ntp_snippets/breaking_news/content_suggestions_gcm_app_handler.cc [modify] https://crrev.com/46f95bcb4effb1dcdf32ab3f760072240022cb81/components/ntp_snippets/breaking_news/content_suggestions_gcm_app_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4974fdaca1d45b1ac69d35f4dcbf093c4a2ef6c4 commit 4974fdaca1d45b1ac69d35f4dcbf093c4a2ef6c4 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Jun 14 15:14:34 2017 [NTP::Push] Display Breaking News Bug: 732161 Change-Id: I637be93290144ff06d96655bc788ad1c59cfa463 Reviewed-on: https://chromium-review.googlesource.com/531049 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#479387} [modify] https://crrev.com/4974fdaca1d45b1ac69d35f4dcbf093c4a2ef6c4/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/4974fdaca1d45b1ac69d35f4dcbf093c4a2ef6c4/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.cc [modify] https://crrev.com/4974fdaca1d45b1ac69d35f4dcbf093c4a2ef6c4/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa15e65a732bb7dc391030a03c08844395fd6eff commit aa15e65a732bb7dc391030a03c08844395fd6eff Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Jun 21 11:57:51 2017 [NTP::Push] Store breaking news in a database Bug: 732161 Change-Id: Ie27a334e30a537658dd3e579cc11c8f28ed3a83b Reviewed-on: https://chromium-review.googlesource.com/535562 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#481179} [modify] https://crrev.com/aa15e65a732bb7dc391030a03c08844395fd6eff/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/aa15e65a732bb7dc391030a03c08844395fd6eff/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.cc [modify] https://crrev.com/aa15e65a732bb7dc391030a03c08844395fd6eff/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h [modify] https://crrev.com/aa15e65a732bb7dc391030a03c08844395fd6eff/components/ntp_snippets/breaking_news/content_suggestions_gcm_app_handler.cc [modify] https://crrev.com/aa15e65a732bb7dc391030a03c08844395fd6eff/components/ntp_snippets/ntp_snippets_constants.cc [modify] https://crrev.com/aa15e65a732bb7dc391030a03c08844395fd6eff/components/ntp_snippets/ntp_snippets_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f3a9364c158989e394d45bb4da14e174f8b321b commit 6f3a9364c158989e394d45bb4da14e174f8b321b Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Jul 05 16:01:40 2017 [NTP::Push] Add BreakingNewsSuggestionsProvider unittest Bug: 732161 Change-Id: I75a83766b680d6892c80ef444b622f7ca91c5b92 Reviewed-on: https://chromium-review.googlesource.com/557860 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#484288} [modify] https://crrev.com/6f3a9364c158989e394d45bb4da14e174f8b321b/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/6f3a9364c158989e394d45bb4da14e174f8b321b/components/ntp_snippets/breaking_news/breaking_news_listener.h [modify] https://crrev.com/6f3a9364c158989e394d45bb4da14e174f8b321b/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h [add] https://crrev.com/6f3a9364c158989e394d45bb4da14e174f8b321b/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider_unittest.cc
Should this still be targeted at M61? Or is this complete?
It's M63 now.
This bug was basically done while merging the providers.
Comment 1 by mamir@chromium.org
, Jun 11 2017