New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 733243

Blocking:
issue 728080



Sign in to add a comment

[NTP::Push] Parse and display the pushed content suggestions

Project Member Reported by mamir@chromium.org, Jun 11 2017

Issue description

Parse and display the content suggestions pushed via GCM
 

Comment 1 by mamir@chromium.org, Jun 11 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/418d1a8bb6da708ec32b32dcc99bed41acac035f

commit 418d1a8bb6da708ec32b32dcc99bed41acac035f
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Mon Jun 12 15:18:06 2017

[NTP::Push] Extract JSON-to-Snippet in Helper



Bug:  732161 
Change-Id: I57dd0dd8029fd83fabdab063040fc5163059afc9
Reviewed-on: https://chromium-review.googlesource.com/530371
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478626}
[modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/BUILD.gn
[add] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/json_to_categories.cc
[add] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/json_to_categories.h
[modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
[modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_fetcher.h
[modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc
[modify] https://crrev.com/418d1a8bb6da708ec32b32dcc99bed41acac035f/components/ntp_snippets/remote/remote_suggestions_provider_impl.h

Comment 4 by mamir@chromium.org, Jun 14 2017

Blockedon: 733243
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2017

Comment 8 by fi...@chromium.org, Jul 21 2017

Labels: zine-triaged
Should this still be targeted at M61? Or is this complete?
Labels: -M-61 M-63
It's M63 now.
Status: Fixed (was: Started)
This bug was basically done while merging the providers.

Sign in to add a comment