New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 732089 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
cbiesin...@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Responsive video is sized incorrectly in flexbox row

Reported by johanrin...@gmail.com, Jun 11 2017 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce the problem:
1. Create an element with `display: flex`
2. Create a <video> with `width: 100%`
3. Insert the video into the flex parent
4. Make sure the width of the flex parent isn't equal to the width of the video source

What is the expected behavior?
The width of the video element is limited by the width of the container element, and the height is calculated based on the video source's aspect ratio.

What went wrong?
The height of the element is calculated as if though the video wasn't limited by the element's width - that is, it is always (almost?) equal to the height of the video source.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 58.0.3029.110  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

This only happens if the video has it's `width` set, is the child of a `display: flex` element, and the parent's `flex-direction` is set to `row` or `row-reverse`.

See JSFiddle: https://jsfiddle.net/fj82tgxo/
tmp.html
464 bytes View Download
tmp.png
647 KB View Download

Comment 1 by johanrin...@gmail.com, Jun 11 2017 

Note that this *does* work in Firefox (I must've missed the option to say that while creating the issue).

Comment 2 by ranjitkan@chromium.org, Jun 19 2017

Labels: Needs-Milestone

Comment 3 by msrchandra@chromium.org, Jun 22 2017

Cc: msrchandra@chromium.org
Components: Blink
Labels: -Needs-Milestone M-61 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Tested on Chrome Stable#59.0.3071.109, Canary#61.0.3137.0 on Windows 10, Mac and Linux and able to reproduce the issue.
 
Please find the bisect info below:
Chrome Good Build - 36.0.1948.0 (264759)
Chrome Bad Build - 36.0.1949.2 (264919) 

Per-revision bisect and hasbisect did not provide any possible suspects, so providing the CL manually.
 
Below is the CL: https://chromium.googlesource.com/chromium/src/+log/36.0.1948.0..36.0.1949.0?pretty=fuller&n=10000
 
Note: Chrome is getting crashed while performing the Per-revision bisect.

Thanks.

Comment 4 by bokan@chromium.org, Jun 22 2017

Components: -Blink Blink>Layout>Flexbox

Comment 5 by e...@chromium.org, Jun 26 2017

Cc: cbiesin...@chromium.org
Status: Available (was: Untriaged)
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 27 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by e...@chromium.org, Jun 28 2018

Status: Fixed (was: Untriaged)
This now appears to be working as expected.

Comment 8 by johanrin...@gmail.com, Aug 24 

Can still reproduce in Version 68.0.3440.106 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)

Issue is *not* fixed in said version.
►

Sign in to add a comment