Issue metadata
Sign in to add a comment
|
tools/determinism/remove_build_metadata.py should run as part of the build, not after it |
||||||||||||||||||||||||
Issue descriptionApparently tools/determinism/remove_buld_metadata.py currently runs on bots after a build and modifies build artifacts. That makes it hard to understand when this step breaks something, and modifying built artifacts in-place seems like it has other undesirable properties as well. Instead, this should run as part of a regular build, either during the link step, or the link step should write binaries to foo.pre.exe and then the determinism step should take the pre.exe and write the final .exe (if determinism is explicitly enabled, on platforms where this is needed.) This came up in issue 729059 .
,
Jul 11
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12
This is still useful for android, even if not for Windows anymore. Basically, this should be post-link step for android APKs.
,
Sep 10
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Jul 11 2017