New issue
Advanced search Search tips

Issue 732071 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 882231
Owner: ----
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

tools/determinism/remove_build_metadata.py should run as part of the build, not after it

Project Member Reported by thakis@chromium.org, Jun 10 2017

Issue description

Apparently tools/determinism/remove_buld_metadata.py currently runs on bots after a build and modifies build artifacts. That makes it hard to understand when this step breaks something, and modifying built artifacts in-place seems like it has other undesirable properties as well.

Instead, this should run as part of a regular build, either during the link step, or the link step should write binaries to foo.pre.exe and then the determinism step should take the pre.exe and write the final .exe (if determinism is explicitly enabled, on platforms where this is needed.)

This came up in  issue 729059 .
 
Labels: TE-NeedsTriageHelp
As it is build related issue,could someone from dev team please look into this issue.Adding 'TE-NeedsTriageHelp' label for further investigation.
Thanks.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 11

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -OS-All -TE-NeedsTriageHelp OS-Android
Status: Available (was: Archived)
This is still useful for android, even if not for Windows anymore. Basically, this should be post-link step for android APKs.
Mergedinto: 882231
Status: Duplicate (was: Available)
I ended up doing this in  issue 882231 .

Sign in to add a comment