New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 732067 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Vertically centered app list page switcher

Project Member Reported by weidongg@chromium.org, Jun 10 2017

Issue description

Change the app list page switcher from horizontally center to vertically center. This is one part of moving to full screen app list. So everything should be put behind the flag. And the change could only be seen by adding "--enable-features=EnableFullscreenAppList".

The changes should also follow specs: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZY5BZ8F2qhKy/files/MCEHZlh_v7QycCIjPTJ4GutdwMSJbxAVNpw
 
Description: Show this description
Cc: hejq@chromium.org vadimt@chromium.org newcomer@chromium.org warx@chromium.org
Components: UI>Shell>Launcher
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/997174a8a84df91727a37259fb5ee7ea6ee7e1a2

commit 997174a8a84df91727a37259fb5ee7ea6ee7e1a2
Author: weidongg <weidongg@chromium.org>
Date: Wed Jun 14 20:20:05 2017

Add new style to page switcher

1. Change button from slim rectangle to circle.
2. Apply different effect when the corresponding page of the button
   is selected.
3. Add ink drop ripple and highlight to the button, which are shown when clicked.

- screenshot:
https://screenshot.googleplex.com/jd3w9v2q5xm

BUG= 732067 

Review-Url: https://codereview.chromium.org/2942523002
Cr-Commit-Position: refs/heads/master@{#479487}

[modify] https://crrev.com/997174a8a84df91727a37259fb5ee7ea6ee7e1a2/ui/app_list/views/page_switcher_vertical.cc
[modify] https://crrev.com/997174a8a84df91727a37259fb5ee7ea6ee7e1a2/ui/app_list/views/page_switcher_vertical.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b7bd924b5d4c938a1df51270fa7bd74e632f66a

commit 4b7bd924b5d4c938a1df51270fa7bd74e632f66a
Author: weidongg <weidongg@chromium.org>
Date: Thu Jun 15 21:09:37 2017

Remove redundant IsFullscreenAppListEnabled()

Call featuers::IsFullscreenAppListEnabled() once and cache it.

This is a follow up CL for issue 2938563002.

BUG= 732067 
TEST="Add --enable-features=EnableFullscreenAppList to see the changes"

Review-Url: https://codereview.chromium.org/2938953003
Cr-Commit-Position: refs/heads/master@{#479829}

[modify] https://crrev.com/4b7bd924b5d4c938a1df51270fa7bd74e632f66a/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/4b7bd924b5d4c938a1df51270fa7bd74e632f66a/ui/app_list/views/apps_grid_view.h

@newcomer, is the behavior of the page switcher as intended and can I mark this as fixed? 
Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment